Re: [xwiki-devs] [Proposal] Add a new perSpace property to the XWiki.ConfigurableClass class

On 26 Jul 2016, at 16:50, Alexandru Cotiuga &lt;alexandru.cotiuga(a)xwiki.com&gt; wrote: Hello again on this old abandoned conversation, Since the last time I answered on this topic, I closed as invalid the pull request <https://github.com/xwiki/xwiki-platform/pull/481> for adding the "visibility" xproperty to XWiki.ConfigurableClass and I created a new one which is available here <https://github.com/xwiki/xwiki-platform/pull/485>. Could anyone find some time to review it?

Thanks, Alex On Fri, Apr 15, 2016 at 12:17 PM, Alexandru Cotiuga < alexandru.cotiuga(a)xwiki.com&gt; wrote: > There is an issue [1] and a pull request [2] created for this topic. > > [1] http://jira.xwiki.org/browse/XWIKI-13321 > [2] https://github.com/xwiki/xwiki-platform/pull/481 > > Thanks, > Alex > > On Fri, Apr 15, 2016 at 12:06 PM, Eduard Moraru &lt;enygma2002(a)gmail.com&gt; > wrote: > >> +1 for "visibility", as it`s about configuration/customization and it >> would >> be in line with macros, JSX, SSX, etc. >> >> Thanks, >> Eduard >> >> On Tue, Apr 12, 2016 at 3:28 PM, Vincent Massol &lt;vincent(a)massol.net&gt; >> wrote: >> >>> Hi Alex, >>> >>>> On 12 Apr 2016, at 14:22, Alexandru Cotiuga < >> alexandru.cotiuga(a)xwiki.com&gt; >>> wrote: >>>> >>>> Hello devs, >>>> >>>> Since Nested Spaces has been introduced in XWiki, the need of >> configuring >>>> some applications at space level has also appeared. >>> >>> It was there before (skin, rights, etc) but I agree that it’s even more >>> important now. >>> >>>> There are already some configurable sections at space level: Look & >> Feel >>>> (Presentation, Page Elements, PanelWizard), Users & Groups (Rights: >> Page >>> & >>>> Children, Rights: Page) but they are not using the configurable class >> and >>>> they are defined in >>>> >>> >> https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwi… >>>> having perSpace key. >>>> >>>> The new installed applications that have a configuration page, can't >> be >>>> configured now at space level and what I'm proposing in order to ease >> the >>>> way this can be achieved is to add a new boolean property perSpace to >> the >>>> XWiki.ConfigurableClass class. >>> >>> I think I’d prefer instead to introduce a “visibility” xproperty similar >>> to what we have in wiki Macros and wiki components. Which could be for >> the >>> moment: WIKI, SPACE (later on we could maybe add some config options >> that >>> are only visible at the farm level, i.e. on the main wiki). Another use >>> case in the future could be to have user-level configuration options too >>> (with a visibility of USER); this could be a way to reuse >> ConfigurableClass >>> for both Admin UI and User Profile UI in the future. >>> >>> Of course this means deprecating the “configureGlobally”. >>> >>>> Another idea would be to create a mix between this non-existing >> property >>>> and existing configureGlobally property and to create a new one with >> some >>>> options: Wiki, Wiki & space, Space but this involves a lot of changes >> tha >>>> might not worth the effort. >>> >>> I think it’s worth introducing a “visibility” xproperty. >>> >>> Thanks >>> -Vincent >>> >>>> WDYT? >>>> >>>> Thanks, >>>> Alex