12 Aug
2009
12 Aug
'09
9:23 a.m.
Andreas Schaefer a écrit :
Hi Vincent
Ok, so I will go ahead and update the Feed Plugin to make it work for
the Blog from 1.9 (with Wiki 1.0) as well as the one with Wiki 2.0.
This means it will no longer work with a blog based on
XWiki.ArticleClass (version ?).
You can go ahead.. The FeedPlugin has not been used for Feed output for now.
The only part that we need to be very carefull with is the Feed
acquisition (reading feeds from the network)
I would also to add this methods to the API:
- String createFeedOutput(SyncdFeed feed, String type): this would
enable anyone to convert a feed into an output format without having
to overload so many methods
How is that different from
/**
* Converts a feed into its string representation using the
specified syntax
*
* @param feed any type of feed, implementing the {@link SyndFeed}
interface
* @param type the feed type (syntax) to use, <b>null</b> if none.
It can be any version of RSS or Atom. Some
* possible values are "rss_1.0", "rss_2.0" and
"atom_1.0"
* @return the string representation of the given feed using the
syntax associated with the specified feed type
*/
public String getFeedOutput(SyndFeed feed, String type)
{
return plugin.getFeedOutput(feed, type, getXWikiContext());
}
I hope that I have this done by tomorrow and will
attach a patch to a
JIRA report I am going to create (none of the open JIRA report matches
this issue). This should finally make the Blog Upgrade complete, I hope.
BTW I am going to upgrade my server to 2.0m3 when I become available
and will test as far as I can. In case something goes wrong I will
revert back to 1.9.2 but I hope I don't have to do it.
On another little note I was wondering what should I do with the Panels?
- Are the left on Wiki 1.0 code?
- Is there a Base Panel which is in Wiki 2.0 (Panel.PanelSheet)
- if not do we want to create a Wiki 2.0 based Panel Sheet?
The reason why I am asking is that I saw Jetty run out of memory or
stack space having a Blog Panel in Wiki 2.0 using Panel.PanelSheet. I
am not sure what is the reason but when I reverted the panels back to
1.0 the problems went away.
This probably requires some work and strategy from the core team to move
the Panels to full 2.0 syntax and as well support compatibility with old
panels..
But at one point a new default Wiki should definitively be full 2.0 syntax.
FINALLY is the idea, after the blog 2.0 upgrade, to
create a Blog
Plugin that would provide the code for a Blog inside Java? Or is that
a Macro or Extension?
Having a blog plugin to move some code to Java would definitively make
sense.
This plugin could also provide Blog Post APIs and Blog posting by email.
Ludovic
Cheers - Andy
On Aug 11, 2009, at 1:02 AM, Vincent Massol wrote:
--
Ludovic Dubost
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
On Aug 11, 2009, at 5:15 AM, Andreas Schaefer
wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Hi
I know that we all volunteer for this project and so this is not a
critic of anybody's work but I have to say that the Feed Plugin has
more holes than a Swiss cheese and I should know. I could work
around all the issues but now the SyndEntryDocumentSource class does
not render Wiki 2.0 code (hard coded to 1.0).
There is also an issue where the conversion of Categories fails in
the Rome Converters because the Categories is a String but the Rome
expects a SyncdCategory. The only conversion that works so far is
atom_0.3.
One of the problems I see with the Feed Plugin is that the test
suite is not sufficient and therefore many of the method now fail in
2.0. I would volunteer to help to build it if someone could show me
to how to setup a test environment where I could execute the Feed
Plugin against (Blog first). Is there a plugin that tests against a
mock up XWiki to make sure it is working?
Yes, the feed plugin was written pre-new architecture (component-based
with tests)... It'll need to be redesigned/rewritten at some points to
align it. This rewrite is not planned by any current committer so this
will take a while (unless someone volunteers to do it) so I think it's
safe to fix it here and there if needed for the moment.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs