Re: [xwiki-devs] [Discussion] Set virtual=1 by default and deprecate the virtual mode API

Hi devs, To further fuel this discussion, I will mention some points that are more or less problematic when removing the notion of virtual mode (checks for xwiki.isVirtualMode()), since a direct change would leave a some pieces of code dead (never called) or just need a bit of discussion on them: 1. c.x.x.s.XWikiHibernateBaseStore.initHibernate(XWikiContext context) [1] That piece of code seems to only run when the wiki is not in virtual mode. "in your hibernate configuration if you set a database which is not called 'xwiki'. In virtual mode this configuration is not taken into account and you have to indicate the name of the database in xwiki.cfg". I think we need to review this behavior. IMO, we should do take this configuration into account in virtual mode as well, as long as there is no other technical impediment. It is a configuration for the main wiki after all, and it should still be valid. 2. c.x.x.XWiki.onPluginPreferenceEvent(Event event, XWikiDocument doc, XWikiContext context) [3] This piece of code seems to reload the plugins if the "plugins" property changed in XWikiPreferences, but only if the wiki is not in virtual mode. I think we need to change this to happen for any wiki and the plugins need to be reloaded only for that specific wiki for which the change happened (if it is possible). 3. extension.vm - extensionActionButton macro [4] This UI code decides when to displays the (Un)Install button of an extension for the current wiki or for the entire farm. Removing the virtual mode check will always show the (un)install on farm button. I think Marius had some concerns about his one. 4. distribution.vm - displayMainUiStep_unknownPreviousUI [5] This code assumes that if virtualMode is true, then the product is XEM, otherwise it's XE. This is used to propose old version names for the 2 products. Obviously this is needs to be refactored and use a different way of determining which is which. 5. c.x.x.p.w.WikiManager public List<Wiki> getAllWikis(XWikiContext context) throws XWikiException [6] We have decided that c.x.x.XWiki.getVirtualWikisDatabaseNames will also return the main wiki's name. However, the WikiManager plugin can not do this so easily because the main wiki's descriptor may not exist. How could we handle this, in order to be consistent? Would creating programmatically the main wiki's descriptor with default values on ApplicationReady event do any good? Will it do any harm? Thanks, Eduard ---------- [1] https://github.com/xwiki/xwiki-platform/blob/3019c6e0df112adf980641c75aaaff… [2] https://github.com/xwiki/xwiki-platform/commit/ce3d9d28aefdb327d407ef179a4c… [3] https://github.com/xwiki/xwiki-platform/blob/3019c6e0df112adf980641c75aaaff… [4] https://github.com/xwiki/xwiki-platform/blob/3019c6e0df112adf980641c75aaaff… [5] https://github.com/xwiki/xwiki-platform/blob/3019c6e0df112adf980641c75aaaff… [6] https://github.com/xwiki/xwiki-platform/blob/3019c6e0df112adf980641c75aaaff… On Fri, Feb 22, 2013 at 3:48 PM, Eduard Moraru &lt;enygma2002(a)gmail.com&gt; wrote: