Re: [xwiki-devs] [Proposal] Change Panel usage of ID attribute in favor of CLASS attribute + naming strategy

Hi, We have a pb if we display several times the same panel on a page (for ex for the search panel) since if the panel defines an ID this ID will not be unique in the page and thus will produce invalid XHTML. This happens for ex when you're on the panel page itself and that panel is displayed in the right or left columns. I'm proposing that we change the use of ID in favor of CLASSNAME for panels. For example for the search panel right now we have: #panelhiddenheader($msg.get("panels.search.title")) <form action="$xwiki.getURL('Main.WebSearch')"> <div id="globalsearch"> <input id="globalsearchinput" type="text" name="text" ... It'll become: #panelhiddenheader($msg.get("panels.search.title")) <form action="$xwiki.getURL('Main.WebSearch')"> <div class="globalsearch"> <input id="globalsearchinput" type="text" name="text" I think it would also be best to define a naming strategy. What about "panel-<short name of the panel page in lowercase and without any panel suffix>" So for Panels.Search it would be "panel-search" and for Panels.QuickLinks it would be "panel-quicklinks" Note: Changing id="globalsearch" to class="globalsearch" (or class="panel-search") means changing lots of places in the skins (albatross, finch, toucan, colibri). But I don't see any better way anyway. Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs