Re: [xwiki-devs] Map Application - GSoC 19

On Wed, Jun 19, 2019 at 11:30 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote: You can read more details about the tests in the documentation https://dev.xwiki.org/xwiki/bin/view/Community/Testing/#HSelenium2-basedFra… You should first start by making the setup: download the Firefox 32 (I know is an older version, but is the one used by our agents) https://dev.xwiki.org/xwiki/bin/view/Community/Testing/#HBrowserversion and try to run the existing tests for the applications. After you see them in actions it will be much easier to understand a flow of a test and the page objects needed. There is also this page https://dev.xwiki.org/xwiki/bin/view/Onboarding/TrackTests/ with some links. We have more tests in platform and in the main modules (if you will need more examples) but start simple. Having automated tests makes sure the functionality still works after changes and reduced the need for manual testing. If you haven't written tests before I'm sure you will find quite fun to see the test run live :) Thanks, Caty > > Thanks, > Fawad > > > > On Wed, Jun 19, 2019 at 9:36 PM Ecaterina Moraru (Valica) < > valicac(a)gmail.com&gt; wrote: > >> Regarding tests, there are some contrib apps with tests: >> >> https://github.com/xwiki-contrib/application-forum/tree/master/application-… >> >> https://github.com/xwiki-contrib/application-tour/tree/master/application-t… >> >> Good luck with your exams, >> Caty >> >> On Wed, Jun 19, 2019 at 7:32 PM Ecaterina Moraru (Valica) < >> valicac(a)gmail.com&gt; wrote: >> >>> Hi, >>> >>> How about: >>> * Maximizing the app area by removing the right panels; >>> * Have the map take all the available space >>> https://up1.xwikisas.com/#CnVVQ4JOC1ZPzAHSSbyAaQ >>> * Controls: Search, Full Screen, Zoom >>> >>> * If the user want to search >>> https://up1.xwikisas.com/#UYDXywBeRfcwLX6d06NVtA >>> * expand the search control: allow input and facets using an overlay >>> >>> * If the user has results >>> https://up1.xwikisas.com/#LoeVbE9idboPvoG2w3dE0Q >>> * display using overlay. center map on result click >>> * allow further filtering through facets >>> >>> These are just ideas, maybe there are other solutions. >>> Thanks, >>> Caty >>> >>> >>> On Wed, Jun 19, 2019 at 6:59 PM Stéphane Laurière &lt;slauriere(a)xwiki.com&gt; >>> wrote: >>> >>>> Hi Fawad, hi all, >>>> >>>> > Hi all, >>>> > >>>> > I just gave a try to the latest code, well done with the Solr >>>> queries and the search integration in the user interface, that's cool! >>>> > >>>> > Thanks Stephane. :) >>>> > >>>> > Imho the most convenient UX is the following for these widgets, >>>> something similar to this map: >>>> > >>>> > http://carte.preference-commerce.fr/cci-fr/ >>>> > >>>> > That is: >>>> > >>>> > - The facets can get activated from a button. When they get >>>> activated, they show up in an overlay panel on top of the map, without >>>> hiding the list. >>>> > - The list gets displayed under the search input, in an overlay >>>> as well, and can be completely hidden on request >>>> > >>>> > >>>> > Just to clarify things, the facets here refer to the "Refine your >>>> search" area, the search input refers to the "Search in map" text input and >>>> the list refers to the map item search results. Is that right? >>>> >>>> Yes indeed, >>>> >>>> > If so, I believe, given the nature of XWiki's design with widgets to >>>> both the right and left (for the default flavor), the space is a little >>>> cramped for overlaying anything on the map. For the implementation of full >>>> screen maps, we can overlay search and facets but for the normal view, the >>>> map will become very small. >>>> > >>>> > Here is a mockup I prepared based on my understanding of your >>>> suggestions: https://up1.xwikisas.com/#SB7B5mLNnfnUVAogWTLarw >>>> > Let me know what you think? >>>> >>>> I think it's an efficient way to layout the widgets indeed. I agree >>>> the map may look cramped in case there are panels on the left and on the >>>> right, but the user typically would have an option to hide the results, >>>> ideally. There's one change I would suggest, that would be to layout the >>>> filters either as an overlay or as a replacement of the list, and to move >>>> the filter button closer to the search input. Regarding the filter >>>> position: the Airbnb search illustrated below behaves quite nicely imho >>>> (when you hit "More filters", you get a new panel on top with all the >>>> filters), what do you think? >>>> >>>> https://up1.xwikisas.com/#zNABtIwH-Z-hSSUgFx-y4Q >>>> >>>> As for the information associated with each point or area, we have >>>> several options: either place it in popups on top of the map like Airbnb, >>>> or have it in the search result area, like what Google Maps proposes, or >>>> display it in a lateral panel like GoGoCarto. I would opt for popups by >>>> default, and if possible later on, leave the option to display it in the >>>> search area in case of large content, what do you think? Ideally, the panel >>>> for displaying this information would be a template that could be easily >>>> styled and customized for each map? >>>> >>>> > I have also come up with an idea to generalize the museum maps >>>> import and export you created, Stephane. We could have a standard form of >>>> wikidata query with some extra custom parameters for each location like the >>>> MuseumClass in the Museums' case. These extra parameter will be checked in >>>> JSON and classes will be created if required so that objects can be >>>> associated to each map item and then later facets can be used based upon >>>> these newly created classes. >>>> > WDYT? >>>> >>>> I think that'd be a nice feature generally speaking to ease the import >>>> of Wikidata into XWiki indeed, I have a side project on which I'm >>>> considering such developments as well, not sure yet about the outcome. If >>>> you feel like it will be useful for generating more demo maps, I'd say >>>> that'd be good indeed, but with the caveat of not digging too much in that >>>> direction for not hampering the map development of course. >>>> >>>> > Also, due to unprecedented circumstances within college, my exams >>>> have been delayed for this week and will start from next week. So I will be >>>> working this whole week on the project as opposed to what I told earlier. >>>> >>>> Ok, thank you for letting us know. >>>> >>>> I'd say at this stage that'd be great to keep progressing on >>>> functional testing automation and to finalize and release 1.0, I guess >>>> we're in tune but, as you did since the beginning, don't hesitate to raise >>>> questions about the priorities and the next steps of course. >>>> >>>> Wishing you good work days ahead, >>>> >>>> Cheers >>>> >>>> Stéphane >>>> >>>> >>>> > Best, >>>> > Fawad >>>> > >>>> > >>>> > On Mon, Jun 17, 2019 at 11:04 PM Stéphane Laurière < >>>> slauriere(a)xwiki.com <mailto:slauriere@xwiki.com>> wrote: >>>> > >>>> > Hi Fawad, Caty, all, >>>> > >>>> > > Hi all, >>>> > > Hoping that everything is going well. >>>> > > >>>> > > Stephane, I was able to do implement most of your suggestions >>>> except the search results list. >>>> > >>>> > I just gave a try to the latest code, well done with the Solr >>>> queries and the search integration in the user interface, that's cool! >>>> > >>>> > > I am not too sure where I should place it. As per the latest >>>> build, the filter widget appears to the left. Do you think it is practical >>>> that we replace this widget with the search results when the user wants to >>>> see the search results and show the widget back again when the user clicks >>>> on the widget control? I am not too sure what approach I should choose here >>>> in terms of UX. >>>> > > Ecaterina, your views on this would help a lot. Thanks. :) >>>> > >>>> > Imho the most convenient UX is the following for these widgets, >>>> something similar to this map: >>>> > >>>> > http://carte.preference-commerce.fr/cci-fr/ >>>> > >>>> > That is: >>>> > >>>> > - The facets can get activated from a button. When they get >>>> activated, they show up in an overlay panel on top of the map, without >>>> hiding the list. >>>> > - The list gets displayed under the search input, in an overlay >>>> as well, and can be completely hidden on request >>>> > >>>> > It's rather close to what Google Maps proposes as well, except >>>> that the facets replace the list in that case (when hitting "Autres >>>> filtres"), which is a bit less convenient in my opinion, but not a big deal: >>>> > >>>> > >>>> https://www.google.com/maps/search/Restaurants/@48.865957,2.352974,16z >>>> > >>>> > What do you think? >>>> > >>>> > > Also, do you foresee the map to take full browser height and >>>> width as is seen in all the examples you gave me? >>>> > >>>> > That would be a nice feature to have a button on the map to turn >>>> it full-screen indeed, similarly to what happens with the XWiki text editor. >>>> > >>>> > Cheers >>>> > >>>> > Stéphane >>>> > >>>> > > Regarding the release, I will try preparing everything by >>>> tonight so that it is available for your review, including the demo tests >>>> that Vincent suggested. >>>> > > >>>> > > Best, >>>> > > Fawad >>>> > > >>>> > > >>>> > > On Thu, Jun 13, 2019 at 12:59 PM Stéphane Laurière < >>>> slauriere(a)xwiki.com <mailto:slauriere@xwiki.com> <mailto: >>>> slauriere(a)xwiki.com <mailto:slauriere@xwiki.com>>> wrote: >>>> > >>>> >>>> >>>> -- >>>> Stéphane Laurière >>>> XWiki – https://xwiki.com >>>> >>>>