17 Feb
2012
17 Feb
'12
10:17 a.m.
Hi Edy,
great initiative!
On Fri, Feb 17, 2012 at 9:31 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:
Approach to aggregate both types is possible. However
this will require
some changes in existing APIs.
There is the doc.getComments() API which could be extended with a parameter
saying wether we want to add the annotations or not.
The default behavior could be a setting in the xwiki.cfg.
This might also require to update the REST api.
Ludovic
2012/2/16 Eduard Moraru <enygma2002(a)gmail.com>
I like this approach better since it doesn't break existing APIs, keeps all
the existing functionality of both annotations and comments and doesn't
require a migrator.
One question I have with this scenario however is this: would one be able
to respond to an annotation with threaded comments? In any case, we could
have a first version where annotations are shown as top-level comments that
cannot accept sub-comments, which would already be a good start.
Guillaume
Hi devs,
Based on the work done by Anca and Sorin doring the XWiki 2011 Seminar
Hackaton, I`ve made the following pull request [1] to integrate their
work
with minor changes.
A summary of the changes contained by the pull request are described in
the
jira issue [2].
The problem at the current stage, as Jerome also hinted, is that we need
to
do a migration script to make the existing
annotations (in an upgrade
scenario) use the XWikiComments class instead so that they can be picked
up
by commentsinline.vm. However, this might lose
the possibility to provide
custom annotations.
An alternative would be to make commentsinline.vm use the annotation
service and handle and retrieve both Annotation and XWikiComment objects.
This way, the current annotations should need no migration script since
they are using a class configured in the AnnotationConfig page that the
annotation service knows how to handle.
WDYT?
Thanks,
Eduard
----------
[1] https://github.com/xwiki/xwiki-platform/pull/34
[2] http://jira.xwiki.org/browse/XWIKI-7540
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Ludovic Dubost
Founder and CEO
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs