18 Feb
2015
18 Feb
'15
3:07 p.m.
2015-02-18 14:56 GMT+01:00 vincent(a)massol.net <vincent(a)massol.net>et>:
On 12 Jan 2015 at 17:01:36, Guillaume Louis-Marie Delhumeau (
gdelhumeau@xwiki.com(mailto:gdelhumeau@xwiki.com)) wrote:
detection
Hello.
No, I did not have time to do it earlier and it seems we do not have a
clear agreement on this.
Thanks,
2015-01-05 13:35 GMT+01:00 Ecaterina Moraru
(Valica) :
one
+0 if it's really needed.
Well, it is not really needed. We can also decide that we support only syntax and set it in xwiki.properties. But it is
not the way we usually
do
in XWiki.
>
> From an user perspective it's a shame that we are polluting the Skin
class
> with a setting that will be rarely used and
that we cannot
auto-determine
the
doctype from the skin's htmlheader.vm
We can actually render htmlheaders.vm, detect the doctype (string on "> request.
But what if htmlheaders.vm is not correctly rendered (because of an #if()
somewhere)?
I think this solution is relatively complicated for very few benefit.
An other idea is to put this setting in skin.properties only. The
reasoning
is that if you create a skin on the wiki, unless
you overrides all the
templates, you will need to use the same syntax than the parent skin, in
the FS. This way, we don't add a field in the Skin Class, and things
looks
easier. This is the solution I will put in place
internally in order to
have valid HTML5 in XWiki 6.4, but this discussion still remains for 7.x.
Has this been done already for 6.4? I don’t remember seeing it.
Note that AFAIK skins don’t need to have a parent nowadays (and by default
new skins don’t have parents).
Thanks
-Vincent
[snip]
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Guillaume Delhumeau (gdelhumeau(a)xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project