[xwiki-devs] Questions on the new XMLRPC implementation tests

Hi Fabio, I was looking at the new XMLRPC tests and I think there are some unfinished stuff we need to clean up/align. Right now there are 2 series of tests: ones in com.xpn package and one in org.xwiki package: addTestCase(suite, AnonymousAccessTest.class); addTestCase(suite, AttachmentsTest.class); addTestCase(suite, CommentsTest.class); addTestCase(suite, PagesTest.class); addTestCase(suite, SpacesTest.class); addTestCase(suite, org.xwiki.xmlrpc.AttachmentsTest.class); addTestCase(suite, org.xwiki.xmlrpc.AuthenticationTest.class); addTestCase(suite, org.xwiki.xmlrpc.CommentsTest.class); addTestCase(suite, org.xwiki.xmlrpc.PagesTest.class); addTestCase(suite, org.xwiki.xmlrpc.SpacesTest.class); addTestCase(suite, org.xwiki.xmlrpc.XWikiClassesTest.class); addTestCase(suite, org.xwiki.xmlrpc.XWikiObjectsTest.class); addTestCase(suite, org.xwiki.xmlrpc.SearchTest.class); We need to merge them (not sure why there are 2 locations). The correct package is probably com.xpn since the org.xwiki one is reserved for new components. Also I've noticed that lots of your new tests are using System.out calls. I don't think we should do that. The tests shouldn't print anything at all. They should do asserts wherever required but they should not require any visual verification to verify that they have passed or not IMO. Also this is the strategy we've followed so far. WDYT? Do you think you could have a look at those points? Thanks a lot -Vincent