Re: [xwiki-devs] [VOTE] Release XE 1.4M2

On Apr 22, 2008, at 7:05 PM, Jean-Vincent Drean wrote: Is the new AllDocs page working now? I think we need to retest it before we release it. I'm volunteering for that since last time I tried there were a lot of problems. BTW JV, have you been able to apply Sergiu and my comments on Evelina's patch for AllDocs, like renaming usersandgroups.css since it's no longer about users and groups. I don't remember if there were other comments. I also think we maybe need to do some smoke tests about the new xmlrpc implementation and verify XEclipse continues working. WDYT? (has this already been done, after it's been committed? It's important to test after changes are made since they can break the original patch). I also think I've discovered a problem in the patch for redirects. The following isn't correct I think: XWiki xwiki; try { xwiki = XWiki.getXWiki(context); } catch (XWikiException e) { if (e.getCode() == XWikiException.ERROR_XWIKI_DOES_NOT_EXIST) { if (!sendGlobalRedirect(response, context.getURL().toString(), context)) response .sendRedirect(context.getWiki().Param("xwiki.virtual.redirect")); return null; } else { throw e; } } // Send global redirection (if any) if (sendGlobalRedirect(response, context.getURL().toString(), context)) { return null; } Since sendGlobalRedirect does a response.sendRedirect and we're doing another one in the catch... Thanks -Vincent