On Sep 5, 2011, at 2:54 PM, Thomas Mortagne wrote:
On Fri, Sep 2, 2011 at 9:14 AM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu Dumitriu
<sergiu(a)xwiki.com> wrote:
On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it.
Yes it's far from it since a long time now.
Also its name is bridge, not model-bridge so there is nothing to
rename. Even the packages of this modules never refer to "model".
There is user, skins, and right related classes/methods since a very
long time now so I think the moved as been already doneā¦
Fine with me to continue using the same name with the understanding that it contains
classes related to the old model but that don't have compile-time dependencies to the
oldcore.
+1
Thanks
-Vincent
>
>>
>>> At the same time I would also like to come with ActionExecutedEvent in
>>> the bridge to replace the ActionExecuteEvent which is currently in
>>> observation API (and that should never have been there).
>>
>> +1.
>>
>>> WDYT ?
>>>
>>> here is my +1
>>
>> +1.
>>
>> I think they should also be cancellable, blocking requests if they fail
>> some conditions.
>>
>> --
>> Sergiu Dumitriu