5 Dec
2008
5 Dec
'08
5:12 p.m.
On Fri, Dec 5, 2008 at 10:54 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
What I had in mind is something we see in thumbnails, we make the
image fit in a 320x320px square, if the height of the image is bigger
than its width then the width will be 320px, but it'll be inferior
otherwise.
I think it's the only way to guaranty that the image will be "Small",
if we just set the width to 320px then a 320x2000px image won't be
small.
WDYT ?
Yep, that's why I did it that way :)
The first or the second ? did you meant b) here ?
I've updated this mockup too.
1) Image size
------------------
In the mockup you can see a dropdown allowing to set some predefined
sizes to the image (inspired by google docs).
I don't like the text "up to 320 pixels wide". What does "up to"
mean?
It suggests a range, but it means exactly 320. - I'm not sure that we'll be able to
combine position center + text flow.
As you did in screenshot "External image", when position is Center,
disable "wrap".
4) Preview
--------------
I've put an image preview in the mockup, we've multiple choices:
a) Drop it since it makes the dialog heavy.
a) Keep it stupid simple, the image is represented by a placeholder
and the 6 possible states are "prerecorded" (could be images).
d) Make it an advanced preview, the image is the selected image, the
preview takes the size of the image into account (by calculating what
the selected size would look like compared to the page content in a
predefined resolution, like 1024x768).
+1 for a) (the first or the second). Votes for external image insertion :
As with the link wizard, when uploading a new image, why return to step
1 and not 2?
When selecting a file, do we make sure only images are
listed? When
uploading a new file, do we check if it has an accepted image extension,
or do we accept all files?
IMO: display images only. validate filetype before upload.
In the "breadcrumb" on the second step, what
happens when the text is
too long? Implementers, make sure you test this.
IMO: overflow hidden + text-align right.
JV.