Re: [xwiki-devs] [Contrib] Redmine-Macro

Hi OJ (hope this is the right way to call you ;)), First let me say that I’m very happy that you’ve shared and published this extension, this is awesome! :) We now have 2 SCM for which we offer some tooling: JIRA and Redmine. Now that the project is set up I can propose some improvements below (feel free to discard them if you don’t like them): * I see that you don’t have any JIRA project for your Redmine Macro. We can create one for you so that users can report issues or improvements (or anyone working on the project) * The macro artifact id was not correct and I’ve just fixed it. I’ve also added a better .gitignore. I’ve also removed tabs in the pom.xml and replaced them with 2 spaces (this is one of the best practice we follow for XML files when developing the XWiki project. You don’t have to follow them for your Redmine project though. In case you’re interested they are defined here: http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle * I’ve renamed the Redmine page on e.x.o to http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro to make it nicer for SEO… I’ve also updated the README.md file. * I’d suggest to rename the space from Redmine-Macro to RedmineMacro or just Redmine. We don’t usually use “-“ in space names. * Why not have a single {{redmine}} Macro. I think it would be simpler to remember/type than “listRedmineIssues” and “listRedmineQueryResult” :). AFIU the second one lists all issues so you could decide that if there are no “issues” parameters specified then all issues are listed, or something like that. * I’d suggest to rename the pages: "Redmine-Macro List” -> RedmineListMacro, “Redmine-Macro Issue” -> “RedmineIssueMacro”. In case you accept the previous suggestion, a single RedmineMacro page would be better of course ;) Thanks again and let me know if I can be of any help! -Vincent On 8 Aug 2014 at 20:58:59, O.J. Sousa Rodrigues (osoriojaques@gmail.com(mailto:osoriojaques@gmail.com)) wrote: