30 Jan
2014
30 Jan
'14
2:48 p.m.
+1 to move to legacy and to use xwiki.title.compatibility to disable the
feature.
On Thu, Jan 30, 2014 at 2:24 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
+1
2014-01-30 vincent(a)massol.net <vincent(a)massol.net>et>:
--
Denis Gervalle
SOFTEC sa - CEO
Good point with xwiki.title.compatibility I had
forgotten about it!
FTR:
#-# Defines whether title handling should be using the compatibility mode
or not. When the compatibility
#-# mode is active, if the document's content first header (level 1 or
level 2) matches the document's title
#-# the first header is stripped.
xwiki.title.compatibility=1
Thanks
-Vincent
On 30 Jan 2014 at 14:16:13, Thomas Mortagne (thomas.mortagne(a)xwiki.com
(mailto:thomas.mortagne@xwiki.com)) wrote:
convert
On Thu, Jan 30, 2014 at 2:06 PM,
vincent(a)massol.net wrote:
> Hi devs,
>
> I'd like to propose removing the feature of extracting the title from
the
content in 6.x.
>
> The rationale is:
>
> * This is costing more than it should. It needs parsing the document
content
to get its XDOM and then to traverse it to find Heading blocks.
When we display doc titles in lists (in livetables for example or in the
activity stream) it costs a lot to do so.
>
> * Our implementation is broken since if you use an include macro that
generates a heading for ex, it won't be taken into account since we don't
apply transformations ATM when computing the title since it would be even
more expensive.
>
> Since 6.x is about performance I believe this would be a good step
forward.
>
> Now in order to handle backward compatibility. I propose that we:
> * Add a legacy configuration parameter to keep the behavior (but off
by
default). This would be in order to let users using this feature their wiki
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
We could reuse xwiki.title.compatibility for that too maybe.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
* Move the code to a legacy module (I hope
it's possible)
Here's my +1
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Big plus 1, I always been against keeping this xwiki/1.0 hack. We also
need to put xwiki.title.compatibility back to disabled by default (it
was initially disabled and then enabled supposedly temporary for wrong
reasons).
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs