20 Aug
2014
20 Aug
'14
11:07 a.m.
Just to give one example, AllDocsTest from the Index app is failing. One reason is that it
logs the user out to verify that the LT doesn’t display the actions reserved for admins.
So it does a:
// Logs out to be guest
page.logout();
And this in turn will use a skin UI element (the logout button at the top right).
Now you’re right that for this precise example, we could modify the test so that instead
of clicking the logout button we log out the user by using TestUtils, i.e. not make it
part of what we test. It could be cleaner. Of course we would need to have some other
functional tests to prove that logout works fine when clicked but we do have that in this
case.
But as I mentioned we still have a lot of skin-related test code and this pushes my
question to this code.
Thanks
-Vincent
On 20 Aug 2014 at 10:57:19, vincent(a)massol.net
(vincent@massol.net(mailto:vincent@massol.net)) wrote:
On 20 Aug 2014 at 10:51:51, Eduard Moraru
(enygma2002@gmail.com(mailto:enygma2002@gmail.com)) wrote:
Hi,
What I don`t fully understand is why changing a skin should affect the UI
tests of an application?
Page objects should be specific to the application's UI elements that are
custom coded to reflect the state of and to perform operations on the UI
elements of the tested application only. These UI elements should generally
be located inside the document's rendered content and should be minimally
impacted by a skin change. For me, an application should be limited as much
as possible to the document's rendered content.
When we are not testing applications, but the UI of XWiki itself, then
indeed, perhaps we should have both skin-specific page-objects and tests.
So my question is: How much is the current skin change affecting our UI
tests and at which level? Are application UI tests affected as well?
You can check by yourself from the commits done by GD yesterday and from the mail I sent
yesterday about the failing tests in platform.
I haven’t counted them.
Still there are lots of UI tests about the XWiki UI so the question remains.
Thanks
-Vincent
> Thanks,
> Eduard
>
>
> On Tue, Aug 19, 2014 at 9:02 PM, vincent(a)massol.net
> wrote:
>
> >
> >
> >
> >
> > On 19 Aug 2014 at 19:53:54, Sergiu Dumitriu (sergiu(a)xwiki.org(mailto:
> > sergiu(a)xwiki.org)) wrote:
> >
> > > On 08/19/2014 12:12 PM, vincent(a)massol.net wrote:
> > > > Hi devs,
> > > >
> > > > ATM our selenium2-based test fwk for functional tests only supports
> > one skin (Colibri).
> > > >
> > > > Guillaume is currently fixing the functional tests by changing our
> > test framework to work with Flamingo.
> > > >
> > > > After his changes are made our framework won’t work anymore with
> > Colibri.
> > > >
> > > > The question is:
> > > > * Is this ok?
> > > > * Do we want to change the framework to support multiple skins? In
> > this case we would need to introduce Interfaces everywhere, for each Page
> > Object to have various implementations.
> > > >
> > > > One example of difference is Hover vs Clicking for the top level
> > menus. Another example is that we don’t have anymore a contentmenu; it’s 3
> > buttons. Etc.
> > > >
> > > > Any opinion?
> > >
> > > Tests should work on different skins. At some point we did have some
> > > support for skins, in the old xe-test-selenium module [1], but this
> > > feature didn't survive the pageobjects revolution.
> >
> > Yes (I coded it). The main reason it didn’t survive is because several
> > skins didn’t survive and in the end we’ve been supporting only 1 skin for
> > years.
> >
> > The question are:
> > 1) whether we’re going to support several skins in the future or not?
> > We’ve already said we’re going drop Colibri when Flamingo is ready.
> > Supporting several skins in the test framework is a lot of effort.
> > 2) if we want to support several skins in the test fwk when is the right
> > time. ATM we’re late for Flamingo as the default skin for 6.2 and doing
> > this in 6.2 would mean postponing 6.2’s release by at least 1 to 2 weeks.
> >
> > Thanks
> > -Vincent
> >
> > > [1]
> > >
> >
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-test…
> > >
> > > --
> > > Sergiu Dumitriu
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
> >
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs