19 Dec
2009
19 Dec
'09
10:58 a.m.
Hi Asiri,
Right now I don't see any use case for reusing an openoffice module
outside of the office importer/exporter.
My current view:
- we could extract this module but as a nested submodule of xwiki-
officeimporter (could be renamed xwiki-office and have 3 submodules:
xwiki-office-importer, xwiki-office-exporter and xwiki-office-
openoffice)
- however I think it's a bit overkill to do so since I don't see
reusing the officeimporter without the openoffice module, etc.
Thus my current thinking is that I don't see the interest of doing so
and it's probably enough to make whatever separation is required
through package names (you already have the openoffice package which
sounds fine enough to me).
Thanks
-Vincent
On Dec 19, 2009, at 10:52 AM, Asiri Rathnayake wrote:
Hello Devs,
Currently xwiki-officeimporter contains logic for mainly two different
tasks:
1. Manage the back-end openoffice process (and provide document
conversion
facilities).
2. Perform the actual transformation from office documents to wiki
pages.
(depends on point 1)
xwiki-officeimporter module's code might appear a bit complex
because of
this mix up. Also I believe openoffice related code might have to be
reused
once we introduce an office-exporter module.
I was wondering if it would be beneficial (in the long run) to
extract out
openoffice related code into a separate module (xwiki-openoffice).
The main
concern I have is that currently openoffice related code is inside
org.xwiki.officeimporter.openoffice package which have to be changed
to
org.xwiki.openoffice if we are to extract out a xwiki-openoffice
module,
this could break a few things in public API.
Even if we decide to do so, I don't think any of us (devs) would be
able to
do this within 2.2M1 time period. But I thought it's better to
discuss about
it a little now.
Let me know what you think.
Thanks.
- Asiri