29 Jun
2010
29 Jun
'10
12:30 p.m.
Hi Asiri and all,
On Jun 1, 2010, at 11:28 AM, Asiri Rathnayake wrote:
Hi Devs,
I have almost completed my work on officepreview module and I would like to
discuss about integrating it into main source tree (and release it with
2.4M1). There are a couple of things to discuss:
1. officepreview module have to depend on xwiki-core for the time being
because with current component approach there is no way of determining the
version of an attachment (officepreview module needs to know attachment
version).
Shouldn't we add a DAB method for this?
2. Need a couple of tests - I'm working on this.
Asiri, any update on this?
3. Where to place the officepreview module in main
source tree.
platform/core IMO for now. Later, all office stuff should be refactored in xwiki-office
module probably and be a submodule (or do this now).
My initial idea for (3) was to create a
/platform/core/trunk/xwiki-officepreview submodule. However, since
officepreview module depends on officeimporter module, I'm not sure if we
should create a parent module that would host both of these projects.
Yes good idea.
Another problem lingering in my mind is that with
recent changes
xwiki-officeimporter module encapsulates two sub modules - a module capable
of converting documents from one format to another (this is a generic
converter api kind of thing) and another module which is importing office
documents into xwiki specific formats (XDOMOfficeDocumentBuilder,
PresentationBuilder etc.). I'm not sure if these two modules should be
seperated out, but may be that's a separate discussion.
I haven't followed enough the design to reply on this yet.
On another point, I'll take care of converting OfficePreviewVelocityBridge to a
ScriptService.
We need a service name. 2 solutions:
Solution 1:
=========
$services.office.preview(...)
This means 3 build modules:
- one for office converter (rename from office import)
- one for office preview
- one for office velocity (for unifying script services between office converter and
office preview). This needs moving OfficeImporterVelocityBridge to a ScriptService too
(which we need to do).
Solution 2:
=========
$services.officepreview.preview(....)
+ keep using $officeimporter for the office importer
WDYT?
Thanks
-Vincent
Please let me know your comments about above points.
Thanks.
- Asiri