5 Nov
2008
5 Nov
'08
4:42 a.m.
On Wed, Nov 5, 2008 at 8:54 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
asiri (SVN) wrote:
Author: asiri
Date: 2008-11-04 11:31:26 +0100 (Tue, 04 Nov 2008)
New Revision: 13949
+ private void filter(Node node)
+ {
+ if (node.hasAttributes()) {
+ try {
+ node.getAttributes().removeNamedItem("style");
+ } catch (DOMException ex) {
+ // Not a problem.
+ }
+ }
I don't like this... try-catch code is costly, since creating an
exception takes a lot of time and memory. Can't you check if the 'style'
attribute exists instead?
Fixed with :
<code>
if (node.hasAttributes() &&
node.getAttributes().getNamedItem("style") != null) {
try {
node.getAttributes().removeNamedItem("style");
} catch (DOMException ex) {
// Should not occur.
}
}
</code>
And a catch block in general should indicate an exceptional execution,
not a normal, expected case.
Agreed.
Thanks.
- Asiri
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs