28 Sep
2010
28 Sep
'10
1:48 p.m.
On Sep 28, 2010, at 1:42 PM, Marius Dumitru Florea wrote:
On 09/28/2010 02:30 PM, Vincent Massol wrote:
I don't understand why you would need to escape anything.
You only need to escape @ if the attachment names contains such a character.
Unless I'm missing something....
Thanks
-Vincent
On Sep 28, 2010, at 1:18 PM, Marius Dumitru Florea wrote:
On 09/28/2010 12:52 PM, Vincent Massol wrote:
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
> Hi devs,
>
> I'd like to rename the office-preview module to office-viewer since it
> better matches the current provided functionality: view office
> attachments (either inside a wiki page or standalone) without
> downloading them.
>
> Let me know if you are against this rename.
Fine with me. What would be the name of the
macro? {{office}}?)
{{office attachment="presentation.ppt"/}}
looks very good to me. Yes. We should make sure that the attachment
value takes an attachment entity reference so that we can refer to attachments on other
pages too.
Yep. This means that @ character will have to be escaped in the
attachment name when viewing an attachment from the current page:
{{office attachment="presentation\(a)xwiki.ppt"/}}
I'll make sure this is well documented.