Hi,
On Tue, Sep 21, 2010 at 11:11, Thomas Mortagne <thomas.mortagne(a)xwiki.com>wrote;wrote:
On Tue, Sep 21, 2010 at 11:01, Marius Dumitru
Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
Hi Jerome,
On 09/21/2010 11:39 AM, Jerome Velociter wrote:
> Hi Marius
>
> On Tue, Sep 21, 2010 at 7:12 AM, Marius Dumitru Florea<
> mariusdumitru.florea(a)xwiki.com> wrote:
>
>> Hi devs,
>>
>> I'm going to continue Asiri's work on integrating officepreview module
(
>>
http://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-officepreview/
>>> ) into the main source tree. Following the discussion at
>>
>>
http://xwiki.475771.n2.nabble.com/Discussion-Integrating-officepreview-modu…
>>> here are the steps that need to be taken:
>>
>>> * Extend
DocumentAccessBridge with a method to get the current version
>>> of an attachment in order to drop the dependency on xwiki-core:
>>
>>> String
getAttachmentVersion(AttachmentReference attachmentReference)
>>
>>> * Convert
OfficePreviewVelocityBridge to a ScriptService:
>>
>>>
$services.officepreview.preview($attachmentReference, $filterStyles)
>>
>>> * Move
/contrib/sandbox/xwiki-officepreview/ to
>>> /platform/core/xwiki-officepreview
>>
>>> * Publish the office
preview wiki macro on
code.xwiki.org
>>
>>
>> Do we want it bundled by default in XE ?
>>
>
>> I'd say yes.
>
> We need to decide first if we include wiki macros in the standard XE
> distribution. AFAIK the policy was to offer only Java macros by default.
> I'll publish the office preview macro on
code.xwiki.org first and then
> I'll send a vote to decide if we bundle it with XE by default.
Does it really need to be a wiki macro ?
Yes, I think it's better. It will allow more flexibility for people willing
to tweak the display of the preview. I've used the macro in its current
state on a project and I had to modify it a bit to fit the needs of my
users. Thus I think it's better this way.