1 Aug
2013
1 Aug
'13
6:41 p.m.
FTR I get the following failures when I build it:
Failed tests:
runAllPossibleConversions(org.artofsolving.jodconverter.OfficeDocumentConverterFunctionalTest):
officeHome not set and could not be auto-detected
executeTask(org.artofsolving.jodconverter.office.ExternalOfficeManagerTest): Cannot run
program
"/Users/vmassol/dev/xwiki/git/jodconverter/jodconverter-core/MacOS/soffice.bin":
error=2, No such file or directory
executeTask(org.artofsolving.jodconverter.office.PooledOfficeManagerTest): failed to
start and connect
restartAfterCrash(org.artofsolving.jodconverter.office.PooledOfficeManagerTest): failed
to start and connect
restartAfterTaskTimeout(org.artofsolving.jodconverter.office.PooledOfficeManagerTest):
failed to start and connect
restartWhenMaxTasksPerProcessReached(org.artofsolving.jodconverter.office.PooledOfficeManagerTest):
failed to start and connect
sigarProcessManager(org.artofsolving.jodconverter.process.ProcessManagerTest):
org.hyperic.sigar.ptql.SigarProcessQuery.create(Ljava/lang/String;)V
Tests run: 9, Failures: 7, Errors: 0, Skipped: 1
Do you also get that Sergiu?
Thanks
-Vincent
On Aug 1, 2013, at 6:31 PM, Vincent Massol <vincent(a)massol.net> wrote:
On Aug 1, 2013, at 6:28 PM, Sergiu Dumitriu <sergiu(a)xwiki.org> wrote:
On 08/01/2013 12:24 PM, Sergiu Dumitriu wrote:
Thanks!
On 08/01/2013 12:21 PM, Vincent Massol wrote:
Done.
On Aug 1, 2013, at 6:09 PM, Sergiu Dumitriu <sergiu(a)xwiki.org> wrote:
> On 08/01/2013 11:44 AM, Vincent Massol wrote:
>> Hi devs,
>>
>> Jodconvert is dead and has been moved to
https://github.com/mirkonasato/jodconverter
>> (as its author says: "WARNING! This project is no longer maintained The code
has been moved to GitHub in the hope that somebody else will fork and maintain it.")
>>
>> We currently have patches and our sources are in our maven repo at
>>
http://maven.xwiki.org/externals/org/artofsolving/jodconverter/jodconverter…
>>
>> I'm proposing to:
>> * fork https://github.com/mirkonasato/jodconverter in our xwiki organization
>> * update the READM to explain why we've forked it
>> * apply our sources from
http://maven.xwiki.org/externals/org/artofsolving/jodconverter/jodconverter…
on it
>> * work on fixing http://jira.xwiki.org/browse/XWIKI-9380 (this is the real reason
I'm proposing all this :)).
>>
>> WDYT?
>>
>> Thanks
>> -Vincent
>
> I've already forked it in my local account and fixed a few things, so I
> could move that to xwiki, instead of starting from scratch.
>
> https://github.com/sdumitriu/jodconverter/commits/master
ok I had started already. So what I propose is that I remove the fork I did and you give
ownership to the xwiki org of your repo.
OK. >> Does your repo match what's on
http://maven.xwiki.org/externals/org/artofsolving/jodconverter/jodconverter…
?
>
> No, since I wasn't sure our patches were indeed the best solution. They
> were refused by the old maintainer, and with somewhat valid arguments.
I don't understand.
What happens if I release a version from https://github.com/xwiki/jodconverter/ now? Are
we going to find regressions in XWiki?
What I wanted to know is we need to apply some patches to
https://github.com/xwiki/jodconverter/commits/master to make it match the sources on
http://maven.xwiki.org/externals/org/artofsolving/jodconverter/jodconverter…
Thanks
-Vincent
>> Thanks
>> -Vincent
>>
>>> There are a few others that also have active forks, we should look at
>>> what other fixes are available in these forks. Nuxeo and ExpertSystems
>>> seem to have the most commits.
>>>
>>> https://github.com/mirkonasato/jodconverter/network