Re: [xwiki-devs] [proposal] Process to handle Pull Requests

Definitely +1 for JIRA. I've created a custom field called "Pull Request Status" with 3 states: * awaiting creation of pull request * awaiting committer feedback * awaiting contributor feedback The workflow is the following: * If someone creates a jira issue with a patch we should ask him for a pull request, "awaiting creation of pull request" * Then once the PR is created, the contributor (or us when we do jira cleanup) should move it to "awaiting committer feedback" * If the PR is missing stuff (tests, code best practices, design issue, etc) then the committer should comment in jira or in the PR itself and change the state to "awaiting contributor feedback" We have a filter that finds all issues having "patch" as a label, "patch" as a keyword or the "Pull Request Status" value not being empty (I hope this one works, I haven't tested it). You can see it here: http://jira.xwiki.org/secure/Dashboard.jspa#Issue-Statistics/10472 It's listed on the JIRA home page. There are 43 open issues with patches ATM. We need to review them and set the "Pull Request Status". We need to decide what to do with "old" patches from the time when we didn't have PR. We should probably just consider them as having PR and set the field status to either "awaiting committer feedback" or "awaiting contributor feedback". WDYT? Is that good enough?