14 Nov
2011
14 Nov
'11
2:39 p.m.
On Mon, Nov 14, 2011 at 2:51 PM, Vincent Massol <vincent(a)massol.net> wrote:
On Nov 14, 2011, at 1:41 PM, Eduard Moraru wrote:
IMO it's very fine in the Dashboard app and would be overkill to create a
+1,
Also, what about the Dashboard macro itself? Can it be moved inside
something like
xwiki-platform/xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro?
It's a wiki macro. I wouldn't create a new app just for it.
new app just for 1 page (I also don't see what it
would bring more).
Well, it's actually not a wiki macro so it's not located in the Dashboard
wiki page (if that's what you were referring to). It's a java macro and
it`s located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwi…
My note was just about grouping the UI elements (pages you mentioned) with
the code elements (macro) under the same feature named directory, just like
we do for most features/modules; instead of going through 2-3 locations to
find the code related to Dashboard, for instance.
Thanks,
Eduard
Thanks
-Vincent
Thus, we would also have something like
xwiki-platform/xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-ui
for the xwiki pages. This would organize it more
like a feature.
WDYT?
Thanks,
Eduard
On Mon, Nov 14, 2011 at 1:18 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote;wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
+1
On Mon, Nov 14, 2011 at 11:23 AM, Vincent Massol <vincent(a)massol.net>
wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs Hi devs,
I'd like to introduce a Dashboard Application in a
xwiki-platform/xwiki-platform-core/xwiki-platform-dashboard/ module.
It would contain the following pages:
1/ Main.Dashboard.xml (currently in XE's app)
2/ The pages making up the user dashboard
(XWiki.UserDashboardPreferencesClass,
XWiki.XWikiUserDashboardSheet)
(currently in Admin app)
3/ A new page which will have the logic to choose
to display the user
dashboard or the main shared dashboard (currently this code is
in
Main.WebHome in XE's app)
Also I'd like to suggest introducing a Dashboard space and have all the
above-mentioned pages in that space.
Dashboard.WebHome would contain 3/.
And Main.WebHome would simply do an include of Dashboard.WebHome.
Note that this would allow the following:
* Ability to cleanly document the Dashboard feature on
extensions.xwiki.org and
have it visible on enterprise.xwiki.org for
example
* It goes in the direction of splitting our XE
XAR in discrete
application
* It groups together (functionally) a domain
(dashboard) which means
that if a user doesn't want the dashboard feature, we
can simply not
install it or remove it easily.
WDYT?
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs