20 Nov
2009
20 Nov
'09
11:40 a.m.
On 11/20/2009 2:18 AM, Florin Ciubotaru wrote:
Thanks,
Florin Ciubotaru
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Hi,
On 11/20/2009 12:04 AM, Sergiu Dumitriu wrote:
Cleanup submited to http://jira.xwiki.org/jira/browse/XWIKI-4608
Commiters are invited for a review.
Patches:
- http://jira.xwiki.org/jira/secure/attachment/16247/XWIKI-4608-core.patch
- http://jira.xwiki.org/jira/secure/attachment/16245/XWIKI-4608-web.patch
Note that if applying the patches after XWikiContextInitializationFilter
class is moved to core, then the filter mapping in the second patch will
also need to be changed.
On 11/19/2009 06:11 PM, Marius Dumitru Florea
wrote:
> Hi devs,
>
> I'd like to move
>
http://svn.xwiki.org/svnroot/xwiki/platform/web/trunk/wysiwyg/src/main/java…
> to
>
http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-core/src/main/…
>
> Here's my +1.
>
>
+1
- Will it only be used by the gwtrpc servlet?
No, IMO it is recommended that all servlets use it.
- If not, do you plan to rework the code in
XWikiAction that does mostly
the same thing?
Probably not. The code is redundant in several places and will be
replaced in time. Marius did the gwtrpc implemetation, I'll do the
xmlrpc cleanup.
- Why is the
context mode configured in the filter?
The mode is set in the filter to replace the behavior inside
Utils.prepareXWikiContext. Currently the mode is set by checking the
type of the request. Eg: the only purpose of the class XmlRpcRequest is
to provide a different type for the instance of the XWikiRequest while
in prepareContext. This is not nice, and impossible to use with filters,
as a custom instantiation cannot be done before the filter. Using filter
parameters and servlet mapping seems more elegant, thus setting the mode
in the filter.