2 Sep
2011
2 Sep
'11
8:52 a.m.
Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
At the same time I would also like to come with ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
WDYT ?
here is my +1
--
Thomas Mortagne
2 Sep
2 Sep
8:56 a.m.
On Fri, Sep 2, 2011 at 8:52 AM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
At the same time I would also like to come with ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
s/ActionExecuteEvent/ActionExecutionEvent/
observation API (and that should never have been
there).
WDYT ?
here is my +1
--
Thomas Mortagne
--
Thomas Mortagne
9:06 a.m.
On Sep 2, 2011, at 8:52 AM, Thomas Mortagne wrote:
Hi devs,
I started to move (very) old notification system to legacy
I've seen this: very nice!
but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
I'm not sure if the model bridge module is the right place. Right now it contains some
event classes but they are events related to Model entities.
We could put this temporary class in the oldcore. I call it temporary since it will be
replaced in the future with the new Action module.
At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1 to remove that event from the observation api since it's definitely not the place.
I'd not put this new event class in the bridge for the same reason as above. I'd
put it next to the other one.
Thanks
-Vincent
WDYT ?
here is my +1
--
Thomas Mortagne
9:13 a.m.
On Fri, Sep 2, 2011 at 9:06 AM, Vincent Massol <vincent(a)massol.net> wrote:
--
Thomas Mortagne
On Sep 2, 2011, at 8:52 AM, Thomas Mortagne wrote:
Actually I did wanted to put it in oldcore at first but it will make a
migration nightmare for anyone that used to use ActionExecutionEvent
without depending on oldcore. Bridge is ok since ActionExecutionEvent
has exactly the same parameters that document related events which are
readable in most part with bridge APIs.
Hi devs,
I started to move (very) old notification system to legacy
I've seen this: very nice!
but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
I'm not sure if the model bridge module is the right place. Right now it contains
some event classes but they are events related to Model entities.
We could put this temporary class in the oldcore. I call it temporary since it will be
replaced in the future with the new Action module. At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1 to remove that event from the observation api since it's definitely not the
place.
I'd not put this new event class in the bridge for the same reason as above. I'd
put it next to the other one.
Thanks
-Vincent
WDYT ?
here is my +1
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
9:11 a.m.
On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it.
At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1.
WDYT ?
here is my +1
+1.
I think they should also be cancellable, blocking requests if they fail
some conditions.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
9:14 a.m.
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
--
Thomas Mortagne
On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Yes it's far from it since a long time now.
Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it. At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1.
WDYT ?
here is my +1
+1.
I think they should also be cancellable, blocking requests if they fail
some conditions.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5 Sep
5 Sep
2:54 p.m.
On Fri, Sep 2, 2011 at 9:14 AM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
--
Thomas Mortagne
--
Thomas Mortagne
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu Dumitriu
<sergiu(a)xwiki.com> wrote:
Also its name is bridge, not model-bridge so there is nothing to
rename. Even the packages of this modules never refer to "model".
There is user, skins, and right related classes/methods since a very
long time now so I think the moved as been already done...
On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Yes it's far from it since a long time now. Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it. At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1.
WDYT ?
here is my +1
+1.
I think they should also be cancellable, blocking requests if they fail
some conditions.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
3:26 p.m.
On Sep 5, 2011, at 2:54 PM, Thomas Mortagne wrote:
On Fri, Sep 2, 2011 at 9:14 AM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Fine with me to continue using the same name with the understanding that it contains
classes related to the old model but that don't have compile-time dependencies to the
oldcore.
+1
Thanks
-Vincent
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu Dumitriu
<sergiu(a)xwiki.com> wrote:
Also its name is bridge, not model-bridge so there is nothing to
rename. Even the packages of this modules never refer to "model".
There is user, skins, and right related classes/methods since a very
long time now so I think the moved as been already done… On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Yes it's far from it since a long time now. Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it.
>
>>
>>> At the same time I would also like to come with ActionExecutedEvent in
>>> the bridge to replace the ActionExecuteEvent which is currently in
>>> observation API (and that should never have been there).
>>
>> +1.
>>
>>> WDYT ?
>>>
>>> here is my +1
>>
>> +1.
>>
>> I think they should also be cancellable, blocking requests if they fail
>> some conditions.
>>
>> --
>> Sergiu Dumitriu
5:42 p.m.
On 09/05/2011 08:54 AM, Thomas Mortagne wrote:
On Fri, Sep 2, 2011 at 9:14 AM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Indeed, my bad. So, +1 for this.
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu
Dumitriu<sergiu(a)xwiki.com> wrote:
Also its name is bridge, not model-bridge so there is nothing to
rename. Even the packages of this modules never refer to "model". On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Yes it's far from it since a long time now. Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it. There is user, skins, and right related
classes/methods since a very
long time now so I think the moved as been already done...
>
>>
>>> At the same time I would also like to come with ActionExecutedEvent in
>>> the bridge to replace the ActionExecuteEvent which is currently in
>>> observation API (and that should never have been there).
>>
>> +1.
>>
>>> WDYT ?
>>>
>>> here is my +1
>>
>> +1.
>>
>> I think they should also be cancellable, blocking requests if they fail
>> some conditions.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
2 Sep
2 Sep
9:15 a.m.
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Sure why not, I will also make them implements BeginEvent/EndEvent interfaces.
Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it.
At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1.
WDYT ?
here is my +1
+1.
I think they should also be cancellable, blocking requests if they fail
some conditions.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
9:21 a.m.
On 09/02/2011 03:15 AM, Thomas Mortagne wrote:
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu
Dumitriu<sergiu(a)xwiki.com> wrote:
Hm, then if something blocks the execution by canceling the event, will
the matching EndEvent be fired? Will it be a problem if a BeginEvent
with no EndEvent is fired?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Sure why not, I will also make them implements BeginEvent/EndEvent interfaces. Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it.
At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1.
WDYT ?
here is my +1
+1.
I think they should also be cancellable, blocking requests if they fail
some conditions.
9:29 a.m.
On Fri, Sep 2, 2011 at 9:21 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
On 09/02/2011 03:15 AM, Thomas Mortagne wrote:
ActionExecutionEvent is already sent in a finally so that should be
ok. In any case for this particular use case that would not be a big
issue I think since the event stack is stored in the ExecutionContext
and there is not much code executed after an action is executed
generally.
On Fri, Sep 2, 2011 at 9:11 AM, Sergiu
Dumitriu<sergiu(a)xwiki.com> wrote:
Hm, then if something blocks the execution by canceling the event, will
the matching EndEvent be fired? Will it be a problem if a BeginEvent
with no EndEvent is fired? On 09/02/2011 02:52 AM, Thomas Mortagne wrote:
Sure why not, I will also make them implements BeginEvent/EndEvent interfaces. Hi devs,
I started to move (very) old notification system to legacy but I'm
stuck because there is one thing still not supported by new
observation system: event sent before executing an action.
So here it is: I propose to add it with the name ActionExecutingEvent
in the bridge.
-1 for the bridge, unless we rename it from model-bridge to
oldcore-bridge, since it actually bridges the connection between
components and the oldcore. Initially it was supposed to be a mockup of
the future model component only, but it looks like it's far from it.
At the same time I would also like to come with
ActionExecutedEvent in
the bridge to replace the ActionExecuteEvent which is currently in
observation API (and that should never have been there).
+1.
WDYT ?
here is my +1
+1.
I think they should also be cancellable, blocking requests if they fail
some conditions.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
4857
days inactive
4860
days old
11 comments
3 participants
participants (3)
-
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol