[xwiki-devs] [Proposal] Change Panel usage of ID attribute in favor of CLASS attribute + naming strategy
29 Sep
2009
29 Sep
'09
9:19 a.m.
Hi,
We have a pb if we display several times the same panel on a page (for
ex for the search panel) since if the panel defines an ID this ID will
not be unique in the page and thus will produce invalid XHTML.
This happens for ex when you're on the panel page itself and that
panel is displayed in the right or left columns.
I'm proposing that we change the use of ID in favor of CLASSNAME for
panels.
For example for the search panel right now we have:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div id="globalsearch">
<input id="globalsearchinput" type="text"
name="text" ...
It'll become:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div class="globalsearch">
<input id="globalsearchinput" type="text"
name="text"
I think it would also be best to define a naming strategy. What about
"panel-<short name of the panel page in lowercase and without any
panel suffix>"
So for Panels.Search it would be "panel-search" and for
Panels.QuickLinks it would be "panel-quicklinks"
Note: Changing id="globalsearch" to class="globalsearch" (or
class="panel-search") means changing lots of places in the skins
(albatross, finch, toucan, colibri). But I don't see any better way
anyway.
Thanks
-Vincent
29 Sep
29 Sep
9:36 a.m.
New subject: [xwiki-devs] [Proposal] Change Panel usage of ID attribute in favor of CLASS attribute + naming strategy
+1
-arvind
On Tue, Sep 29, 2009 at 12:49, Vincent Massol <vincent(a)massol.net> wrote:
Hi,
We have a pb if we display several times the same panel on a page (for
ex for the search panel) since if the panel defines an ID this ID will
not be unique in the page and thus will produce invalid XHTML.
This happens for ex when you're on the panel page itself and that
panel is displayed in the right or left columns.
I'm proposing that we change the use of ID in favor of CLASSNAME for
panels.
For example for the search panel right now we have:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div id="globalsearch">
<input id="globalsearchinput" type="text"
name="text" ...
It'll become:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div class="globalsearch">
<input id="globalsearchinput" type="text"
name="text"
I think it would also be best to define a naming strategy. What about
"panel-<short name of the panel page in lowercase and without any
panel suffix>"
So for Panels.Search it would be "panel-search" and for
Panels.QuickLinks it would be "panel-quicklinks"
Note: Changing id="globalsearch" to class="globalsearch" (or
class="panel-search") means changing lots of places in the skins
(albatross, finch, toucan, colibri). But I don't see any better way
anyway.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
9:48 a.m.
Vincent Massol wrote:
Hi,
We have a pb if we display several times the same panel on a page (for
ex for the search panel) since if the panel defines an ID this ID will
not be unique in the page and thus will produce invalid XHTML.
This happens for ex when you're on the panel page itself and that
panel is displayed in the right or left columns.
I'm proposing that we change the use of ID in favor of CLASSNAME for
panels.
For example for the search panel right now we have:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div id="globalsearch">
<input id="globalsearchinput" type="text"
name="text" ...
It'll become:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div class="globalsearch">
<input id="globalsearchinput" type="text"
name="text"
Wouldn't you still have the issue with the input's ID ? In more
generally it means no panel can define any ID...
I think it would also be best to define a naming strategy. What about
"panel-<short name of the panel page in lowercase and without any
panel suffix>"
What about "panel:panel-name" ?
Jerome.
So for Panels.Search it would be "panel-search" and for
Panels.QuickLinks it would be "panel-quicklinks"
Note: Changing id="globalsearch" to class="globalsearch" (or
class="panel-search") means changing lots of places in the skins
(albatross, finch, toucan, colibri). But I don't see any better way
anyway.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
9:51 a.m.
New subject: [xwiki-devs] [Proposal] Change Panel usage of ID attribute in favor of CLASS attribute + naming strategy
On Sep 29, 2009, at 9:48 AM, Jerome Velociter wrote:
I don't understand why you duplicate the word "panel".
Thanks
-Vincent
Vincent Massol wrote:
yes...
Hi,
We have a pb if we display several times the same panel on a page
(for
ex for the search panel) since if the panel defines an ID this ID
will
not be unique in the page and thus will produce invalid XHTML.
This happens for ex when you're on the panel page itself and that
panel is displayed in the right or left columns.
I'm proposing that we change the use of ID in favor of CLASSNAME for
panels.
For example for the search panel right now we have:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div id="globalsearch">
<input id="globalsearchinput" type="text"
name="text" ...
It'll become:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div class="globalsearch">
<input id="globalsearchinput" type="text"
name="text"
Wouldn't you still have the issue with the input's ID ? In more
generally it means no panel can define any ID... I think it
would also be best to define a naming strategy. What about
"panel-<short name of the panel page in lowercase and without any
panel suffix>"
What about "panel:panel-name" ?
Jerome.
>
> So for Panels.Search it would be "panel-search" and for
> Panels.QuickLinks it would be "panel-quicklinks"
>
> Note: Changing id="globalsearch" to class="globalsearch" (or
> class="panel-search") means changing lots of places in the skins
> (albatross, finch, toucan, colibri). But I don't see any better way
> anyway.
>
> Thanks
> -Vincent
9:52 a.m.
New subject: [xwiki-devs] [Proposal] Change Panel usage of ID attribute in favor of CLASS attribute + naming strategy
On Sep 29, 2009, at 9:51 AM, Vincent Massol wrote:
On Sep 29, 2009, at 9:48 AM, Jerome Velociter wrote:
I don't understand why you duplicate the word "panel".
If you mean to use namespaces, then we need to be careful. We looked
at it before and there were some problems with some browsers AFAIR.
-Vincent
Vincent Massol wrote:
yes...
Hi,
We have a pb if we display several times the same panel on a page
(for
ex for the search panel) since if the panel defines an ID this ID
will
not be unique in the page and thus will produce invalid XHTML.
This happens for ex when you're on the panel page itself and that
panel is displayed in the right or left columns.
I'm proposing that we change the use of ID in favor of CLASSNAME for
panels.
For example for the search panel right now we have:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div id="globalsearch">
<input id="globalsearchinput" type="text"
name="text" ...
It'll become:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div class="globalsearch">
<input id="globalsearchinput" type="text"
name="text"
Wouldn't you still have the issue with the input's ID ? In more
generally it means no panel can define any ID... I think
it would also be best to define a naming strategy. What
about
"panel-<short name of the panel page in lowercase and without any
panel suffix>"
What about "panel:panel-name" ? Thanks
-Vincent
>
> Jerome.
>>
>> So for Panels.Search it would be "panel-search" and for
>> Panels.QuickLinks it would be "panel-quicklinks"
>>
>> Note: Changing id="globalsearch" to class="globalsearch" (or
>> class="panel-search") means changing lots of places in the skins
>> (albatross, finch, toucan, colibri). But I don't see any better way
>> anyway.
>>
>> Thanks
>> -Vincent
9:56 a.m.
Vincent Massol wrote:
On Sep 29, 2009, at 9:48 AM, Jerome Velociter wrote:
I don't understand why you duplicate the word "panel".
My bad, it was not clear... I meant "panel:search",
"panel:quicklinks"
Jerome.
Vincent Massol wrote:
yes...
Hi,
We have a pb if we display several times the same panel on a page
(for
ex for the search panel) since if the panel defines an ID this ID
will
not be unique in the page and thus will produce invalid XHTML.
This happens for ex when you're on the panel page itself and that
panel is displayed in the right or left columns.
I'm proposing that we change the use of ID in favor of CLASSNAME for
panels.
For example for the search panel right now we have:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div id="globalsearch">
<input id="globalsearchinput" type="text"
name="text" ...
It'll become:
#panelhiddenheader($msg.get("panels.search.title"))
<form action="$xwiki.getURL('Main.WebSearch')">
<div class="globalsearch">
<input id="globalsearchinput" type="text"
name="text"
Wouldn't you still have the issue with the input's ID
? In more
generally it means no panel can define any ID... I think
it would also be best to define a naming strategy. What about
"panel-<short name of the panel page in lowercase and without any
panel suffix>"
What about "panel:panel-name" ?
Thanks
-Vincent
Jerome.
> So for Panels.Search it would be "panel-search" and for
> Panels.QuickLinks it would be "panel-quicklinks"
>
> Note: Changing id="globalsearch" to class="globalsearch" (or
> class="panel-search") means changing lots of places in the skins
> (albatross, finch, toucan, colibri). But I don't see any better way
> anyway.
>
> Thanks
> -Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5466
days inactive
5466
days old
5 comments
3 participants
participants (3)
-
Arvind Gupta -
Jerome Velociter -
Vincent Massol