30 Jul
2013
30 Jul
'13
3:01 p.m.
For the Workspace integration in XE, I need to modify the default XARs. It
makes me able to provide template XARs for the creation of subwikis, which
will be different from the XAR of the main wiki (for example: we don't need
the WorkspaceManager UI in every subwikis).
What I propose to do:
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
3/ Add *xwiki-enterprise-wiki-ui* as a dependency of *xwiki-enterprise-ui*.
This will be a temporary solution, because we will have flavours in the
future.
WDYT?
Louis-Marie
30 Jul
30 Jul
7:25 p.m.
Hi,
I suggest using the "-template-" name component, as in
"xwiki-enterprise-workspace-template-ui" to avoid confusion with the
xwiki-platform artefact(s).
On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
For the Workspace integration in XE, I need to modify
the default XARs. It
makes me able to provide template XARs for the creation of subwikis, which
will be different from the XAR of the main wiki (for example: we don't need
the WorkspaceManager UI in every subwikis).
What I propose to do:
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
3/ Add *xwiki-enterprise-wiki-ui* as a dependency of *xwiki-enterprise-ui*.
What do you want to achieve by doing this?
Thanks,
Eduard
This will be a temporary solution, because we will have flavours in the
future.
WDYT?
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
31 Jul
31 Jul
11:03 a.m.
Hi Edy
2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
Hi,
I suggest using the "-template-" name component, as in
"xwiki-enterprise-workspace-template-ui" to avoid confusion with the
xwiki-platform artefact(s).
Since it will be a dependency of xwiki-enterprise-ui, does it make sense to
call it template?
On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
What do you want to achieve by doing this?
Currently we generate workspace-template.xar in xwiki-manager-ui by copying
the xwiki-enterprise-ui-all XAR. But I am integrating Workspaces in XE so
if we keep this construction, every workspace that use this template will
have the WorkspaceManager too!
So, I need to clearly separate what is the XE UI and what is a template UI.
For the Workspace integration in XE, I need to
modify the default XARs.
It
makes me able to provide template XARs for the
creation of subwikis,
which
will be different from the XAR of the main wiki
(for example: we don't
need
the WorkspaceManager UI in every subwikis).
What I propose to do:
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines
what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
*xwiki-enterprise-ui*.
Thanks,
Eduard
Thanks,
Louis-Marie
This will be a temporary solution, because we will have flavours in the
future.
WDYT?
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5:32 p.m.
On Wed, Jul 31, 2013 at 12:03 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
Hi Edy
2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
Hi,
I suggest using the "-template-" name component, as in
"xwiki-enterprise-workspace-template-ui" to avoid confusion with the
xwiki-platform artefact(s).
Since it will be a dependency of xwiki-enterprise-ui, does it make sense to
call it template?
On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
What do you want to achieve by doing this?
Currently we generate workspace-template.xar in xwiki-manager-ui by copying
the xwiki-enterprise-ui-all XAR. But I am integrating Workspaces in XE so
if we keep this construction, every workspace that use this template will
have the WorkspaceManager too!
For the Workspace integration in XE, I need to
modify the default XARs.
It
makes me able to provide template XARs for the
creation of subwikis,
which
will be different from the XAR of the main wiki
(for example: we don't
need
the WorkspaceManager UI in every subwikis).
What I propose to do:
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines
what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
*xwiki-enterprise-ui*.
So, I need to clearly separate what is the XE UI and
what is a template UI.
I got that :) I was actually asking about point 3. Making the XAR xe-ui
depend on wiki-ui means what? To me it does not mean much, because you are
not going to install the wiki-ui XAR, using EM, as a transitive dependency
of xe-ui (where such a dependency declaration might be useful in a way).
And even if you do that, all the contents of the wiki-ui XAR would be
imported into the main wiki and that is not what you want by the current
logic of Wiki/WorkspaceManager.
So, unless I got it wrong, you might want to skip point 3.
Thanks,
Eduard
Thanks,
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
This will be a temporary solution, because we will have flavours in the
future.
WDYT?
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
6:43 p.m.
On Wed, Jul 31, 2013 at 5:32 PM, Eduard Moraru <enygma2002(a)gmail.com> wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
On Wed, Jul 31, 2013 at 12:03 PM, Guillaume
"Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
In Guillaume's proposal xwiki-enterprise-ui is going to be the XE main
wiki XAR which mean what you have in a generic subwiki (pretty much
the old XE xar) plus what used to be in XEM. So among other things
xwiki-enterprise-wiki-ui is going to be the default subwiki base UI
extension from DW point of view (like it's XE right now in XEM).
Hi Edy
2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
Hi,
I suggest using the "-template-" name component, as in
"xwiki-enterprise-workspace-template-ui" to avoid confusion with the
xwiki-platform artefact(s).
Since it will be a dependency of xwiki-enterprise-ui, does it make sense to
call it template?
On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
What do you want to achieve by doing this?
Currently we generate workspace-template.xar in xwiki-manager-ui by copying
the xwiki-enterprise-ui-all XAR. But I am integrating Workspaces in XE so
if we keep this construction, every workspace that use this template will
have the WorkspaceManager too!
For the Workspace integration in XE, I need to
modify the default XARs.
It
makes me able to provide template XARs for the
creation of subwikis,
which
will be different from the XAR of the main wiki
(for example: we don't
need
the WorkspaceManager UI in every subwikis).
What I propose to do:
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines
what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
*xwiki-enterprise-ui*.
So, I need to clearly separate what is the XE UI
and what is a template UI.
I got that :) I was actually asking about point 3. Making the XAR xe-ui
depend on wiki-ui means what? To me it does not mean much, because you are
not going to install the wiki-ui XAR, using EM, as a transitive dependency
of xe-ui (where such a dependency declaration might be useful in a way).
And even if you do that, all the contents of the wiki-ui XAR would be
imported into the main wiki and that is not what you want by the current
logic of Wiki/WorkspaceManager.
So, unless I got it wrong, you might want to skip point 3.
Thanks,
Eduard
Thanks,
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
This will be a temporary solution, because we will have flavours in the
future.
WDYT?
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
7:04 p.m.
Yep, got that too. Anyway, I`ll wait for the pull request/merge instead of
creating noise on the list :)
Thanks,
Eduard
On Wed, Jul 31, 2013 at 7:43 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote;wrote:
On Wed, Jul 31, 2013 at 5:32 PM, Eduard Moraru
<enygma2002(a)gmail.com>
wrote:
UI.
I got that :) I was actually asking about point 3. Making the XAR xe-ui
depend on wiki-ui means what? To me it does not mean much, because you are
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
On Wed, Jul 31, 2013 at 12:03 PM, Guillaume
"Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
> Hi Edy
>
> 2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
>
> > Hi,
> >
> > I suggest using the "-template-" name component, as in
> > "xwiki-enterprise-workspace-template-ui" to avoid confusion with the
> > xwiki-platform artefact(s).
> >
>
> Since it will be a dependency of xwiki-enterprise-ui, does it make
sense to
> call it template?
>
>
> >
> > On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie" Delhumeau
<
> > gdelhumeau(a)xwiki.com> wrote:
> >
> > > For the Workspace integration in XE, I need to modify the default
XARs.
> > It
> > > makes me able to provide template XARs for the creation of subwikis,
> > which
> > > will be different from the XAR of the main wiki (for example: we
don't
> > need
> > > the WorkspaceManager UI in every subwikis).
> > >
> > > What I propose to do:
> > >
> > > 1/ Create a subproject *xwiki-enterprise-workspace-ui*, which
defines
> > what
> > > a workspace should be.
> > > 1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
> > > xwiki-enterprise-distribution*
> > >
> > > 2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines
what a
> > > subwiki should be.
> > > 2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
> > > xwiki-enterprise-distribution*
> > >
> > > 3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
> > *xwiki-enterprise-ui*.
> > >
> >
> > What do you want to achieve by doing this?
> >
>
> Currently we generate workspace-template.xar in xwiki-manager-ui by
copying
> the xwiki-enterprise-ui-all XAR. But I am
integrating Workspaces in XE
so
> if we keep this construction, every workspace
that use this template
will
have the
WorkspaceManager too!
> So, I need to clearly separate what is the XE UI and what is a template not going to install the wiki-ui XAR, using EM,
as a transitive
dependency
of xe-ui (where such a dependency declaration
might be useful in a way).
And even if you do that, all the contents of the wiki-ui XAR would be
imported into the main wiki and that is not what you want by the current
logic of Wiki/WorkspaceManager.
So, unless I got it wrong, you might want to skip point 3.
In Guillaume's proposal xwiki-enterprise-ui is going to be the XE main
wiki XAR which mean what you have in a generic subwiki (pretty much
the old XE xar) plus what used to be in XEM. So among other things
xwiki-enterprise-wiki-ui is going to be the default subwiki base UI
extension from DW point of view (like it's XE right now in XEM).
>
>
> >
> > Thanks,
> > Eduard
> >
> > >
> > > This will be a temporary solution, because we will have flavours in
the
> future.
>
> WDYT?
>
> Louis-Marie
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Thanks,
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
1 Aug
1 Aug
3:13 p.m.
Eddy,
About 3:
In my first implementation, I wanted to make xwiki-enterprise-ui depends on
xwiki-enterprise-wiki-ui because for me, the main wiki is like a subwiki
PLUS some specific pages. There is no page of the subwiki that I don't want
to have on the main wiki.
But it is only because it is what we have now.
Now I understand that if we really want to have distinct XARs, this
dependency is a problem.
My purpose was also to avoid maintaning 2 pom files. If I create a new
module that I want to have in both XARS, I just have to add it to the
wiki-ui pom.xml.
But I guess it is a mistake.
--------
New proposal :
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
BTW it make sense only if we want to keep the distinction between subwikis
and workspaces.
3/ Maintain the 3 poms: *xwiki-enterprise-workspace-ui,
**xwiki-enterprise-workspace-ui
*AND* **xwiki-enterprise-ui* when you want to add a module for all the
wikis.
Thanks Edy for your remarks, that I think I now understand.
WDYT ?
Thanks,
Guillaume D aka Louis-Marie
2013/7/31 Eduard Moraru <enygma2002(a)gmail.com>
Yep, got that too. Anyway, I`ll wait for the pull
request/merge instead of
creating noise on the list :)
Thanks,
Eduard
On Wed, Jul 31, 2013 at 7:43 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote;wrote:
template
in
On Wed, Jul 31, 2013 at 5:32 PM, Eduard Moraru
<enygma2002(a)gmail.com>
wrote:
subwikis,
On Wed, Jul 31, 2013 at 12:03 PM, Guillaume
"Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
> Hi Edy
>
> 2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
>
> > Hi,
> >
> > I suggest using the "-template-" name component, as in
> > "xwiki-enterprise-workspace-template-ui" to avoid confusion with the
> > xwiki-platform artefact(s).
> >
>
> Since it will be a dependency of xwiki-enterprise-ui, does it make
sense to
> call it template?
>
>
> >
> > On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie" Delhumeau
<
> > gdelhumeau(a)xwiki.com> wrote:
> >
> > > For the Workspace integration in XE, I need to modify the default
XARs.
>> > It
>> > > makes me able to provide template XARs for the creation of > >
which
> > > will be different from the XAR of the main wiki (for example: we
don't
> > need
> > > the WorkspaceManager UI in every subwikis).
> > >
> > > What I propose to do:
> > >
> > > 1/ Create a subproject *xwiki-enterprise-workspace-ui*, which
defines
> > what
> > > a workspace should be.
> > > 1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
> > > xwiki-enterprise-distribution*
> > >
> > > 2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines
what a
> > > subwiki should be.
> > > 2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
> > > xwiki-enterprise-distribution*
> > >
> > > 3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
> > *xwiki-enterprise-ui*.
> > >
> >
> > What do you want to achieve by doing this?
> >
>
> Currently we generate workspace-template.xar in xwiki-manager-ui by
copying
> the xwiki-enterprise-ui-all XAR. But I am
integrating Workspaces in XE
so
> if we keep this construction, every workspace
that use this template
will
>> have the WorkspaceManager too!
>>
>
>> So, I need to clearly separate what is the XE UI and what is a UI.
I got that :) I was actually asking about point 3. Making the XAR xe-ui
depend on wiki-ui means what? To me it does not mean much, because you are
way).
not going to install the wiki-ui XAR, using EM,
as a transitive
dependency
> of xe-ui (where such a dependency declaration might be useful in a > And even if you do that, all the contents of
the wiki-ui XAR would be
> imported into the main wiki and that is not what you want by the
current
logic of
Wiki/WorkspaceManager.
So, unless I got it wrong, you might want to skip point 3.
In Guillaume's proposal xwiki-enterprise-ui is going to be the XE main
wiki XAR which mean what you have in a generic subwiki (pretty much
the old XE xar) plus what used to be in XEM. So among other things
xwiki-enterprise-wiki-ui is going to be the default subwiki base UI
extension from DW point of view (like it's XE right now in XEM).
>
>
>>
>>
>> >
>> > Thanks,
>> > Eduard
>> >
>> > >
>> > > This will be a temporary solution, because we will have flavours
the
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
> >
future.
> >
> > WDYT?
> >
> > Louis-Marie
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
> >
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
Thanks,
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
4:42 p.m.
Actually I think I am the one that got confused because of the fact that we
have both the current Workspace/WikiManager.Install way of doing things
(using the wiki-ui-all xar) and, as a next step, the EM way of doing things
(using the wiki-ui xar). If enterprise-ui depends on wiki-ui and you
install it with EM it will be OK. I kept thinking of wiki-ui-all when
instead I should have thought about wiki-ui.
That is what happens when you have to read between the lines :) Please try
to provide more details about *why* you are doing the proposed actions
instead of only listing *what* you plan to do.
+1 to the initial proposal. No duplication of poms.
Thanks and sorry for the noise,
Eduard
On Thu, Aug 1, 2013 at 4:13 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
Eddy,
About 3:
In my first implementation, I wanted to make xwiki-enterprise-ui depends on
xwiki-enterprise-wiki-ui because for me, the main wiki is like a subwiki
PLUS some specific pages. There is no page of the subwiki that I don't want
to have on the main wiki.
But it is only because it is what we have now.
Now I understand that if we really want to have distinct XARs, this
dependency is a problem.
My purpose was also to avoid maintaning 2 pom files. If I create a new
module that I want to have in both XARS, I just have to add it to the
wiki-ui pom.xml.
But I guess it is a mistake.
--------
New proposal :
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
BTW it make sense only if we want to keep the distinction between subwikis
and workspaces.
3/ Maintain the 3 poms: *xwiki-enterprise-workspace-ui,
**xwiki-enterprise-workspace-ui
*AND* **xwiki-enterprise-ui* when you want to add a module for all the
wikis.
Thanks Edy for your remarks, that I think I now understand.
WDYT ?
Thanks,
Guillaume D aka Louis-Marie
2013/7/31 Eduard Moraru <enygma2002(a)gmail.com>
XE
xe-ui
in
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Yep, got that too. Anyway, I`ll wait for the pull
request/merge instead
of
creating noise on the list :)
Thanks,
Eduard
On Wed, Jul 31, 2013 at 7:43 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote;wrote:
> On Wed, Jul 31, 2013 at 5:32 PM, Eduard Moraru <enygma2002(a)gmail.com>
> wrote:
> > On Wed, Jul 31, 2013 at 12:03 PM, Guillaume "Louis-Marie" Delhumeau
<
> > gdelhumeau(a)xwiki.com> wrote:
> >
> >> Hi Edy
> >>
> >> 2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
> >>
> >> > Hi,
> >> >
> >> > I suggest using the "-template-" name component, as in
> >> > "xwiki-enterprise-workspace-template-ui" to avoid confusion
with
the
> >> > xwiki-platform artefact(s).
> >> >
> >>
> >> Since it will be a dependency of xwiki-enterprise-ui, does it make
> sense to
> >> call it template?
> >>
> >>
> >> >
> >> > On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie"
Delhumeau <
> >> > gdelhumeau(a)xwiki.com>
wrote:
> >> >
> >> > > For the Workspace integration in XE, I need to modify the
default
XARs.
>> > It
>> > > makes me able to provide template XARs for the creation of
subwikis,
> >> > which
> >> > > will be different from the XAR of the main wiki (for example: we
> don't
> >> > need
> >> > > the WorkspaceManager UI in every subwikis).
> >> > >
> >> > > What I propose to do:
> >> > >
> >> > > 1/ Create a subproject *xwiki-enterprise-workspace-ui*, which
> defines
> >> > what
> >> > > a workspace should be.
> >> > > 1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
> >> > > xwiki-enterprise-distribution*
> >> > >
> >> > > 2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines
> what a
> >> > > subwiki should be.
> >> > > 2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
> >> > > xwiki-enterprise-distribution*
> >> > >
> >> > > 3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
> >> > *xwiki-enterprise-ui*.
> >> > >
> >> >
> >> > What do you want to achieve by doing this?
> >> >
> >>
> >> Currently we generate workspace-template.xar in xwiki-manager-ui by
> copying
> >> the xwiki-enterprise-ui-all XAR. But I am integrating Workspaces in so
template
> UI.
> >>
> >
> > I got that :) I was actually asking about point 3. Making the XAR > if we keep this construction, every workspace
that use this template
will
>> have the WorkspaceManager too!
>>
>
>> So, I need to clearly separate what is the XE UI and what is a > > depend on wiki-ui means what? To me it
does not mean much, because
you
are
way).
not going to install the wiki-ui XAR, using EM,
as a transitive
dependency
> of xe-ui (where such a dependency declaration might be useful in a > And even if you do that, all the contents of
the wiki-ui XAR would be
> imported into the main wiki and that is not what you want by the
current
logic of
Wiki/WorkspaceManager.
So, unless I got it wrong, you might want to skip point 3.
In Guillaume's proposal xwiki-enterprise-ui is going to be the XE main
wiki XAR which mean what you have in a generic subwiki (pretty much
the old XE xar) plus what used to be in XEM. So among other things
xwiki-enterprise-wiki-ui is going to be the default subwiki base UI
extension from DW point of view (like it's XE right now in XEM).
>
>
>>
>>
>> >
>> > Thanks,
>> > Eduard
>> >
>> > >
>> > > This will be a temporary solution, because we will have flavours
the
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
> > > future.
> > >
> > > WDYT?
> > >
> > > Louis-Marie
> > > _______________________________________________
> > > devs mailing list
> > > devs(a)xwiki.org
> > > http://lists.xwiki.org/mailman/listinfo/devs
> > >
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
> >
>
> Thanks,
> Louis-Marie
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
29 Aug
29 Aug
7:42 p.m.
Hi devs.
I made some modifications, it is not exactly the same as I proposed first,
but I have all explained in the following JIRA:
http://jira.xwiki.org/browse/XWIKI-9409
I have made a pull request for this work:
https://github.com/xwiki/xwiki-enterprise/pull/39
I hope you like it.
I won't work tomorrow, so enjoy a good week-end!
Louis-Marie
2013/8/1 Eduard Moraru <enygma2002(a)gmail.com>
Actually I think I am the one that got confused
because of the fact that we
have both the current Workspace/WikiManager.Install way of doing things
(using the wiki-ui-all xar) and, as a next step, the EM way of doing things
(using the wiki-ui xar). If enterprise-ui depends on wiki-ui and you
install it with EM it will be OK. I kept thinking of wiki-ui-all when
instead I should have thought about wiki-ui.
That is what happens when you have to read between the lines :) Please try
to provide more details about *why* you are doing the proposed actions
instead of only listing *what* you plan to do.
+1 to the initial proposal. No duplication of poms.
Thanks and sorry for the noise,
Eduard
On Thu, Aug 1, 2013 at 4:13 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
we
xe-ui
be
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Eddy,
About 3:
In my first implementation, I wanted to make xwiki-enterprise-ui depends
on
xwiki-enterprise-wiki-ui because for me, the main
wiki is like a subwiki
PLUS some specific pages. There is no page of the subwiki that I don't
want
to have on the main wiki.
But it is only because it is what we have now.
Now I understand that if we really want to have distinct XARs, this
dependency is a problem.
My purpose was also to avoid maintaning 2 pom files. If I create a new
module that I want to have in both XARS, I just have to add it to the
wiki-ui pom.xml.
But I guess it is a mistake.
--------
New proposal :
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines
what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
BTW it make sense only if we want to keep the distinction between
subwikis
and workspaces.
3/ Maintain the 3 poms: *xwiki-enterprise-workspace-ui,
**xwiki-enterprise-workspace-ui
*AND* **xwiki-enterprise-ui* when you want to add a module for all the
wikis.
Thanks Edy for your remarks, that I think I now understand.
WDYT ?
Thanks,
Guillaume D aka Louis-Marie
2013/7/31 Eduard Moraru <enygma2002(a)gmail.com>
Delhumeau <
Yep, got that too. Anyway, I`ll wait for the pull
request/merge instead
of
creating noise on the list :)
Thanks,
Eduard
On Wed, Jul 31, 2013 at 7:43 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote;wrote:
> On Wed, Jul 31, 2013 at 5:32 PM, Eduard Moraru <enygma2002(a)gmail.com
> > wrote:
> > > On Wed, Jul 31, 2013 at 12:03 PM, Guillaume "Louis-Marie" > >
gdelhumeau(a)xwiki.com> wrote:
> >
> >> Hi Edy
> >>
> >> 2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
> >>
> >> > Hi,
> >> >
> >> > I suggest using the "-template-" name component, as in
> >> > "xwiki-enterprise-workspace-template-ui" to avoid confusion
with
the
> >> > xwiki-platform artefact(s).
> >> >
> >>
> >> Since it will be a dependency of xwiki-enterprise-ui, does it make
> sense to
> >> call it template?
> >>
> >>
> >> >
> >> > On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie"
Delhumeau <
> >> > gdelhumeau(a)xwiki.com>
wrote:
> >> >
> >> > > For the Workspace integration in XE, I need to modify the
default
> > XARs.
> > >> > It
> > >> > > makes me able to provide template XARs for the creation of
> subwikis,
> > >> > which
> > >> > > will be different from the XAR of the main wiki (for
example: > > don't
> > >> > need
> > >> > > the WorkspaceManager UI in every subwikis).
> > >> > >
> > >> > > What I propose to do:
> > >> > >
> > >> > > 1/ Create a subproject *xwiki-enterprise-workspace-ui*,
which
> > defines
> > >> > what
> > >> > > a workspace should be.
> > >> > > 1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in
*
> > >> > > xwiki-enterprise-distribution*
> > >> > >
> > >> > > 2/ Create a subproject *xwiki-enterprise-wiki-ui*, which
defines
> > what a
> > >> > > subwiki should be.
> > >> > > 2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
> > >> > > xwiki-enterprise-distribution*
> > >> > >
> > >> > > 3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
> > >> > *xwiki-enterprise-ui*.
> > >> > >
> > >> >
> > >> > What do you want to achieve by doing this?
> > >> >
> > >>
> > >> Currently we generate workspace-template.xar in xwiki-manager-ui
by
> > copying
> > >> the xwiki-enterprise-ui-all XAR. But I am integrating Workspaces
in
XE
> > so
> > >> if we keep this construction, every workspace that use this
template
will
>> have the WorkspaceManager too!
>>
>
>> So, I need to clearly separate what is the XE UI and what is a
template
> UI.
> >>
> >
> > I got that :) I was actually asking about point 3. Making the XAR > > depend on wiki-ui means what? To me it
does not mean much, because
you
> > are
> > > not going to install the wiki-ui XAR, using EM, as a transitive
> > dependency
> > > of xe-ui (where such a dependency declaration might be useful in a
> way).
> > > And even if you do that, all the contents of the wiki-ui XAR would > > > imported into the main wiki and
that is not what you want by the
> current
> > > logic of Wiki/WorkspaceManager.
> > >
> > > So, unless I got it wrong, you might want to skip point 3.
> >
> > In Guillaume's proposal xwiki-enterprise-ui is going to be the XE
main
> > wiki XAR which mean what you have in a
generic subwiki (pretty much
> > the old XE xar) plus what used to be in XEM. So among other things
> > xwiki-enterprise-wiki-ui is going to be the default subwiki base UI
> > extension from DW point of view (like it's XE right now in XEM).
> >
> > >
> > >
> > >>
> > >>
> > >> >
> > >> > Thanks,
> > >> > Eduard
> > >> >
> > >> > >
> > >> > > This will be a temporary solution, because we will have
flavours
in
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
the
>> > > future.
>> > >
>> > > WDYT?
>> > >
>> > > Louis-Marie
>> > > _______________________________________________
>> > > devs mailing list
>> > > devs(a)xwiki.org
>> > > http://lists.xwiki.org/mailman/listinfo/devs
>> > >
>> > _______________________________________________
>> > devs mailing list
>> > devs(a)xwiki.org
>> > http://lists.xwiki.org/mailman/listinfo/devs
>> >
>>
>> Thanks,
>> Louis-Marie
>> _______________________________________________
>> devs mailing list
>> devs(a)xwiki.org
>> http://lists.xwiki.org/mailman/listinfo/devs
>>
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
3 Sep
3 Sep
4:19 p.m.
Hi devs!
I have talked with Vincent about this. We have discovered some issues with
the organisation I have proposed.
The main issue is that xwiki-entreprise-ui needs to attach
xwiki-entreprise-workspace-ui-all's xar into WorkspaceManager.Install (to
provide a default template), and xwiki-entreprise-workspace-ui-all is a
module of xwiki-entreprise-distribution. So there is a problem of
dependencies across the modules hierarchy and the build can't work.
Moreover, it was not clear that xwiki-entreprise-ui was designed to be the
main wiki UI and xwiki-entreprise-workspace-ui the template UI for
subwiki.
That's why we want to propose a new structure:
xwiki-entreprise-ui (pom):
* xwiki-entreprise-ui-common (xar)
* xwiki-entreprise-ui-mainwiki (xar)
* xwiki-entreprise-ui-subwiki (xar)
* xwiki-entreprise-ui-mainwiki-all (all-in-one xar)
* xwiki-entreprise-ui-subwiki-all (all-in-one xar)
xwiki-enterprise-distribution (pom):
* the same as current but without xwiki-entreprise-ui-all
In this way we don't have the dependencies across modules problem, and it
is very clear what is the main wiki XAR and what is the subwiki XAR.
In the xwiki-entreprise-ui-mainwiki's pom, we will put:
<xwiki.extension.features>
org.xwiki.enterprise:xwiki-enterprise-ui
</xwiki.extension.features>
in order to help the extensions manager retrieving the good XARs during an
upgrade.
But what about the Distribution Wizard? Do we have something special to add
in order to make xwiki-entreprise-ui-mainwiki the default XAR?
I hope my email is clear and thanks you in advance for your suggestions,
Guillaume
2013/8/29 Guillaume "Louis-Marie" Delhumeau <gdelhumeau(a)xwiki.com>
Hi devs.
I made some modifications, it is not exactly the same as I proposed first,
but I have all explained in the following JIRA:
http://jira.xwiki.org/browse/XWIKI-9409
I have made a pull request for this work:
https://github.com/xwiki/xwiki-enterprise/pull/39
I hope you like it.
I won't work tomorrow, so enjoy a good week-end!
Louis-Marie
2013/8/1 Eduard Moraru <enygma2002(a)gmail.com>
Actually I think I am the one that got confused
because of the fact that
we
have both the current Workspace/WikiManager.Install way of doing things
(using the wiki-ui-all xar) and, as a next step, the EM way of doing
things
(using the wiki-ui xar). If enterprise-ui depends on wiki-ui and you
install it with EM it will be OK. I kept thinking of wiki-ui-all when
instead I should have thought about wiki-ui.
That is what happens when you have to read between the lines :) Please try
to provide more details about *why* you are doing the proposed actions
instead of only listing *what* you plan to do.
+1 to the initial proposal. No duplication of poms.
Thanks and sorry for the noise,
Eduard
On Thu, Aug 1, 2013 at 4:13 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
example: we
would
be
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Eddy,
About 3:
In my first implementation, I wanted to make xwiki-enterprise-ui
depends on
xwiki-enterprise-wiki-ui because for me, the main
wiki is like a subwiki
PLUS some specific pages. There is no page of the subwiki that I don't
want
to have on the main wiki.
But it is only because it is what we have now.
Now I understand that if we really want to have distinct XARs, this
dependency is a problem.
My purpose was also to avoid maintaning 2 pom files. If I create a new
module that I want to have in both XARS, I just have to add it to the
wiki-ui pom.xml.
But I guess it is a mistake.
--------
New proposal :
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines
what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
BTW it make sense only if we want to keep the distinction between
subwikis
and workspaces.
3/ Maintain the 3 poms: *xwiki-enterprise-workspace-ui,
**xwiki-enterprise-workspace-ui
*AND* **xwiki-enterprise-ui* when you want to add a module for all the
wikis.
Thanks Edy for your remarks, that I think I now understand.
WDYT ?
Thanks,
Guillaume D aka Louis-Marie
2013/7/31 Eduard Moraru <enygma2002(a)gmail.com>
> Yep, got that too. Anyway, I`ll wait for the pull request/merge
instead
of
> creating noise on the list :)
>
> Thanks,
> Eduard
>
>
> On Wed, Jul 31, 2013 at 7:43 PM, Thomas Mortagne
> <thomas.mortagne(a)xwiki.com>wrote;wrote:
>
> > On Wed, Jul 31, 2013 at 5:32 PM, Eduard Moraru <
enygma2002(a)gmail.com>
> > wrote:
> > > On Wed, Jul 31, 2013 at 12:03 PM, Guillaume "Louis-Marie"
Delhumeau <
> > > gdelhumeau(a)xwiki.com> wrote:
> > >
> > >> Hi Edy
> > >>
> > >> 2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
> > >>
> > >> > Hi,
> > >> >
> > >> > I suggest using the "-template-" name component, as in
> > >> > "xwiki-enterprise-workspace-template-ui" to avoid
confusion
with
the
> > >> > xwiki-platform artefact(s).
> > >> >
> > >>
> > >> Since it will be a dependency of xwiki-enterprise-ui, does it
make
>
sense to
> >> call it template?
> >>
> >>
> >> >
> >> > On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie"
Delhumeau <
> >> > gdelhumeau(a)xwiki.com>
wrote:
> >> >
> >> > > For the Workspace integration in XE, I need to modify the
default
> > XARs.
> > >> > It
> > >> > > makes me able to provide template XARs for the creation of
> subwikis,
> > >> > which
> > >> > > will be different from the XAR of the main wiki (for > > don't
> > >> > need
> > >> > > the WorkspaceManager UI in every subwikis).
> > >> > >
> > >> > > What I propose to do:
> > >> > >
> > >> > > 1/ Create a subproject *xwiki-enterprise-workspace-ui*,
which
> > defines
> > >> > what
> > >> > > a workspace should be.
> > >> > > 1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in
*
> > >> > > xwiki-enterprise-distribution*
> > >> > >
> > >> > > 2/ Create a subproject *xwiki-enterprise-wiki-ui*, which
defines
> > what a
> > >> > > subwiki should be.
> > >> > > 2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
> > >> > > xwiki-enterprise-distribution*
> > >> > >
> > >> > > 3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
> > >> > *xwiki-enterprise-ui*.
> > >> > >
> > >> >
> > >> > What do you want to achieve by doing this?
> > >> >
> > >>
> > >> Currently we generate workspace-template.xar in xwiki-manager-ui
by
> > copying
> > >> the xwiki-enterprise-ui-all XAR. But I am integrating Workspaces
in
XE
> > so
> > >> if we keep this construction, every workspace that use this
template
>
will
> >> have the WorkspaceManager too!
> >>
> >
> >> So, I need to clearly separate what is the XE UI and what is a
template
> UI.
> >>
> >
> > I got that :) I was actually asking about point 3. Making the XAR
xe-ui
> > depend on wiki-ui means what? To me it
does not mean much, because
you
> > are
> > > not going to install the wiki-ui XAR, using EM, as a transitive
> > dependency
> > > of xe-ui (where such a dependency declaration might be useful in a
> way).
> > > And even if you do that, all the contents of the wiki-ui XAR > > > imported into the main wiki and
that is not what you want by the
> current
> > > logic of Wiki/WorkspaceManager.
> > >
> > > So, unless I got it wrong, you might want to skip point 3.
> >
> > In Guillaume's proposal xwiki-enterprise-ui is going to be the XE
main
> > wiki XAR which mean what you have in a
generic subwiki (pretty much
> > the old XE xar) plus what used to be in XEM. So among other things
> > xwiki-enterprise-wiki-ui is going to be the default subwiki base UI
> > extension from DW point of view (like it's XE right now in XEM).
> >
> > >
> > >
> > >>
> > >>
> > >> >
> > >> > Thanks,
> > >> > Eduard
> > >> >
> > >> > >
> > >> > > This will be a temporary solution, because we will have
flavours
in
> the
> >> > > future.
> >> > >
> >> > > WDYT?
> >> > >
> >> > > Louis-Marie
> >> > > _______________________________________________
> >> > > devs mailing list
> >> > > devs(a)xwiki.org
> >> > > http://lists.xwiki.org/mailman/listinfo/devs
> >> > >
> >> > _______________________________________________
> >> > devs mailing list
> >> > devs(a)xwiki.org
> >> > http://lists.xwiki.org/mailman/listinfo/devs
> >> >
> >>
> >> Thanks,
> >> Louis-Marie
> >> _______________________________________________
> >> devs mailing list
> >> devs(a)xwiki.org
> >> http://lists.xwiki.org/mailman/listinfo/devs
> >>
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
>
>
>
> --
> Thomas Mortagne
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5:19 p.m.
On Tue, Sep 3, 2013 at 5:19 PM, Guillaume "Louis-Marie" Delhumeau
<gdelhumeau(a)xwiki.com> wrote:
Hi devs!
I have talked with Vincent about this. We have discovered some issues with
the organisation I have proposed.
The main issue is that xwiki-entreprise-ui needs to attach
xwiki-entreprise-workspace-ui-all's xar into WorkspaceManager.Install (to
provide a default template), and xwiki-entreprise-workspace-ui-all is a
module of xwiki-entreprise-distribution. So there is a problem of
dependencies across the modules hierarchy and the build can't work.
Moreover, it was not clear that xwiki-entreprise-ui was designed to be the
main wiki UI and xwiki-entreprise-workspace-ui the template UI for
subwiki.
That's why we want to propose a new structure:
xwiki-entreprise-ui (pom):
* xwiki-entreprise-ui-common (xar)
* xwiki-entreprise-ui-mainwiki (xar)
* xwiki-entreprise-ui-subwiki (xar)
* xwiki-entreprise-ui-mainwiki-all (all-in-one xar)
* xwiki-entreprise-ui-subwiki-all (all-in-one xar)
xwiki-enterprise-distribution (pom):
* the same as current but without xwiki-entreprise-ui-all
In this way we don't have the dependencies across modules problem, and it
is very clear what is the main wiki XAR and what is the subwiki XAR.
In the xwiki-entreprise-ui-mainwiki's pom, we will put:
<xwiki.extension.features>
org.xwiki.enterprise:xwiki-enterprise-ui
</xwiki.extension.features>
in order to help the extensions manager retrieving the good XARs during an
upgrade.
But what about the Distribution Wizard? Do we have
something special to add
in order to make xwiki-entreprise-ui-mainwiki the default XAR?
See
https://github.com/xwiki/xwiki-enterprise/blob/master/xwiki-enterprise-web/…
Hope this helps,
Marius
I hope my email is clear and thanks you in advance for your suggestions,
Guillaume
2013/8/29 Guillaume "Louis-Marie" Delhumeau <gdelhumeau(a)xwiki.com>
Hi devs.
I made some modifications, it is not exactly the same as I proposed first,
but I have all explained in the following JIRA:
http://jira.xwiki.org/browse/XWIKI-9409
I have made a pull request for this work:
https://github.com/xwiki/xwiki-enterprise/pull/39
I hope you like it.
I won't work tomorrow, so enjoy a good week-end!
Louis-Marie
2013/8/1 Eduard Moraru <enygma2002(a)gmail.com>
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs Actually I think I am the one that got confused
because of the fact that
we
have both the current Workspace/WikiManager.Install way of doing things
(using the wiki-ui-all xar) and, as a next step, the EM way of doing
things
(using the wiki-ui xar). If enterprise-ui depends on wiki-ui and you
install it with EM it will be OK. I kept thinking of wiki-ui-all when
instead I should have thought about wiki-ui.
That is what happens when you have to read between the lines :) Please try
to provide more details about *why* you are doing the proposed actions
instead of only listing *what* you plan to do.
+1 to the initial proposal. No duplication of poms.
Thanks and sorry for the noise,
Eduard
On Thu, Aug 1, 2013 at 4:13 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
Eddy,
About 3:
In my first implementation, I wanted to make xwiki-enterprise-ui
depends on
xwiki-enterprise-wiki-ui because for me, the main
wiki is like a subwiki
PLUS some specific pages. There is no page of the subwiki that I don't
want
to have on the main wiki.
But it is only because it is what we have now.
Now I understand that if we really want to have distinct XARs, this
dependency is a problem.
My purpose was also to avoid maintaning 2 pom files. If I create a new
module that I want to have in both XARS, I just have to add it to the
wiki-ui pom.xml.
But I guess it is a mistake.
--------
New proposal :
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines
what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
BTW it make sense only if we want to keep the distinction between
subwikis
and workspaces.
3/ Maintain the 3 poms: *xwiki-enterprise-workspace-ui,
**xwiki-enterprise-workspace-ui
*AND* **xwiki-enterprise-ui* when you want to add a module for all the
wikis.
Thanks Edy for your remarks, that I think I now understand.
WDYT ?
Thanks,
Guillaume D aka Louis-Marie
2013/7/31 Eduard Moraru <enygma2002(a)gmail.com>
> Yep, got that too. Anyway, I`ll wait for the pull request/merge
instead
of
> creating noise on the list :)
>
> Thanks,
> Eduard
>
>
> On Wed, Jul 31, 2013 at 7:43 PM, Thomas Mortagne
> <thomas.mortagne(a)xwiki.com>wrote;wrote:
>
> > On Wed, Jul 31, 2013 at 5:32 PM, Eduard Moraru <
enygma2002(a)gmail.com>
> > wrote:
> > > On Wed, Jul 31, 2013 at 12:03 PM, Guillaume "Louis-Marie"
Delhumeau <
> > > gdelhumeau(a)xwiki.com> wrote:
> > >
> > >> Hi Edy
> > >>
> > >> 2013/7/30 Eduard Moraru <enygma2002(a)gmail.com>
> > >>
> > >> > Hi,
> > >> >
> > >> > I suggest using the "-template-" name component, as in
> > >> > "xwiki-enterprise-workspace-template-ui" to avoid
confusion
with
the
> > >> > xwiki-platform artefact(s).
> > >> >
> > >>
> > >> Since it will be a dependency of xwiki-enterprise-ui, does it
make
> > sense to
> > >> call it template?
> > >>
> > >>
> > >> >
> > >> > On Tue, Jul 30, 2013 at 4:01 PM, Guillaume
"Louis-Marie"
Delhumeau <
> > >> > gdelhumeau(a)xwiki.com> wrote:
> > >> >
> > >> > > For the Workspace integration in XE, I need to modify the
default
> > XARs.
> > >> > It
> > >> > > makes me able to provide template XARs for the creation of
> subwikis,
> > >> > which
> > >> > > will be different from the XAR of the main wiki (for
example: we
> > don't
> > >> > need
> > >> > > the WorkspaceManager UI in every subwikis).
> > >> > >
> > >> > > What I propose to do:
> > >> > >
> > >> > > 1/ Create a subproject *xwiki-enterprise-workspace-ui*,
which
> > defines
> > >> > what
> > >> > > a workspace should be.
> > >> > > 1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in
*
> > >> > > xwiki-enterprise-distribution*
> > >> > >
> > >> > > 2/ Create a subproject *xwiki-enterprise-wiki-ui*, which
defines
> > what a
> > >> > > subwiki should be.
> > >> > > 2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
> > >> > > xwiki-enterprise-distribution*
> > >> > >
> > >> > > 3/ Add *xwiki-enterprise-wiki-ui* as a dependency of
> > >> > *xwiki-enterprise-ui*.
> > >> > >
> > >> >
> > >> > What do you want to achieve by doing this?
> > >> >
> > >>
> > >> Currently we generate workspace-template.xar in xwiki-manager-ui
by
> > copying
> > >> the xwiki-enterprise-ui-all XAR. But I am integrating Workspaces
in
XE
> > so
> > >> if we keep this construction, every workspace that use this
template
> > will
> > >> have the WorkspaceManager too!
> > >>
> > >
> > >> So, I need to clearly separate what is the XE UI and what is a
> template
> > UI.
> > >>
> > >
> > > I got that :) I was actually asking about point 3. Making the XAR
xe-ui
> > > depend on wiki-ui means what? To me it does not mean much, because
you
> > are
> > > not going to install the wiki-ui XAR, using EM, as a transitive
> > dependency
> > > of xe-ui (where such a dependency declaration might be useful in a
> way).
> > > And even if you do that, all the contents of the wiki-ui XAR
would
be
> > > imported into the main wiki and
that is not what you want by the
> current
> > > logic of Wiki/WorkspaceManager.
> > >
> > > So, unless I got it wrong, you might want to skip point 3.
> >
> > In Guillaume's proposal xwiki-enterprise-ui is going to be the XE
main
> > wiki XAR which mean what you have in a
generic subwiki (pretty much
> > the old XE xar) plus what used to be in XEM. So among other things
> > xwiki-enterprise-wiki-ui is going to be the default subwiki base UI
> > extension from DW point of view (like it's XE right now in XEM).
> >
> > >
> > >
> > >>
> > >>
> > >> >
> > >> > Thanks,
> > >> > Eduard
> > >> >
> > >> > >
> > >> > > This will be a temporary solution, because we will have
flavours
> in
> > the
> > >> > > future.
> > >> > >
> > >> > > WDYT?
> > >> > >
> > >> > > Louis-Marie
> > >> > > _______________________________________________
> > >> > > devs mailing list
> > >> > > devs(a)xwiki.org
> > >> > > http://lists.xwiki.org/mailman/listinfo/devs
> > >> > >
> > >> > _______________________________________________
> > >> > devs mailing list
> > >> > devs(a)xwiki.org
> > >> > http://lists.xwiki.org/mailman/listinfo/devs
> > >> >
> > >>
> > >> Thanks,
> > >> Louis-Marie
> > >> _______________________________________________
> > >> devs mailing list
> > >> devs(a)xwiki.org
> > >> http://lists.xwiki.org/mailman/listinfo/devs
> > >>
> > > _______________________________________________
> > > devs mailing list
> > > devs(a)xwiki.org
> > > http://lists.xwiki.org/mailman/listinfo/devs
> >
> >
> >
> > --
> > Thomas Mortagne
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
> >
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
4 Sep
4 Sep
5:02 p.m.
Hi.
Thomas has explained to me how maven really works and it should not be a
problem to let xwiki-*-ui-all (all-in-one xars) in
xwiki-enterprise-distribution.
So this is the new structure:
xwiki-entreprise-ui (pom):
* xwiki-entreprise-ui-common (xar)
* xwiki-entreprise-ui-mainwiki (xar) (depends on xwiki-entreprise-ui-common
+ xwiki-platform-workspace-ui)
* xwiki-entreprise-ui-subwiki (xar) (depends on xwiki-entreprise-ui-common
+ xwiki-platform-workspace-template-features)
xwiki-enterprise-distribution (pom):
* xwiki-entreprise-ui-mainwiki-all (all-in-one xar) (depends on
xwiki-entreprise-ui-mainwiki)
* xwiki-entreprise-ui-subwiki-all (all-in-one xar) (depends on
xwiki-entreprise-ui-subwiki).
Thomas has also given me some advices about <xwiki.extension.features>.
We assume that we drop the support of XEM since XE will integrate
Workspaces by default.
So :
xwiki-entreprise-ui-common will implement what used to be the
xwiki-enterprise-ui feature.
xwiki-entreprise-ui-mainwiki will implement what used to be the
xwiki-manager-ui feature.
Also, I need to install xwiki-entreprise-ui-common for regular subwikis and
xwiki-entreprise-ui-subwiki for workspaces. This is because we don't want
to install the workspace features on a regular subwikis in 5.2
That means, if we upgrade:
A/ a standalone XE wiki: the distribution manager will see that the new XAR
(xwiki-entreprise-ui-mainwiki) depends on xwiki-entreprise-ui-common, so it
will upgrade (and replace) xwiki-entreprise-ui.
B/ the main wiki of a farm: the distribution manager will see that the new
XAR (xwiki-entreprise-ui-mainwiki) depends on xwiki-entreprise-ui-common,
so it will upgrade (and replace) xwiki-entreprise-ui, but
xwiki-entreprise-ui-mainwiki also implements xwiki-manager-ui, so it will
be upgraded (and replaced) too.
C/ a standard subwiki of a XEM (not a workspace): the distribution manager
will see that the new XAR (xwiki-entreprise-ui-common) so it will upgrade
(and replace) xwiki-entreprise-ui.
But the subwiki will not be listed in the "Subwikis Directory", since
"Subwikis Directory" only lists what we used to call "workspaces"
(XWikiServer pages that have a WorkspaceClass object.). I think it's ok for
5.2.
D/ a workspace: the distribution manager will see that the new XAR
(xwiki-entreprise-ui-subwiki) depends on xwiki-entreprise-ui-common, so it
will upgrade (and replace) xwiki-entreprise-ui AND
xwiki-platform-workspace-template-feature.
But dynamically selecting a specific XAR for the upgrade is not possible
now.
So Thomas and Marius (thanks to them) suggest me a temporary solution.
- create a new JAR, with a new component that extends
org.xwiki.extension.distribution.internal.DistributionScriptService and
override getUIExtensionId().
- then, in the DW, when the upgrade is triggered, it call this method to
know which XAR should be installed.
- in the getUIExtensionId(), it looks if the current wiki is a workspace or
not, and consequently returns the good XAR.
Of course, this hack will be removed when we will have flavors.
In 5.3, the upgrade will be much harder. Because we need to really merge
the concept of "Workspaces" and "SubWikis", which is still 2 use-cases
in
5.2. (the "subwiki" new term is only used on the translations).
Thanks,
Guillaume
31 Jul
31 Jul
11:12 a.m.
On Tue, Jul 30, 2013 at 7:25 PM, Eduard Moraru <enygma2002(a)gmail.com> wrote:
Hi,
I suggest using the "-template-" name component, as in
"xwiki-enterprise-workspace-template-ui" to avoid confusion with the
xwiki-platform artefact(s).
-1 for putting "-template-" in the modules ids. Creating XAR template
is NOT the goal, the goal is to create extensions that are going to be
used and upgraded as generic wiki, workspace, main wiki etc... The
fact that some of them will be used as initial XAR to create
workspaces and wikimanager default wiki templates is a technical
details.
On Tue, Jul 30, 2013 at 4:01 PM, Guillaume "Louis-Marie" Delhumeau <
gdelhumeau(a)xwiki.com> wrote:
--
Thomas Mortagne
For the Workspace integration in XE, I need to
modify the default XARs. It
makes me able to provide template XARs for the creation of subwikis, which
will be different from the XAR of the main wiki (for example: we don't need
the WorkspaceManager UI in every subwikis).
What I propose to do:
1/ Create a subproject *xwiki-enterprise-workspace-ui*, which defines what
a workspace should be.
1bis/ Create a *xwiki-enterprise-workspace-ui-all* too, in *
xwiki-enterprise-distribution*
2/ Create a subproject *xwiki-enterprise-wiki-ui*, which defines what a
subwiki should be.
2bis/ Create a *xwiki-enterprise-wiki-ui-all* too, in *
xwiki-enterprise-distribution*
3/ Add *xwiki-enterprise-wiki-ui* as a dependency of *xwiki-enterprise-ui*.
What do you want to achieve by doing this?
Thanks,
Eduard
This will be a temporary solution, because we will have flavours in the
future.
WDYT?
Louis-Marie
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
4030
days inactive
4066
days old
12 comments
4 participants
participants (4)
-
Eduard Moraru -
Guillaume "Louis-Marie" Delhumeau -
Marius Dumitru Florea -
Thomas Mortagne