Re: [xwiki-devs] [xwiki-notifications] r31088 - platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources
14 Sep
2010
14 Sep
'10
9:12 a.m.
Although this makes sense from a code and organisation POV, I don't think it makes
sense from a user POV.
Personally I'd prefer to keep the old style since it's less confusing for users
and more logical. I know there's a risk of namespace clash but it's very small and
can be solved by changing property names if need be.
What do others think?
I'm not too hung up on this but I want to make it as easy as possible for users and
prevent the "WTF?" feeling (aka as the "don't make me think"
feeling) :)
Thanks
-Vincent
On Sep 14, 2010, at 9:00 AM, mflorea (SVN) wrote:
Author: mflorea
Date: 2010-09-14 09:00:57 +0200 (Tue, 14 Sep 2010)
New Revision: 31088
Modified:
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
Log:
XTCONFRES-50: Add configuration for including image dimensions in the image URL and for
limiting image dimensions
* Changed "rendering." prefix to "rendering.xwiki." for
XWiki-specific rendering configuration properties
Modified:
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
===================================================================
---
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm 2010-09-14
06:58:39 UTC (rev 31087)
+++
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm 2010-09-14
07:00:57 UTC (rev 31088)
@@ -68,7 +68,7 @@
#-# downloaded, improving thus the page loading speed.
#-#
#-# Default value is true.
-# rendering.includeImageDimensionsInImageURL = true
+# rendering.xwiki.imageDimensionsIncludedInImageURL = true
#-# [Since 2.5M2]
#-# One way to improve page load speed is to resize images on the server side just before
rendering the page. The
@@ -79,13 +79,13 @@
#-# The default value is -1 which means image width is not limited by default. Use a
value greater than 0 to limit the
#-# image width (pixels). Note that the aspect ratio is kept even when both the width and
the height of the image are
#-# limited.
-# rendering.imageWidthLimit = 1024
-# rendering.imageWidthLimit = -1
+# rendering.xwiki.imageWidthLimit = 1024
+# rendering.xwiki.imageWidthLimit = -1
#-# [Since 2.5M2]
#-# See rendering.imageWidthLimit
-# rendering.imageHeightLimit = 768
-# rendering.imageHeightLimit = -1
+# rendering.xwiki.imageHeightLimit = 768
+# rendering.xwiki.imageHeightLimit = -1
#-------------------------------------------------------------------------------------
# Cache
14 Sep
14 Sep
9:27 a.m.
New subject: [xwiki-devs] [xwiki-notifications] r31088 - platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources
On 09/14/2010 10:12 AM, Vincent Massol wrote:
Although this makes sense from a code and organisation
POV, I don't think it makes sense from a user POV.
Personally I'd prefer to keep the old style since it's less confusing for users
and more logical. I know there's a risk of namespace clash but it's very small and
can be solved by changing property names if need be.
What do others think?
I'm +1 for using the same prefix, i.e. "rendering." but I know Thomas
opted for using a different prefix when we discussed about it.
Thanks,
Marius
I'm not too hung up on this but I want to make it as easy as possible for users and
prevent the "WTF?" feeling (aka as the "don't make me think"
feeling) :)
Thanks
-Vincent
On Sep 14, 2010, at 9:00 AM, mflorea (SVN) wrote:
Author: mflorea
Date: 2010-09-14 09:00:57 +0200 (Tue, 14 Sep 2010)
New Revision: 31088
Modified:
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
Log:
XTCONFRES-50: Add configuration for including image dimensions in the image URL and for
limiting image dimensions
* Changed "rendering." prefix to "rendering.xwiki." for
XWiki-specific rendering configuration properties
Modified:
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
===================================================================
---
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm 2010-09-14
06:58:39 UTC (rev 31087)
+++
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm 2010-09-14
07:00:57 UTC (rev 31088)
@@ -68,7 +68,7 @@
#-# downloaded, improving thus the page loading speed.
#-#
#-# Default value is true.
-# rendering.includeImageDimensionsInImageURL = true
+# rendering.xwiki.imageDimensionsIncludedInImageURL = true
#-# [Since 2.5M2]
#-# One way to improve page load speed is to resize images on the server side just before
rendering the page. The
@@ -79,13 +79,13 @@
#-# The default value is -1 which means image width is not limited by default. Use a
value greater than 0 to limit the
#-# image width (pixels). Note that the aspect ratio is kept even when both the width and
the height of the image are
#-# limited.
-# rendering.imageWidthLimit = 1024
-# rendering.imageWidthLimit = -1
+# rendering.xwiki.imageWidthLimit = 1024
+# rendering.xwiki.imageWidthLimit = -1
#-# [Since 2.5M2]
#-# See rendering.imageWidthLimit
-# rendering.imageHeightLimit = 768
-# rendering.imageHeightLimit = -1
+# rendering.xwiki.imageHeightLimit = 768
+# rendering.xwiki.imageHeightLimit = -1
#-------------------------------------------------------------------------------------
# Cache
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs 
10:11 a.m.
New subject: [xwiki-devs] [xwiki-notifications] r31088 - platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources
I agree that it seems nicer for the user, +0
On Tue, Sep 14, 2010 at 09:27, Marius Dumitru Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
On 09/14/2010 10:12 AM, Vincent Massol wrote:
--
Thomas Mortagne
Although this makes sense from a code and
organisation POV, I don't think it makes sense from a user POV.
Personally I'd prefer to keep the old style since it's less confusing for users
and more logical. I know there's a risk of namespace clash but it's very small and
can be solved by changing property names if need be.
What do others think?
I'm +1 for using the same prefix, i.e. "rendering." but I know Thomas
opted for using a different prefix when we discussed about it.
Thanks,
Marius
I'm not too hung up on this but I want to make it as easy as possible for users and
prevent the "WTF?" feeling (aka as the "don't make me think"
feeling) :)
Thanks
-Vincent
On Sep 14, 2010, at 9:00 AM, mflorea (SVN) wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Author: mflorea
Date: 2010-09-14 09:00:57 +0200 (Tue, 14 Sep 2010)
New Revision: 31088
Modified:
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
Log:
XTCONFRES-50: Add configuration for including image dimensions in the image URL and for
limiting image dimensions
* Changed "rendering." prefix to "rendering.xwiki." for
XWiki-specific rendering configuration properties
Modified:
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
===================================================================
---
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
2010-09-14 06:58:39 UTC (rev 31087)
+++
platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
2010-09-14 07:00:57 UTC (rev 31088)
@@ -68,7 +68,7 @@
#-# downloaded, improving thus the page loading speed.
#-#
#-# Default value is true.
-# rendering.includeImageDimensionsInImageURL = true
+# rendering.xwiki.imageDimensionsIncludedInImageURL = true
#-# [Since 2.5M2]
#-# One way to improve page load speed is to resize images on the server side just before
rendering the page. The
@@ -79,13 +79,13 @@
#-# The default value is -1 which means image width is not limited by default. Use a
value greater than 0 to limit the
#-# image width (pixels). Note that the aspect ratio is kept even when both the width and
the height of the image are
#-# limited.
-# rendering.imageWidthLimit = 1024
-# rendering.imageWidthLimit = -1
+# rendering.xwiki.imageWidthLimit = 1024
+# rendering.xwiki.imageWidthLimit = -1
#-# [Since 2.5M2]
#-# See rendering.imageWidthLimit
-# rendering.imageHeightLimit = 768
-# rendering.imageHeightLimit = -1
+# rendering.xwiki.imageHeightLimit = 768
+# rendering.xwiki.imageHeightLimit = -1
#-------------------------------------------------------------------------------------
# Cache
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5116
days inactive
5116
days old
2 comments
3 participants
participants (3)
-
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol