Re: [xwiki-devs] [xwiki-notifications] r28794 - platform/xwiki-applications/trunk/administration/src/main/resources/XWiki
8 May
2010
8 May
'10
1:31 a.m.
On 05/07/2010 10:42 PM, cjdelisle (SVN) wrote:
Author: cjdelisle
Date: 2010-05-07 22:42:06 +0200 (Fri, 07 May 2010)
New Revision: 28794
Modified:
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
Log:
XAADMINISTRATION-138: ConfigurableClass producing invalid xhtml
Fixed regression introduced in r28787 preventing saving.
Modified:
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
===================================================================
---
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml 2010-05-07
20:21:45 UTC (rev 28793)
+++
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml 2010-05-07
20:42:06 UTC (rev 28794)
@@ -567,8 +567,8 @@
#end
</label>
## Have to prepend the app name to prevent id collisions.
Are you sure it's always going to be _0_ ?
- $obj.display($propName,
"edit").replaceAll("$objClass.getName()_0_$propName",
-
"${escapedAppName}_$objClass.getName()_0_$propName")
+ $obj.display($propName, "edit").replaceAll("
id='$objClass.getName()_0_$propName",
+ "
id='${escapedAppName}_$objClass.getName()_0_$propName")
</p>
#end## If property is in propertiesToShow
#end## Foreach property in this class
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
8 May
8 May
7:51 a.m.
New subject: [xwiki-devs] [xwiki-notifications] r28794 - platform/xwiki-applications/trunk/administration/src/main/resources/XWiki
Sergiu Dumitriu wrote:
On 05/07/2010 10:42 PM, cjdelisle (SVN) wrote:
It is always the first object but I concede it is a fallacy to assume it must be _0_.
Do you know any way to get the number of an object without refactoring the foreach loop to
call getObject("class", nb) each time?
Author: cjdelisle
Date: 2010-05-07 22:42:06 +0200 (Fri, 07 May 2010)
New Revision: 28794
Modified:
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
Log:
XAADMINISTRATION-138: ConfigurableClass producing invalid xhtml
Fixed regression introduced in r28787 preventing saving.
Modified:
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
===================================================================
---
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml 2010-05-07
20:21:45 UTC (rev 28793)
+++
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml 2010-05-07
20:42:06 UTC (rev 28794)
@@ -567,8 +567,8 @@
#end
</label>
## Have to prepend the app name to prevent id collisions.
Are you sure it's always going to be _0_ ? -
$obj.display($propName,
"edit").replaceAll("$objClass.getName()_0_$propName",
-
"${escapedAppName}_$objClass.getName()_0_$propName")
+ $obj.display($propName, "edit").replaceAll("
id='$objClass.getName()_0_$propName",
+ "
id='${escapedAppName}_$objClass.getName()_0_$propName")
</p>
#end## If property is in propertiesToShow
#end## Foreach property in this class
12:51 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r28794 - platform/xwiki-applications/trunk/administration/src/main/resources/XWiki
On Sat, May 8, 2010 at 07:51, Caleb James DeLisle
<calebdelisle(a)lavabit.com> wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
Sergiu Dumitriu wrote:
Actually the proper way is to ask the object itself: getObejct("class").number
On 05/07/2010 10:42 PM, cjdelisle (SVN) wrote:
It is always the first object but I concede it is a fallacy to assume it must be _0_.
Do you know any way to get the number of an object without refactoring the foreach loop
to call getObject("class", nb) each time? Author: cjdelisle
Date: 2010-05-07 22:42:06 +0200 (Fri, 07 May 2010)
New Revision: 28794
Modified:
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
Log:
XAADMINISTRATION-138: ConfigurableClass producing invalid xhtml
Fixed regression introduced in r28787 preventing saving.
Modified:
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
===================================================================
---
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
2010-05-07 20:21:45 UTC (rev 28793)
+++
platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/ConfigurableClass.xml
2010-05-07 20:42:06 UTC (rev 28794)
@@ -567,8 +567,8 @@
#end
</label>
## Have to prepend the app name to prevent id collisions.
Are you sure it's always going to be _0_ ? -
$obj.display($propName,
"edit").replaceAll("$objClass.getName()_0_$propName",
-
"${escapedAppName}_$objClass.getName()_0_$propName")
+ $obj.display($propName, "edit").replaceAll("
id='$objClass.getName()_0_$propName",
+ "
id='${escapedAppName}_$objClass.getName()_0_$propName")
</p>
#end## If property is in propertiesToShow
#end## Foreach property in this class
5298
days inactive
5299
days old
2 comments
3 participants
participants (3)
-
Caleb James DeLisle -
Sergiu Dumitriu -
Thomas Mortagne