Hi Guillaume L, On Mon, Nov 17, 2008 at 7:55 PM, Guillaume Lerouge &lt;guillaume(a)xwiki.com&gt;wrote;wrote: Nope, this seems to be a different issue. This is the exception thrown at the back-end : <dump> org.xwiki.velocity.XWikiVelocityException: Failed to evaluate content with id [/templates/contentview.vm] at org.xwiki.velocity.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:187) at org.xwiki.velocity.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:143) at com.xpn.xwiki.render.XWikiVelocityRenderer.evaluate(XWikiVelocityRenderer.java:107) at com.xpn.xwiki.XWiki.parseTemplate(XWiki.java:1600) at com.xpn.xwiki.api.XWiki.parseTemplate(XWiki.java:654) at sun.reflect.GeneratedMethodAccessor107.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:295) at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:245) at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:203) at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:294) at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:318) at org.apache.velocity.runtime.directive.VelocimacroProxy.render(VelocimacroProxy.java:194) at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:170) at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:74) at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:88) at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:74) at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:318) at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:107) at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:318) at org.xwiki.velocity.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:178) at org.xwiki.velocity.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:143) at com.xpn.xwiki.render.XWikiVelocityRenderer.evaluate(XWikiVelocityRenderer.java:107) at com.xpn.xwiki.XWiki.parseTemplate(XWiki.java:1600) at com.xpn.xwiki.web.Utils.parseTemplate(Utils.java:124) at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:226) at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) at javax.servlet.http.HttpServlet.service(HttpServlet.java:596) at javax.servlet.http.HttpServlet.service(HttpServlet.java:689) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:428) at org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebApplicationHandler.java:830) at com.xpn.xwiki.plugin.webdav.DavFilter.doFilter(DavFilter.java:68) at org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebApplicationHandler.java:821) at com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:96) at org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebApplicationHandler.java:821) at com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:287) at org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebApplicationHandler.java:821) at com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) at org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebApplicationHandler.java:821) at org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(WebApplicationHandler.java:471) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:568) at org.mortbay.http.HttpContext.handle(HttpContext.java:1565) at org.mortbay.jetty.servlet.WebApplicationContext.handle(WebApplicationContext.java:633) at org.mortbay.http.HttpContext.handle(HttpContext.java:1517) at org.mortbay.http.HttpServer.service(HttpServer.java:954) at org.mortbay.http.HttpConnection.service(HttpConnection.java:816) at org.mortbay.http.HttpConnection.handleNext(HttpConnection.java:983) at org.mortbay.http.HttpConnection.handle(HttpConnection.java:833) at org.mortbay.http.SocketListener.handleConnection(SocketListener.java:244) at org.mortbay.util.ThreadedServer.handle(ThreadedServer.java:357) at org.mortbay.util.ThreadPool$PoolThread.run(ThreadPool.java:534) Caused by: org.apache.velocity.exception.MethodInvocationException: Invocation of method 'getRenderedContent' in class com.xpn.xwiki.api.Document threw exception com.xpn.xwiki.XWikiException: Error number 0 in 4: Failed to render content using new rendering system Wrapped Exception: Failed to parse input source @ /templates/contentview.vm[7,7] at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:286) at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:203) at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:294) at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:318) at org.xwiki.velocity.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:178) ... 55 more Caused by: com.xpn.xwiki.XWikiException: Error number 0 in 4: Failed to render content using new rendering system Wrapped Exception: Failed to parse input source at com.xpn.xwiki.doc.XWikiDocument.getRenderedContentUsingNewRenderingModule(XWikiDocument.java:531) at com.xpn.xwiki.doc.XWikiDocument.getRenderedContent(XWikiDocument.java:470) at com.xpn.xwiki.api.Document.getRenderedContent(Document.java:367) at sun.reflect.GeneratedMethodAccessor220.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:295) at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:245) ... 59 more </dump> Thanks for sending the original document :) I will track this down and let you know. - Asiri

Hi, On Nov 18, 2008, at 6:04 AM, Asiri Rathnayake wrote: [snip] First, a comment: * I'm currently working on error handling and this error will be reported inline with an ErrorBlock and thus with a visual error where it happened in the very near future. The format for an inline link is (scheme):(something) However for URIs, only some are considered valid: mailto, image, attach For URL (i.e of the form (scheme)://(something) there's no check currently and all are considered URLs and checked to be valid. The reason we don't check for validity is because there can be any number of valid URL schemes (for example skype:// is a valid scheme if you've registered skype URL in your browser). I don't see any solution for this except not allowing inline links but I'm not sure this is a good solution. I think the inline error handling is the best solution and the user will use {{{exemple://#if($context.user..}}} if we really wants to enter this text. WDYT? Thanks -Vincent

On Nov 18, 2008, at 10:54 AM, Sergiu Dumitriu wrote: I don't quite agree. I should be able to enter a skype URL for example and since you can register any type of URL in your browser we can't filter them. What we could do though is test for the URL validity and if not valid then don't consider the element as a link. That is not very easy to implement but possible. I'm not sure I prefer this over displaying an inline error. Thanks -Vincent

Hi, On Tue, Nov 18, 2008 at 5:12 PM, Sergiu Dumitriu &lt;sergiu(a)xwiki.com&gt; wrote: I too agree with this. If the user was entering the wiki syntax himself, the exception is acceptable. But here the exception is internal to us. Anyway, working around this problem from the office-importer code might be possible, but it would be ugly (searching for : followed by italics....). Thanks. - Asiri

On Nov 18, 2008, at 1:00 PM, Vincent Massol wrote: Ok I understand now. It's imported as text and saved in wiki syntax as normal text. When rendered later in XHTML it's parsed again and then this time considered an inline element and rendered accordingly. So the real solution is that the XHTML parser should either generate a verbatim block event or simply escape the ":" with "\:". I'll add a unit test for this to see how it goes. Thanks -Vincent

On Tue, Nov 18, 2008 at 1:21 PM, Vincent Massol &lt;vincent(a)massol.net&gt; wrote: Nope, I didn't touch the file, I simply selected it in my file browser and uploaded it as is. I didn't do anything special afterwards, I simply tried to access the page where it was imported. Guillaume -- Guillaume Lerouge Product Manager - XWiki Skype ID : wikibc http://blog.xwiki.com/

On Nov 18, 2008, at 6:19 PM, Asiri Rathnayake wrote: This is HTML AFAIK and not wiki syntax so the input is indeed HTML. I see the problem. So we need somehow to get the following instead: Par exemple~://#if($context.user == "XWiki.Admin")Vous l'administrateur par dŽfaut de ce wiki!#else Vous un utilisateur classique.#end// I think this could be addressed with some rule like the following in the XHTML parser: * if there's a ":" character and if the next element is an italic start tag then escape the ":" with "~:" I'm already doing several checks in XWikiXhtmlEscapeHandler to automatically escape characters so that they are not mistaken for wiki syntax. Could you please create a jira issue for this with the content of this discussion? BTW the issue should be more generic since we have the same problem with the following input for example: <html><p>mailto:vincent@massol.net</p></html> This should generate the following in wiki syntax; mailto~:vincent@massol.net So basically any inline link format should get the ":" escaped when parsed by the XHTML parser. Thanks -Vincent

Hi, I meant the output you get once you parse this html content via xhtml->xwiki parser. That output contains the "://" sequence. Ok, I will raise a jira issue for this. Falling asleep. Good night. - Asiri

Hi Guillaume L, How do you handle cases when the target document already exists? Right now I Yes, I didn't update this code yet. We need to provide a descent error message. Both of these issues will be handled when we introduce strict style filtering. Thank you very much for testing office-importer. :) - Asiri

Hi Vincent, Yes, i'm implementing syntax filtering (severe) from tomorrow onwards. It won't take much time. Thanks. - Asiri

Hi Devs, Users, I have uploaded yet another new version of office-importer @ http://91.121.237.216/xwiki/bin/view/Import/. This version utilizes the latest rendering module which has improved a lot since the last upload. Also a moderate style filtering option is introduced. Please try it out and let us know what you think. Thanks. - Asiri