+1
On Mon, Oct 3, 2011 at 16:54, Vincent Massol <vincent(a)massol.net> wrote:
+1
Thanks
-Vincent
PS: We'll need to mention somewhere in the XWiki Syntax Guide, in the
Release Notes, or both how we "officially" handle the empty reference since
we haven't done that in the past, and explain that if the user wants a link
to the current specific document they'll need to explicitly use the document
name as in [[label>>MyPage#anchor]], instead of [[label>>#anchor]] since
otherwise including this page may give a different result.
On Oct 3, 2011, at 3:57 PM, Thomas Mortagne wrote:
Hi devs,
When you want a local link you use something like [[label>>#anchor]]
and it will produce an XHTML like <a
href="/xwiki/bin/view/CurrentSpace/CurrentDocument#myanchor">label</a>.
IMO this is not very good since:
* it's doing lot's of useless work (resolving the reference, getting
the corresponding XWikiDocument to finally generate the URL thanks to
URLFactory
* it's breaking any included local reference since it will be resolved
based on the source document and not the current document which makes
sense when you target a specific document but not when you asked for a
local reference
Note that it used to be that way (and I tough it was still the case)
and I don't remember why this has been changed.
So I proposed to put back the specific handling of empty reference:
produce <a href="#myanchor">label</a> in the XHTML renderer for
the
previous example.
WDYT ?
Here is my +1
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs