[xwiki-devs] [VOTE] Remove xwiki-platform-legacy-crypto-script module - xwiki-devs@xwiki.org

Caleb James DeLisle

23 Apr 23 Apr

9:28 a.m.

New subject: [xwiki-devs] [VOTE] Remove xwiki-platform-legacy-crypto-script module

Unused afaik, +1 for "moving it to .git directory" ;) Caleb On 04/23/2015 09:22 AM, vincent(a)massol.net wrote:

Hi devs, With the upgrade of BouncyCastle to version 1.52 the xwiki-platform-legacy-crypto-script legacy module doesn’t build anymore since BC has removed deprecated code. We have of course the option to try to fix the legacy code to use newer APIs. However I think this is overkill and not needed because I don’t believe this legacy code was ever used (Caleb, the author of it, seems to agree with this). See the comments at http://jira.xwiki.org/browse/XCOMMONS-794 Thus, according to our rules, I’m sending this VOTE to decide to break this API voluntarily by removing this legacy module. Here’s my +1 Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Satire is the escape hatch from the cycle of sorrow, hatred and violence. #JeSuisCharlie

Reply

Thomas Mortagne

9:50 a.m.

+0 On Thu, Apr 23, 2015 at 9:33 AM, Denis Gervalle <dgl(a)softec.lu> wrote:

...

I have look quickly into the changes, and it is no so trivial to fix this legacy code. I agree, there is very little chance that anyone as ever used that legacy API. So, +1 to remove. On Thu, Apr 23, 2015 at 9:22 AM, vincent(a)massol.net <vincent(a)massol.net> wrote:

Hi devs, With the upgrade of BouncyCastle to version 1.52 the xwiki-platform-legacy-crypto-script legacy module doesn’t build anymore since BC has removed deprecated code. We have of course the option to try to fix the legacy code to use newer APIs. However I think this is overkill and not needed because I don’t believe this legacy code was ever used (Caleb, the author of it, seems to agree with this). See the comments at http://jira.xwiki.org/browse/XCOMMONS-794 Thus, according to our rules, I’m sending this VOTE to decide to break this API voluntarily by removing this legacy module. Here’s my +1 Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne

Reply

Eduard Moraru

11:54 a.m.

+0 Thanks, Eduard On Thu, Apr 23, 2015 at 11:21 AM, Marius Dumitru Florea < mariusdumitru.florea(a)xwiki.com> wrote:

...

+0 Thanks, Marius On Thu, Apr 23, 2015 at 10:22 AM, vincent(a)massol.net <vincent(a)massol.net> wrote:

Hi devs, With the upgrade of BouncyCastle to version 1.52 the

xwiki-platform-legacy-crypto-script legacy module doesn’t build anymore since BC has removed deprecated code.

We have of course the option to try to fix the legacy code to use newer

APIs.

However I think this is overkill and not needed because I don’t believe

this legacy code was ever used (Caleb, the author of it, seems to agree with this).

See the comments at http://jira.xwiki.org/browse/XCOMMONS-794 Thus, according to our rules, I’m sending this VOTE to decide to break

this API voluntarily by removing this legacy module.

Here’s my +1 Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Reply