On 09/22/2010 12:31 PM, Marius Dumitru Florea wrote:

I take it that the current implementation outputs HTML, right? I'd like to have a preview mode which generates small images instead, snapshots of each page/slide, placed one after another horizontally, in a div with a scrollbar. Could it be done?

+1 for java macro. One advantage is that it will be usable nested inside scripting macros as well (otherwise the velocity macro inside will prevent it).

On 09/22/2010 04:31 PM, Marius Dumitru Florea wrote: main but of

Office preview component relies entirely on the office importer I replied too fast.. for presentations, the in-line frame is generated by the office preview component. So yes, I can improve it, but we need to agree on the desired/expected output for presentations. Thanks, Marius etc.) http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-model/src/main… preview _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 09/22/2010 06:25 PM, Guillaume Lerouge wrote: This looks great, but I can't achieve it with the current tools. When converting a presentation (ppt/odp) to HTML jodconveter generates for each slide an image (screenshot) and an HTML fragment with only the text extracted from that slide. Currently office-importer module displays the imported presentation using an in-line frame. You see the current slide (either image or text) and you have links pointing to the first, previous, next and last slide. I don't like the current behavior and the usage of the html macro to generates the in-line frame generates complications on the implementation side. I'd like to change it to display all the images/text on the same wiki page without using an in-line frame: simply insert the images/text in the wiki syntax. I see two options: (1) Display either only the images or only the text (2) Display both the images and the text (e.g. slide text followed by slide image, or side by side on two columns) WDYT?

> > For long documents, what I did is to load the document in a hidden DIV and > have a small JS snippet to "pop open" that DIV and display the document in > the page where it might take a lot of space. It worked well. > > Guillaume > >> Office preview component relies entirely on the office importer >>> component. So when you preview an office document you get the same >>> result as if you would import it in a wiki page. >>> >>> The job of the office preview component is to: >>> * obtain an XDOM from the office importer >>> * change image references to point to temporary resources, rather than >>> attachments >>> * cache the result >>> * render the XDOM to XHTML rather than wiki syntax. >>> >>> In this context, your request is more suited for the office importer >>> component. Now, the office importer generates images for presentation >>> slides (both "text" and "graphics" modes are available), but they are >>> displayed using an in-line frame with links to next/previous slides. We >>> can improve this display, but the code will go in the office importer >>> module. >> >> I replied too fast.. for presentations, the in-line frame is generated >> by the office preview component. So yes, I can improve it, but we need >> to agree on the desired/expected output for presentations. >> >> Thanks, >> Marius >> >>> >>> Thanks, >>> Marius >>> >>>> >>>>> The office preview macro will be just a wrapper for the office preview >>>>> script service. This means no decorations (e.g. borders, headings, >> etc.) >>>>> will be added around the output of the script service: >>>>> >>>>> {{velocity}} >>>>> {{html}} >>>>> $services.officepreview.preview($attachmentReference, $filterStyles) >>>>> {{/html}} >>>>> {{/velocity}} >>>>> >>>>> I'm not sure if the office preview macro should be a wiki macro or a >>>>> Java macro. One disadvantage for wiki macros is >>>>> http://jira.xwiki.org/jira/browse/XWIKI-4262 . This means that the >>>>> attachment string reference must be resolve before calling the office >>>>> preview script service. Currently there's no clean way to resolve a >>>>> reference relative to a given document in velocity so I would have to >>>>> use groovy which raises programming rights issue. Alternative we can >>>>> extend the >>>>> >> http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-model/src/main… >>>>> . >>>>> >>>>> There's nothing to customize so the power of wiki macros wouldn't be >>>>> used. You can create a wiki macro that wraps the office preview macro >>>>> and add decorations specific to your needs. >>>>> >>>>> One the other hand, the advantages of a Java macro are not significant >>>>> either because the macro is just a simple wrapper for the office >> preview >>>>> script service. >>>>> >>>>> WDYT? >>>> >>>> +1 for java macro. One advantage is that it will be usable nested inside >>>> scripting macros as well (otherwise the velocity macro inside will >>>> prevent it).

On 09/24/2010 03:36 PM, Sergiu Dumitriu wrote: What's the real use case for this small thumbnails? Why would you display them inside the content of a wiki page? I'd rather display a thumbnail when hovering a link to an office attachment, but I wouldn't put the thumbnail inside the content (i.e. using a macro in wiki syntax) unless I'm creating a gallery, which is a very specific use case.

Hi all, On 09/22/2010 02:47 PM, Sergiu Dumitriu wrote: If I remember correctly this was fixed, wiki macros should be a special case and allow scripting macro inside scripting macro, otherwise wikimacros will be unusable on an "if" branch.

Otherwise, I think I would prefer wikimacro, for this case, since it's more like a "shortcut" (instead of writing {{velocity}}{{html}}...., one just writes {{officepreview ...) I don't like that much the idea of having this kind of shortcuts in the java macros, but I don't have a strong opinion. Thanks, Anca _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs