8 Apr
2009
8 Apr
'09
9:01 p.m.
Hi devs,
I need to add some tags into a document via officeimporter. For this I need
to have above method implemented in DocumentAccessBridge.
The most generic method signature would be:
void setProperty(String documentName, String className, int objectNumber,
String propertyName, Object value) throws Exception;
But for my use case following would be enogh:
void setProperty(String documentName, String className, String propertyName,
Object value) throws Exception;
I'm currently +1 for second signature.
WDYT?
Note: this method has been implemented in issue:
http://jira.xwiki.org/jira/browse/XWIKI-2831 but this patch seems to have
lot more other (unnecessary) methods.
Thanks.
- Asiri
8 Apr
8 Apr
9:41 p.m.
New subject: [xwiki-devs] [VOTE] Introduce DocumentAccessBridge::setProperty() method
Hi,
Asiri Rathnayake wrote:
Hi devs,
I need to add some tags into a document via officeimporter. For this I need
to have above method implemented in DocumentAccessBridge.
The most generic method signature would be:
void setProperty(String documentName, String className, int objectNumber,
String propertyName, Object value) throws Exception;
But for my use case following would be enogh:
void setProperty(String documentName, String className, String propertyName,
Object value) throws Exception;
I'm currently +1 for second signature.
WDYT?
Note: this method has been implemented in issue:
http://jira.xwiki.org/jira/browse/XWIKI-2831 but this patch seems to have
lot more other (unnecessary) methods.
This was already voted. Those methods were necessary to me. I'm
surprised to see that the patch didn't get applied until now. This came
into discussion several times from November, and it the disagreement was
if the methods should call Save() or not.
It was finally agreed that they should be stateless and call Save,
ignoring speed issues for now. It was also restated that the work on the
new model should be started as soon as possible, how are we on that?
Again, this is a big +1 from me on having this method.
Thanks,
Florin Ciubotaru
Thanks.
- Asiri
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
9 Apr
9 Apr
4:23 a.m.
New subject: [xwiki-devs] [VOTE] Introduce DocumentAccessBridge::setProperty() method
Hi Florin,
This was already voted. Those methods were necessary to me. I'm
surprised to see that the patch didn't get applied
until now.
The problem with the patch is that it has several save() methods (the latest
version of the patch). As the thomas's
comment<http://jira.xwiki.org/jira/browse/XWIKI-2831?focusedCommentId=34…
those methods need to be removed (we need the bridge to be stateless)
and individual bridge methods will call save() on the document being
modified.
This came
into discussion several times from November, and it the disagreement was
if the methods should call Save() or not.
It was finally agreed that they should be stateless and call Save,
ignoring speed issues for now.
Yes.
So, since this has been voted before, I'll just go ahead and implement the
method :)
Thanks.
- Asiri
5692
days inactive
5693
days old
2 comments
2 participants
participants (2)
-
Asiri Rathnayake -
Florin Ciubotaru