Hi Jerome,
First thank you for the detailed analysis. They are very helpful.
* The main content area scrolls when clicking the sidebar control icons.
This seem to happen only when the page is already a
bit scrolled. Is this
the expected behavior ?
This is expected and is a result of using the browser's native scrolling
mechanism (anchor link). This was done in order to rely less on js for
primary navigation/control. I thought it was minor enough, but if you think
it should be changed, i think this issue could be removed via js.
* Clicking the search box redirects to the home page
Oops, it's fixed now.
* Seems the history UI is not loading with AJAX as colibri does it. I think
it would be a questionnable approach, as it increases
the cost of loading
a
page, while the history will not be checked out by users most of the
times.
Good idea. I just updated it so it would load on ajax (also, relevant to
the below point, made it more international friendly)
* Internationalization is missing. (For example the
"Swipe horizontally to
access menu")
Yes, I've been thinking about this. I was wondering how I should go about
this. Internationalization would take a lot of (community) work it seems.
And I was wondering whether the "swipe horizontally" is needed at all. I
know that in most apps they do not mention this, but the argument would be
that app are long term usage scenarios. What are your thoughts?
* Do you have any use of modernizr ? If not we should
remove it.
Modernizr is used both to better degrade opacity, rotation and other
niceties, and to decide the web layout. As I mentioned in the
proposal/design some of the issues are the wildly varying pixel densities.
Eg. the Nexus7 (my personal test platform), has a 1024x800 but is only 7
inch, so it doesn't work as well with the sidebar layout as it would with
the mobile layout. So what it's doing right now is to check the screen size
and whether it is touch screen (most laptop has about equivalent density
(except for maybe the new macbook), but, even then, those are still not
very relevant because they are usually top of the line and exceed the pixel
size of tablets). Media queries presently do not yet have touch identifier,
so modernizr is used in conjunction. Is this ok, or should i try to find a
better solution?
* There is no edit mode switcher when editing the page. If you update your
repos you can checkout how I've done it for
Lyrebird
Ok, thanks
* The "profile" and "logout" links
overlap the sidebar controls on
Firefox.
See
http://i.imgur.com/LRgIc.png
Hmm, that's strange, it didn't do that on my end. Thanks for bringing it
up.
<http://i.imgur.com/LRgIc.png>* Top "Add" menu "add comment to
page" and
"add attachment to page" have no
effect
What do you mean by this? Sorry
* The "document index" tabs don't look too good when small screen estate.
Ok, thanks
That should be about it for now.
Regarding the next items that could be addressed, here is what I have in
mind :
* Search. The synchronous search UI seems fine, but now it would be great
to have a functional search suggest.
Ok, I will look into this.
* Ensure consistency of styles across the standard XE UI. I've seen some
forms remain un-styled, for example the "Add
space" and "Add page" ones.
This
is a work of playing hide and seek with your wiki :)
Yes, i've been trying to hunt them down as much as I can, and will continue
to do so.
* It would be good that you document your patch on the
livetable macros/JS
somewhere so that it's easier for us to understand what you've done and
possibly to integrate it
Ok, how would you suggest I do this/where? Briefly, I used this technique (
http://filamentgroup.com/lab/responsive_design_approach_for_complex_multico…
).
* Color themes ? Apps ?
For apps, I wanted to confirm: skinning is only possible via css, and not
its html (since it's html is not from the templates folder)?
There's an issue when viewing a page that do not exist : see
Ah, good catch, thanks
Thank you again for helping/mentoring with this project (sidenote: have fun
with, what I gathered, the XWiki annual seminar)
Best,
Jonathan Solichin