[xwiki-devs] [VOTE] Remove feature of extracting the title from the content

List overview All Threads
Download

newer

older

[xwiki-devs] Possible important...

[xwiki-devs] [VOTE] Stop...

vincent＠massol.net

30 Jan 2014 30 Jan '14

2:06 p.m.

Hi devs, I’d like to propose removing the feature of extracting the title from the content in 6.x. The rationale is: * This is costing more than it should. It needs parsing the document content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so. * Our implementation is broken since if you use an include macro that generates a heading for ex, it won’t be taken into account since we don’t apply transformations ATM when computing the title since it would be even more expensive. Since 6.x is about performance I believe this would be a good step forward. Now in order to handle backward compatibility. I propose that we: * Add a legacy configuration parameter to keep the behavior (but off by default). This would be in order to let users using this feature convert their wiki * Move the code to a legacy module (I hope it’s possible) Here’s my +1 Thanks -Vincent

Show replies by date

Thomas Mortagne

30 Jan 30 Jan

2:15 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net <vincent(a)massol.net> wrote:

...

Hi devs, I'd like to propose removing the feature of extracting the title from the content in 6.x. The rationale is: * This is costing more than it should. It needs parsing the document content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so. * Our implementation is broken since if you use an include macro that generates a heading for ex, it won't be taken into account since we don't apply transformations ATM when computing the title since it would be even more expensive. Since 6.x is about performance I believe this would be a good step forward. Now in order to handle backward compatibility. I propose that we: * Add a legacy configuration parameter to keep the behavior (but off by default). This would be in order to let users using this feature convert their wiki

We could reuse xwiki.title.compatibility for that too maybe.

...

* Move the code to a legacy module (I hope it's possible) Here's my +1 Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

vincent＠massol.net

2:22 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

Good point with xwiki.title.compatibility I had forgotten about it! FTR: #-# Defines whether title handling should be using the compatibility mode or not. When the compatibility #-# mode is active, if the document's content first header (level 1 or level 2) matches the document's title #-# the first header is stripped. xwiki.title.compatibility=1 Thanks -Vincent On 30 Jan 2014 at 14:16:13, Thomas Mortagne (thomas.mortagne@xwiki.com(mailto:thomas.mortagne@xwiki.com)) wrote:

...

On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net wrote:

We could reuse xwiki.title.compatibility for that too maybe.

Big plus 1, I always been against keeping this xwiki/1.0 hack. We also need to put xwiki.title.compatibility back to disabled by default (it was initially disabled and then enabled supposedly temporary for wrong reasons). -- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Guillaume "Louis-Marie" Delhumeau

2:24 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

+1 2014-01-30 vincent(a)massol.net <vincent(a)massol.net>et>:

...

Good point with xwiki.title.compatibility I had forgotten about it! FTR: #-# Defines whether title handling should be using the compatibility mode or not. When the compatibility #-# mode is active, if the document's content first header (level 1 or level 2) matches the document's title #-# the first header is stripped. xwiki.title.compatibility=1 Thanks -Vincent On 30 Jan 2014 at 14:16:13, Thomas Mortagne (thomas.mortagne(a)xwiki.com (mailto:thomas.mortagne@xwiki.com)) wrote:

On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net wrote: > Hi devs, > > I'd like to propose removing the feature of extracting the title from

the content in 6.x.

> > The rationale is: > > * This is costing more than it should. It needs parsing the document

content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so.

> > * Our implementation is broken since if you use an include macro that

generates a heading for ex, it won't be taken into account since we don't apply transformations ATM when computing the title since it would be even more expensive.

> > Since 6.x is about performance I believe this would be a good step

forward.

> > Now in order to handle backward compatibility. I propose that we: > * Add a legacy configuration parameter to keep the behavior (but off

by default). This would be in order to let users using this feature convert their wiki

We could reuse xwiki.title.compatibility for that too maybe.

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Denis Gervalle

2:48 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

+1 to move to legacy and to use xwiki.title.compatibility to disable the feature. On Thu, Jan 30, 2014 at 2:24 PM, Guillaume "Louis-Marie" Delhumeau < gdelhumeau(a)xwiki.com> wrote:

...

+1 2014-01-30 vincent(a)massol.net <vincent(a)massol.net>et>:

Good point with xwiki.title.compatibility I had forgotten about it! FTR: #-# Defines whether title handling should be using the compatibility mode or not. When the compatibility #-# mode is active, if the document's content first header (level 1 or level 2) matches the document's title #-# the first header is stripped. xwiki.title.compatibility=1 Thanks -Vincent On 30 Jan 2014 at 14:16:13, Thomas Mortagne (thomas.mortagne(a)xwiki.com (mailto:thomas.mortagne@xwiki.com)) wrote:

On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net wrote: > Hi devs, > > I'd like to propose removing the feature of extracting the title from

the content in 6.x.

> > The rationale is: > > * This is costing more than it should. It needs parsing the document

content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so.

> > * Our implementation is broken since if you use an include macro that

generates a heading for ex, it won't be taken into account since we don't apply transformations ATM when computing the title since it would be even more expensive.

> > Since 6.x is about performance I believe this would be a good step

forward.

> > Now in order to handle backward compatibility. I propose that we: > * Add a legacy configuration parameter to keep the behavior (but off

by default). This would be in order to let users using this feature

convert

their wiki

We could reuse xwiki.title.compatibility for that too maybe.

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO

Ecaterina Moraru (Valica)

3:13 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

...

From what I remember it was added when we created Colibri and was

implemented by Sergiu. Not sure it had anything to do with the WCAG standard or not.

...

From an usability perspective I kind off liked the feature so I'm not sure

about removing it (although I always put titles on my documents). +0 (if it would improve the performance and if others also think is not an useful feature) Thanks, Caty On Thu, Jan 30, 2014 at 3:48 PM, Denis Gervalle <dgl(a)softec.lu> wrote:

...

+1 to move to legacy and to use xwiki.title.compatibility to disable the feature. On Thu, Jan 30, 2014 at 2:24 PM, Guillaume "Louis-Marie" Delhumeau < gdelhumeau(a)xwiki.com> wrote:

+1 2014-01-30 vincent(a)massol.net <vincent(a)massol.net>et>: > Good point with xwiki.title.compatibility I had forgotten about it! > > FTR: > > #-# Defines whether title handling should be using the compatibility

mode

> or not. When the compatibility > #-# mode is active, if the document's content first header (level 1 or > level 2) matches the document's title > #-# the first header is stripped. > xwiki.title.compatibility=1 > > Thanks > -Vincent > > > On 30 Jan 2014 at 14:16:13, Thomas Mortagne (thomas.mortagne(a)xwiki.com > (mailto:thomas.mortagne@xwiki.com)) wrote: > > > On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net wrote: > > > Hi devs, > > > > > > I'd like to propose removing the feature of extracting the title

from

> the content in 6.x. > > > > > > The rationale is: > > > > > > * This is costing more than it should. It needs parsing the

document

> content to get its XDOM and then to traverse it to find Heading blocks. > When we display doc titles in lists (in livetables for example or in

the

> activity stream) it costs a lot to do so. > > > > > > * Our implementation is broken since if you use an include macro

that

> generates a heading for ex, it won't be taken into account since we

don't

> apply transformations ATM when computing the title since it would be

even

> more expensive. > > > > > > Since 6.x is about performance I believe this would be a good step > forward. > > > > > > Now in order to handle backward compatibility. I propose that we: > > > * Add a legacy configuration parameter to keep the behavior (but

off

by default). This would be in order to let users using this feature

convert > their wiki > > > > We could reuse xwiki.title.compatibility for that too maybe. > > > > > * Move the code to a legacy module (I hope it's possible) > > > > > > Here's my +1 > > > > > > Thanks > > > -Vincent > > > > > > > > > _______________________________________________ > > > devs mailing list > > > devs(a)xwiki.org > > > http://lists.xwiki.org/mailman/listinfo/devs > > > > Big plus 1, I always been against keeping this xwiki/1.0 hack. We

also

> > need to put xwiki.title.compatibility back to disabled by default (it > > was initially disabled and then enabled supposedly temporary for

wrong

reasons). -- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Caleb James DeLisle

2 Feb 2 Feb

5:54 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

+1 for me It always struck me as a sort of "hack" that you omit the title and it magically gets one by looking for something title-ish in your content. Thanks, Caleb On 01/30/2014 09:13 AM, Ecaterina Moraru (Valica) wrote:

...

From what I remember it was added when we created Colibri and was

implemented by Sergiu. Not sure it had anything to do with the WCAG standard or not.

From an usability perspective I kind off liked the feature so I'm not sure

+1 to move to legacy and to use xwiki.title.compatibility to disable the feature. On Thu, Jan 30, 2014 at 2:24 PM, Guillaume "Louis-Marie" Delhumeau < gdelhumeau(a)xwiki.com> wrote:

mode

> or not. When the compatibility > #-# mode is active, if the document's content first header (level 1 or > level 2) matches the document's title > #-# the first header is stripped. > xwiki.title.compatibility=1 > > Thanks > -Vincent > > > On 30 Jan 2014 at 14:16:13, Thomas Mortagne (thomas.mortagne(a)xwiki.com > (mailto:thomas.mortagne@xwiki.com)) wrote: > >> On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net wrote: >>> Hi devs, >>> >>> I'd like to propose removing the feature of extracting the title

from

> the content in 6.x. >>> >>> The rationale is: >>> >>> * This is costing more than it should. It needs parsing the

document

> content to get its XDOM and then to traverse it to find Heading blocks. > When we display doc titles in lists (in livetables for example or in

the

> activity stream) it costs a lot to do so. >>> >>> * Our implementation is broken since if you use an include macro

that

> generates a heading for ex, it won't be taken into account since we

don't

> apply transformations ATM when computing the title since it would be

even

> more expensive. >>> >>> Since 6.x is about performance I believe this would be a good step > forward. >>> >>> Now in order to handle backward compatibility. I propose that we: >>> * Add a legacy configuration parameter to keep the behavior (but

off

by default). This would be in order to let users using this feature

convert > their wiki >> >> We could reuse xwiki.title.compatibility for that too maybe. >> >>> * Move the code to a legacy module (I hope it's possible) >>> >>> Here's my +1 >>> >>> Thanks >>> -Vincent >>> >>> >>> _______________________________________________ >>> devs mailing list >>> devs(a)xwiki.org >>> http://lists.xwiki.org/mailman/listinfo/devs >> >> Big plus 1, I always been against keeping this xwiki/1.0 hack. We

also

>> need to put xwiki.title.compatibility back to disabled by default (it >> was initially disabled and then enabled supposedly temporary for

wrong

> reasons). > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Jeremie BOUSQUET

3 Feb 3 Feb

7:13 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

Hi, Le 30 janv. 2014 14:16, "Thomas Mortagne" <thomas.mortagne(a)xwiki.com> a écrit :

...

On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net <vincent(a)massol.net>

wrote:

...

> Hi devs, > > I'd like to propose removing the feature of extracting the title from

the content in 6.x.

...

> > The rationale is: > > * This is costing more than it should. It needs parsing the document

content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so.

...

> > * Our implementation is broken since if you use an include macro that

generates a heading for ex, it won't be taken into account since we don't apply transformations ATM when computing the title since it would be even more expensive.

...

> > Since 6.x is about performance I believe this would be a good step

forward.

...

> > Now in order to handle backward compatibility. I propose that we: > * Add a legacy configuration parameter to keep the behavior (but off by

default). This would be in order to let users using this feature convert their wiki

...

We could reuse xwiki.title.compatibility for that too maybe.

Maybe there could an extension / snippet to assign in batch mode found heading as page title, for pages without title ? So users that rely on this feature instead of setting a title, could have a way to "migrate" ?

...

-- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Marius Dumitru Florea

8:49 a.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

+1 Thanks, Marius On Jan 30, 2014 3:06 PM, "vincent(a)massol.net" <vincent(a)massol.net> wrote:

...

Hi devs, I'd like to propose removing the feature of extracting the title from the

content in 6.x.

...

The rationale is: * This is costing more than it should. It needs parsing the document

content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so.

...

* Our implementation is broken since if you use an include macro that

generates a heading for ex, it won't be taken into account since we don't apply transformations ATM when computing the title since it would be even more expensive.

...

Since 6.x is about performance I believe this would be a good step

forward.

...

Now in order to handle backward compatibility. I propose that we: * Add a legacy configuration parameter to keep the behavior (but off by

default). This would be in order to let users using this feature convert their wiki

...

vincent＠massol.net

9:28 a.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content (SUMMARY)

Here’s the vote result: 6 +1; 1 +0; 0 -1 Thus the VOTE is passed and I’ve created http://jira.xwiki.org/browse/XWIKI-9971 Thanks -Vincent On 3 Feb 2014 at 08:49:33, Marius Dumitru Florea (mariusdumitru.florea(a)xwiki.com) wrote: +1 Thanks, Marius On Jan 30, 2014 3:06 PM, "vincent(a)massol.net" <vincent(a)massol.net> wrote:

...

Hi devs, I'd like to propose removing the feature of extracting the title from the

content in 6.x.

...

The rationale is: * This is costing more than it should. It needs parsing the document

content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so.

...

* Our implementation is broken since if you use an include macro that

generates a heading for ex, it won't be taken into account since we don't apply transformations ATM when computing the title since it would be even more expensive.

...

Since 6.x is about performance I believe this would be a good step

forward.

...

Now in order to handle backward compatibility. I propose that we: * Add a legacy configuration parameter to keep the behavior (but off by

default). This would be in order to let users using this feature convert their wiki

...

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Eduard Moraru

5:45 p.m.

New subject: [xwiki-devs] [VOTE] Remove feature of extracting the title from the content

+1 Thanks, Eduard On Mon, Feb 3, 2014 at 9:49 AM, Marius Dumitru Florea < mariusdumitru.florea(a)xwiki.com> wrote:

...

+1 Thanks, Marius On Jan 30, 2014 3:06 PM, "vincent(a)massol.net" <vincent(a)massol.net> wrote:

Hi devs, I'd like to propose removing the feature of extracting the title from the

content in 6.x.

The rationale is: * This is costing more than it should. It needs parsing the document

content to get its XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists (in livetables for example or in the activity stream) it costs a lot to do so.

* Our implementation is broken since if you use an include macro that

generates a heading for ex, it won't be taken into account since we don't apply transformations ATM when computing the title since it would be even more expensive.

Since 6.x is about performance I believe this would be a good step

forward.

Now in order to handle backward compatibility. I propose that we: * Add a legacy configuration parameter to keep the behavior (but off by

default). This would be in order to let users using this feature convert their wiki

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

3878

days inactive

3882

days old

xwiki-devs@xwiki.org

Manage subscription

10 comments

9 participants

tags (0)

participants (9)

Caleb James DeLisle
Denis Gervalle
Ecaterina Moraru (Valica)
Eduard Moraru
Guillaume "Louis-Marie" Delhumeau
Jeremie BOUSQUET
Marius Dumitru Florea
Thomas Mortagne
vincent＠massol.net