15 Jan
2018
15 Jan
'18
1:36 p.m.
Hi devs,
We’ve been using the surefire plugin from the beginning even for functional tests.
However it would be more correct to use the failsafe plugin for functional tests since
this allows to perform some actions if a test fails (like stopping XWiki - Note that right
now this is not affecting us since we start/stop XWiki from Java so we’ve implemented this
behavior ourselves).
I need this for using the fabric8 docker plugin for ex so that if some functional test
fails the docker containers will be stopped.
Ok with everyone?
For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/
Thanks
-Vincent
15 Jan
15 Jan
1:55 p.m.
This plugin is part of Maven project itself and state that "The
Failsafe Plugin is designed to run integration tests while the
Surefire Plugin is designed to run unit tests" so indeed it looks like
the right move :)
+1
On Mon, Jan 15, 2018 at 1:36 PM, Vincent Massol <vincent(a)massol.net> wrote:
Hi devs,
We’ve been using the surefire plugin from the beginning even for functional tests.
However it would be more correct to use the failsafe plugin for functional tests since
this allows to perform some actions if a test fails (like stopping XWiki - Note that right
now this is not affecting us since we start/stop XWiki from Java so we’ve implemented this
behavior ourselves).
I need this for using the fabric8 docker plugin for ex so that if some functional test
fails the docker containers will be stopped.
Ok with everyone?
For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/
Thanks
-Vincent
--
Thomas Mortagne
1:57 p.m.
+1
Thanks,
Marius
On Mon, Jan 15, 2018 at 2:55 PM, Thomas Mortagne <thomas.mortagne(a)xwiki.com>
wrote:
This plugin is part of Maven project itself and state
that "The
Failsafe Plugin is designed to run integration tests while the
Surefire Plugin is designed to run unit tests" so indeed it looks like
the right move :)
+1
On Mon, Jan 15, 2018 at 1:36 PM, Vincent Massol <vincent(a)massol.net>
wrote:
Hi devs,
We’ve been using the surefire plugin from the beginning even for
functional
tests.
However it would be more correct to use the failsafe plugin for
functional tests
since this allows to perform some actions if a test fails
(like stopping XWiki - Note that right now this is not affecting us since
we start/stop XWiki from Java so we’ve implemented this behavior ourselves).
I need this for using the fabric8 docker plugin for ex so that if some
functional
test fails the docker containers will be stopped.
Ok with everyone?
For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/
Thanks
-Vincent
--
Thomas Mortagne
2:23 p.m.
+1
Guillaume
2018-01-15 13:57 GMT+01:00 Marius Dumitru Florea <
mariusdumitru.florea(a)xwiki.com>gt;:
+1
Thanks,
Marius
On Mon, Jan 15, 2018 at 2:55 PM, Thomas Mortagne <
thomas.mortagne(a)xwiki.com>
wrote:
--
Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project
This plugin is part of Maven project itself and
state that "The
Failsafe Plugin is designed to run integration tests while the
Surefire Plugin is designed to run unit tests" so indeed it looks like
the right move :)
+1
On Mon, Jan 15, 2018 at 1:36 PM, Vincent Massol <vincent(a)massol.net>
wrote:
fails
Hi devs,
We’ve been using the surefire plugin from the beginning even for
functional
tests.
However it would be more correct to use the failsafe plugin for
functional tests
since this allows to perform some actions if a test (like stopping XWiki - Note that right now this
is not affecting us since
we start/stop XWiki from Java so we’ve implemented this behavior
ourselves).
I need this for using the fabric8 docker plugin for ex so that if some
functional
test fails the docker containers will be stopped.
Ok with everyone?
For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/
Thanks
-Vincent
--
Thomas Mortagne
2:33 p.m.
Hi,
+1
Thanks,
Clément
On 01/15/2018 02:23 PM, Guillaume Delhumeau wrote:
+1
Guillaume
2018-01-15 13:57 GMT+01:00 Marius Dumitru Florea <
mariusdumitru.florea(a)xwiki.com>gt;:
+1
Thanks,
Marius
On Mon, Jan 15, 2018 at 2:55 PM, Thomas Mortagne <
thomas.mortagne(a)xwiki.com>
wrote:
This plugin is part of Maven project itself and
state that "The
Failsafe Plugin is designed to run integration tests while the
Surefire Plugin is designed to run unit tests" so indeed it looks like
the right move :)
+1
On Mon, Jan 15, 2018 at 1:36 PM, Vincent Massol <vincent(a)massol.net>
wrote:
fails
Hi devs,
We’ve been using the surefire plugin from the beginning even for
functional
tests.
However it would be more correct to use the failsafe plugin for
functional tests
since this allows to perform some actions if a test (like stopping XWiki - Note that right now this
is not affecting us since
we start/stop XWiki from Java so we’ve implemented this behavior
ourselves).
I need this for using the fabric8 docker plugin for ex so that if some
functional
test fails the docker containers will be stopped.
Ok with everyone?
For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/
Thanks
-Vincent
--
Thomas Mortagne
3:14 p.m.
+ 0
Thanks,
Caty
On Mon, Jan 15, 2018 at 3:33 PM, Clément Aubin <aubincleme(a)gmail.com> wrote:
Hi,
+1
Thanks,
Clément
On 01/15/2018 02:23 PM, Guillaume Delhumeau wrote:
+1
Guillaume
2018-01-15 13:57 GMT+01:00 Marius Dumitru Florea <
mariusdumitru.florea(a)xwiki.com>gt;:
> +1
>
> Thanks,
> Marius
>
> On Mon, Jan 15, 2018 at 2:55 PM, Thomas Mortagne <
> thomas.mortagne(a)xwiki.com>
> wrote:
>
>> This plugin is part of Maven project itself and state that "The
>> Failsafe Plugin is designed to run integration tests while the
>> Surefire Plugin is designed to run unit tests" so indeed it looks like
>> the right move :)
>>
>> +1
>>
>> On Mon, Jan 15, 2018 at 1:36 PM, Vincent Massol <vincent(a)massol.net>
>> wrote:
>>> Hi devs,
>>>
>>> We’ve been using the surefire plugin from the beginning even for
>> functional tests.
>>>
>>> However it would be more correct to use the failsafe plugin for
>> functional tests since this allows to perform some actions if a test
> fails
>> (like stopping XWiki - Note that right now this is not affecting us
since
>> we start/stop XWiki from Java so we’ve
implemented this behavior
> ourselves).
>>>
>>> I need this for using the fabric8 docker plugin for ex so that if some
>> functional test fails the docker containers will be stopped.
>>>
>>> Ok with everyone?
>>>
>>> For reference: http://maven.apache.org/surefire/maven-failsafe-
plugin/
>
> Thanks
> -Vincent
>
--
Thomas Mortagne
18 Jan
18 Jan
10:58 a.m.
FYI I’m doing the following changes in order to be closer to the default configuration
values and spirit of Maven:
* Moving functional tests in src/test/java (the default, one less line in the poms)
* Differentiating the surefire tests from the failsafe tests by using test naming
conventions (again that’s the default)
* Following default test naming conventions of the failsafe plugin, i.e.
** Tests should be of the form **/*IT.java
** When we want to execute only a test suite, name it AllTestsIT.java (similar to surefire
test suites that we’re naming AllTests.java)
Let me know quickly if you see a problem with that since I’ve already started the move ;)
Thanks
-Vincent
On 15 Jan 2018, at 13:36, Vincent Massol
<vincent(a)massol.net> wrote:
Hi devs,
We’ve been using the surefire plugin from the beginning even for functional tests.
However it would be more correct to use the failsafe plugin for functional tests since
this allows to perform some actions if a test fails (like stopping XWiki - Note that right
now this is not affecting us since we start/stop XWiki from Java so we’ve implemented this
behavior ourselves).
I need this for using the fabric8 docker plugin for ex so that if some functional test
fails the docker containers will be stopped.
Ok with everyone?
For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/
Thanks
-Vincent
11:05 a.m.
On 18 Jan 2018, at 10:58, Vincent Massol
<vincent(a)massol.net> wrote:
FYI I’m doing the following changes in order to be closer to the default configuration
values and spirit of Maven:
* Moving functional tests in src/test/java (the default, one less line in the poms)
* Differentiating the surefire tests from the failsafe tests by using test naming
conventions (again that’s the default)
* Following default test naming conventions of the failsafe plugin, i.e.
** Tests should be of the form **/*IT.java
** When we want to execute only a test suite, name it AllTestsIT.java (similar to
surefire test suites that we’re naming AllTests.java)
Correction:
* It’s **/*IT.java without the “Test” part. For example: ExtensionIT.java for failsafe
tests and ExtensionTest.java for surefire tests.
* And AllITs.java for failsafe suites vs AllTests.java for surefire suites.
Thanks
-Vincent
Let me know quickly if you see a problem with that since I’ve already started the move
;)
Thanks
-Vincent
On 15 Jan 2018, at 13:36, Vincent Massol
<vincent(a)massol.net> wrote:
Hi devs,
We’ve been using the surefire plugin from the beginning even for functional tests.
However it would be more correct to use the failsafe plugin for functional tests since
this allows to perform some actions if a test fails (like stopping XWiki - Note that right
now this is not affecting us since we start/stop XWiki from Java so we’ve implemented this
behavior ourselves).
I need this for using the fabric8 docker plugin for ex so that if some functional test
fails the docker containers will be stopped.
Ok with everyone?
For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/
Thanks
-Vincent
2530
days inactive
2533
days old
7 comments
6 participants
participants (6)
-
Clément Aubin -
Ecaterina Moraru (Valica) -
Guillaume Delhumeau -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol