11 Dec
2009
11 Dec
'09
12:09 p.m.
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
Thanks,
Marius
11 Dec
11 Dec
12:20 p.m.
On 12/11/2009 12:09 PM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
+1. This feature is not used in our default installations, it's just a
toy for geeks, and geeks could re-enable it in their instance if they
really want to play with it right now.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
10:11 p.m.
+1
As a side note I'm all for making the components of XWiki more plug and play for the
user.
Caleb
Sergiu Dumitriu wrote:
On 12/11/2009 12:09 PM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
+1. This feature is not used in our default installations, it's just a
toy for geeks, and geeks could re-enable it in their instance if they
really want to play with it right now.
12:44 p.m.
+1
On Fri, Dec 11, 2009 at 12:09, Marius Dumitru Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
Thanks,
Marius
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
1:02 p.m.
On 12/11/09 12:09 PM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
+1
Jerome.
Thanks,
Marius
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
1:38 p.m.
On Dec 11, 2009, at 12:09 PM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till
we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT.
This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the
server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of
code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
+1
Can it be added by a user without rebuilding from source?
Thanks
-Vincent
2:24 p.m.
Vincent Massol wrote:
On Dec 11, 2009, at 12:09 PM, Marius Dumitru Florea
wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till
we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT.
This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the
server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of
code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
+1
Can it be added by a user without rebuilding from
source?
Right now no, mainly because GWT doesn't support reflection and if a
class is not used at compile time it doesn't appear in the generated
JavaScript code.
Thanks,
Marius
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
13 Dec
13 Dec
9:25 p.m.
Marius Dumitru Florea a écrit :
Vincent Massol wrote:
In this case I would suggest we propose a download of the version with it.
Ludovic
On Dec 11, 2009, at 12:09 PM, Marius Dumitru
Florea wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till
we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT.
This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the
server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of
code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
+1
Can it be added by a user without rebuilding from
source?
Right now no, mainly because GWT doesn't support reflection and if a
class is not used at compile time it doesn't appear in the generated
JavaScript code.
Thanks,
Marius
--
Ludovic Dubost
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
9:34 p.m.
On Dec 13, 2009, at 9:25 PM, Ludovic Dubost wrote:
Marius Dumitru Florea a écrit :
Well I don't know a lot of people who're using it (especially since
it's not usable as it is ;)). It seems a lot of overhead for us to
maintain a special distribution just for something that should not
even supported by the XWiki dev team. Actually I'd like to propose to
move it to the sandbox till someone starts working on it again and
make it functional (as we do for all other stuff we have).
Thanks
-Vincent
Vincent Massol wrote:
In this case I would suggest we propose a download of the version
with it. On Dec 11, 2009, at 12:09 PM, Marius Dumitru
Florea wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code
till
we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT.
This
library uses the generic Object class in lots of places.
Instances of
classes defined in this library are passed from the client to the
server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are
deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot
the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is
not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of
code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code
that
is really used.
Here's my +1
+1
Can it be added by a user without rebuilding from
source?
Right now no, mainly because GWT doesn't support reflection and if a
class is not used at compile time it doesn't appear in the generated
JavaScript code.
14 Dec
14 Dec
7:10 a.m.
Vincent Massol wrote:
On Dec 13, 2009, at 9:25 PM, Ludovic Dubost wrote:
Marius Dumitru Florea a écrit :
Vincent Massol wrote:
In this case I would suggest we propose a download of the version
with it. On Dec 11, 2009, at 12:09 PM, Marius Dumitru
Florea wrote:
> Hi devs,
>
> I'd like to disable the WYSIWYG sync plugin (the one that adds
> experimental support for real time editing) in the WYSIWYG code
> till
> we
> clean and refactor it. The main reason is to reduce the size of the
> JavaScript code generated by GWT:
>
> 641.3 KB when enabled
> 545.2 KB when disabled
>
> The technical explanation:
>
> The sync plugin uses a diff Java library ported by Ludovic to GWT.
> This
> library uses the generic Object class in lots of places.
> Instances of
> classes defined in this library are passed from the client to the
> server
> and back, and so they have to be serialized and deserialized. When
> fields of Object type or List<Object> or Object[] are
> deserialized on
> the client, GWT doesn't know the concrete type and thus generates
> JavaScript code to handle every possibility (i.e. all classes
> implementing IsSerializable tag interface). This increases a lot
> the
> size of the JavaScript code. Here's the warning we get during GWT
> compilation:
>
> http://pastebin.com/m61aa381f
>
> mainly:
>
> [WARN] In order to produce smaller client-side code, 'Object' is
> not
> allowed; consider using a more specific type
>
> To disable the WYSIWYG syntax plugin I have to comment one line of
> code:
>
> // WysiwygEditorFactory.java
> pfm.addPluginFactory(SyncPluginFactory.getInstance());
>
> and to remove an import. GWT compiles to JavaScript only the code
> that
> is really used.
>
> Here's my +1
>
+1
Can it be added by a user without rebuilding from
source?
Right now no, mainly because GWT doesn't support reflection and if a
class is not used at compile time it doesn't appear in the generated
JavaScript code.
Well I don't know a lot of people who're using
it (especially since
it's not usable as it is ;)). It seems a lot of overhead for us to
maintain a special distribution just for something that should not
even supported by the XWiki dev team. Actually I'd like to propose to
move it to the sandbox till someone starts working on it again and
make it functional (as we do for all other stuff we have).
It's not easy to move the sync plugin code too. Let's wait till we
upgrade to GWT 2.0 which supports code splitting (
http://code.google.com/webtoolkit/doc/latest/DevGuideCodeSplitting.html
). I'll try then to re-enable the sync plugin as a "fragment" loaded on
demand (I might do this with all the WYSIWYG plugins since we need to
load only those that are listed in the configuration).
Thanks,
Marius
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
12 Dec
12 Dec
2:50 p.m.
+1
- Asiri
On Fri, Dec 11, 2009 at 4:39 PM, Marius Dumitru Florea <
mariusdumitru.florea(a)xwiki.com> wrote:
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
Thanks,
Marius
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
13 Dec
13 Dec
9:24 p.m.
Once it's disabled, how do you get it back in ?
Ludovic
Marius Dumitru Florea a écrit :
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
Thanks,
Marius
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Ludovic Dubost
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
14 Dec
14 Dec
6:55 a.m.
Ludovic Dubost wrote:
Once it's disabled, how do you get it back in ?
1. Uncomment the line of code specified below and fix the import
2. Rebuild the platform/web/wysiwyg module
3. Update XE's resources/js/xwiki/wysiwyg/xwe directory
Marius
Ludovic
Marius Dumitru Florea a écrit :
Hi devs,
I'd like to disable the WYSIWYG sync plugin (the one that adds
experimental support for real time editing) in the WYSIWYG code till we
clean and refactor it. The main reason is to reduce the size of the
JavaScript code generated by GWT:
641.3 KB when enabled
545.2 KB when disabled
The technical explanation:
The sync plugin uses a diff Java library ported by Ludovic to GWT. This
library uses the generic Object class in lots of places. Instances of
classes defined in this library are passed from the client to the server
and back, and so they have to be serialized and deserialized. When
fields of Object type or List<Object> or Object[] are deserialized on
the client, GWT doesn't know the concrete type and thus generates
JavaScript code to handle every possibility (i.e. all classes
implementing IsSerializable tag interface). This increases a lot the
size of the JavaScript code. Here's the warning we get during GWT
compilation:
http://pastebin.com/m61aa381f
mainly:
[WARN] In order to produce smaller client-side code, 'Object' is not
allowed; consider using a more specific type
To disable the WYSIWYG syntax plugin I have to comment one line of code:
// WysiwygEditorFactory.java
pfm.addPluginFactory(SyncPluginFactory.getInstance());
and to remove an import. GWT compiles to JavaScript only the code that
is really used.
Here's my +1
Thanks,
Marius
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5443
days inactive
5446
days old
12 comments
8 participants
participants (8)
-
Asiri Rathnayake -
Caleb James DeLisle -
Jerome Velociter -
Ludovic Dubost -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol