Hi Alex, On 09/09/2010 11:35 PM, Alex Busenius wrote: I don't understand why do you say the syntax is ambiguous. I guess you consider XHTML syntax ambiguous too, because: <img src="logo.jpg" alt="logo" width="100px" height="50%" style="width: 45%; height: 100px" /> is perfectly valid. You can specify image size either using the attributes or using CSS (be it in-line, though the style attribute, or in a style sheet). CSS (both in-line and style sheet) always takes precedence over the size attributes. Thus in your example, the final image size in the browser is 45% x 100px. Note that there is a difference in what you can specify with the size attributes and what you can specify with CSS: width/height attributes accept only pixels or percent, so CSS (i.e. the style attribute) is more powerful. If the unit ( http://www.w3schools.com/css/css_units.asp ) of width/height is not pixel then I continue as if the width/height hasn't been specified. For instance, if image width/height limit is set to 800x600 in configuration then: width:30%; height:3cm => ?width=800&height=600&keepAspectRatio=true width:70px; height:3in => ?width=70 width:6em; height:20px => ?height=20 width:35px; height:15px => ?width=35&height=15 Only the dimension expressed in pixels is used. Width and height are "read" from image parameters independent of each other. Always the CSS (be it in-line or from a style sheet). Most of the time the image will be resized just once, on the server. There are some cases though when the image will be resized both on the server and on the client (by the browser). For instance: * if width and height are not expressed in pixels then the server will limit the image size based on configuration and the browser will resize the image based on specified width/height * if one of the dimensions is expressed in pixels and the other in percent (or any other unit different than pixel) then the server will scale the image using the pixel dimension and the browser will adjust the other based on the specified value. * if width and height are specified in pixels but there is an external style sheet that enforces a different image size then the server will scale the image based on the specified width/height and the browser will resize the returned image based on the external style sheet. I think you are referring to the XHTML renderer here, but my change targets all the renderers. A renderer doesn't know how to assemble the URL for an attachment or a document so it asks the WikiModel. Thomas and I discussed about adding a: String getImageURL(String documentName, String fileName, Map<String, String> parameters) method to WikiModel, that can be used by any renderer. XWikiWikiModel (our implementation) will look at the passed parameters map and if image width/height is specified them it will add this information to the query string of the attachment download URL. The fact that we look for the "width", "height" and "style" parameters is a convention. It's not related to HTML. The fact that the style image parameter contains CSS is also unrelated to HTML (CSS can be used on other types of structured content). Regarding copy-pasting custom parameters from XWiki syntax to the rendered HTML (by the XHTML renderer) I don't have a strong opinion. I don't see why it is bad from security PoV. I'll let Thomas and Vincent comment on this. This needs to be discussed in a separate thread. Thanks for your feedback, Marius

On 09/21/2010 07:58 PM, Marius Dumitru Florea wrote: Middle? OK, this is good. +1 here too. -- Sergiu Dumitriu http://purl.org/net/sergiu/

On 09/21/2010 08:41 PM, Marius Dumitru Florea wrote: + I would say the same, middle.

Hi Andreas, On 09/23/2010 10:10 AM, Andreas Hahn wrote: Sure, you can set: rendering.imageDimensionsIncludedInImageURL = false (it's true by default) in xwiki.properties configuration file. Note that the new behavior applies only to images included using the xwiki/2.0 syntax, if at least one of the image dimensions are specified: [[image:picture.png||width="150px"]] So if you include images in a different way (e.g. xwiki/1.0 syntax or HTML syntax) then you shouldn't be affected. In other words, if you control the image URL and you don't specify image dimensions in the query string then the original image will be loaded. Now, you say that you display thumbnails on the page and when the user clicks them the full size image is displayed. Are the thumbnails generated on the server or are they in fact the original images resized by the browser? Couldn't you use the new behavior for displaying the thumbnails and then use the image URL without the query string to load the full size image in the light box? This way users that are not interested in the details don't have to download full size images when viewing the page. An example of this behavior, without the light box is: [[[[image:picture.png||width="150px"]]>>attach:picture.png]] Hope this helps, Marius