New subject: [xwiki-devs] Fwd: [xwiki-notifications] r15438 - enterprise/trunk enterprise/trunk/wiki platform/core/trunk/xwiki-core/src/main/resources platform/web/trunk/standard/src/main/webapp/templates platform/xwiki-applications/trunk platform/xwiki-applications/trunk/web

16 Jan 2009

---------- Forwarded message ----------
From: Asiri Rathnayake &lt;asiri.rathnayake(a)gmail.com&gt;
Date: Fri, Jan 16, 2009 at 12:37 PM
Subject: Re: [xwiki-notifications] r15438 - enterprise/trunk
enterprise/trunk/wiki platform/core/trunk/xwiki-core/src/main/resources
platform/web/trunk/standard/src/main/webapp/templates
platform/xwiki-applications/trunk platform/xwiki-applications/trunk/webd
To: XWiki Notifications &lt;notifications(a)xwiki.org&gt;

Hi Segiu,

...
   +      
#set($documentUrl=$doc.getExternalURL("download"))
 +               #set($attachmentUrl="$documentUrl/$attach.filename")
 +          #set($attachmentSignature="/xwiki/bin/download/")
 +          #set($webdavSignature="/xwiki/webdav/spaces/") 
 This isn't safe. It is possible to change this completely. Better use:

#set($attachmentSignature="${request.contextPath}${request.servletPath}/download/")
 #set($webdavSignature="${request.contextPath}/webdav/spaces/")

Fixed.

Also, this doesn't work with the new "virtualwiki-as-path" URLs.

I don't think webdav supports "virtualwiki-as-path" configuration yet.
I'll
have to look into it.

...
   +         
#set($fragments=$attachmentUrl.split($attachmentSignature))
 +          #if($listtool.size($fragments) == 2)
 +            #set($prefix=$listtool.get($fragments, 0))
 +            #set($suffix=$listtool.get($fragments, 1))
 +            #set($davUrl="$prefix$webdavSignature$suffix")
 +            <span class="xwikibuttonlinks"><a
class="deletelink" 
href="javascript:davEdit('$davUrl')">$msg.get("webdaveditattachment")</a></span>

 You should escape $davUrl, because if it contains ' or " it will break. 

I tried to do this but for some reason the url got changed to an invalid one
once i escaped it. It's kind of weird, the local application tried to open
some url like /home/asiri/http://..... I'm still not sure why this happens.

...
  Added:
platform/xwiki-applications/trunk/webdav/pom.xml

===================================================================
 --- platform/xwiki-applications/trunk/webdav/pom.xml       (rev 0)
  +++
platform/xwiki-applications/trunk/webdav/pom.xml  2009-01-15 10:00:35  UTC (rev
15438)
  @@ -0,0 +1,14 @@ 
 Don't forget to add our License header (for all files in this app).

Fixed.

...
   +      
InstallTrigger.install( {"FoXWiki" :" 
https://addons.mozilla.org/en-US/firefox/downloads/file/39674/foxwiki-1.0b-…
 "});

 Isn't there a version-independent URL, so that we don't have to release
 application-webdav each time we release foxwiki? 

Unfortunately no, the url has to point to an xpi file. But this is not a
problem since Firefox automatically detects extension updates. And since
FoXWiki is hosted in addons.mozilla.org this is done automatically. All we
have to do is release the new version in addons.mozilla.org and users will
be notifed of the existance of a newer version.

Thanks.

- Asiri