Re: [xwiki-devs] Moving the xwiki.org skin as part of our distribution - xwiki-devs@xwiki.org

16 Jan 2008

Hi,
I understand your point.
I have again one doubt here.

In the code we currently get the skin name and then generate the file path
(for velocity files) such as skins/<skin name>/<vm file name>.

If we go by option 2 then in this case if skin name is albatross we would
have to generate path as templates/ and for rest we would continue to use
the old file path. This would involve writing such if else condition in
xwiki code.

Would this be elegant way of handling skins?

How would this be handled in the code.

Thanks
Sachin

...
  Date: Wed, 16 Jan 2008 17:06:24 +0100
 From: Vincent Massol &lt;vincent(a)massol.net&gt;
 Subject: Re: [xwiki-devs] Moving the xwiki.org skin as part of our
        distribution
 To: XWiki Developers &lt;devs(a)xwiki.org&gt;
 Message-ID: &lt;86A70FC8-9A1F-421C-ACED-4BFE22374B3E(a)massol.net&gt;
 Content-Type: text/plain; charset="us-ascii"

 On Jan 16, 2008, at 4:56 PM, sachin mittal wrote:

  Hi,
 I have few doubts here:
 Currently templates directory have their own vm files.
 So would the first task be copy the vm files under albatross
 directory to templates directory and merge the common templates file.

 Next other wiki skins have their own vm files and leaving them in
 their respective skins directory is not a good (uniform) idea.
 So these should also be moved (shouldn't it). 
 We have 2 options:
 1) Create templates that work for all current skins: dodo, finch and
 albatross
 2) Consider that dodo and finch are history, make them use their own
 templates and not use any of the templates in templates/, clean the
 templates dir and replace them by the albatross vm files.

 2) is much easier but 1) is nicer. I prefer 2).

  Best would be to create sub directories under
templates directory
 with same structure as skins directory. 
 That would defeat the notion of templates IMO.

  Lastly regarding your point:
 Another thing to do would be to "clean"  the albatross templates so
 that they are lighter, generate less style elements, etc.

 I  completely agree to this. In fact to get ExtJs working with the
 html content created by albatross vm files I had to delete lot of
 unnecessary style elements, merge lot of vm files in single files. I
 feel that vm files under albatross are lot scattered and having few
 compact vm files would be much better.
 Would this improve the performance too? (I don't know that) 
 No idea.

 Thanks
 -Vincent