+1. I don't like it very much either but I don't have any better proposal.

WDYT about asking our users their opinion ?

On Fri, Nov 28, 2008 at 6:23 PM, Jerome Velociter <jerome(a)xwiki.com> wrote: _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

+1 Response to Sergiu, I wrote the code and Thomas reviewed it, and it has been written defensively. I think it's better in a release than as a branch. How about making the string a parameter. We could use "wiki" as the default. It could be better than "subwiki"

Sergiu Dumitriu wrote: > Thomas Mortagne wrote: > >> Hi devs, >> >> I just finished a feature to be able to use mutiwiki without any use >> of virtual host (ans so no need for a configured DNS server). It >> does >> not replace the DNS based multiwiki it just add another way to >> access >> subwiki so you can still use both. However all the URLs will be >> generated in a way or another depending if urlpath is enabled or >> not. >> >> So basically it add the possibility to access the wiki "wikiname" >> using http://127.0.0.1/xwiki/subwiki/wikinname/view/Main/WebHome. >> >> See http://jira.xwiki.org/jira/browse/XWIKI-2824 >> >> Normally I would wait for 1.8 branch to commit this but we have an >> internal need for it to be included in the 1.6 branch (and if it's >> included in 1.6, why not include this in 1.7 ;)). >> >> Can we include it safely in 1.6/1.7 ? : it should be, if you don't >> enable xwiki.virtual.urlpath in xwiki.cfg (and it will be disabled >> by >> default), all will work exactly like this feature did not exists. >> >> Here is my +1 >> > > -0. .x releases are supposed to contain only important bugfixes > (although we broke this rule in the past). I'd rather make a branch > for > the client that needs it, and introduce it in 1.8 only. For 1.7, > this is > not tested yet, so it is dangerous to introduce it now. >