Re: [xwiki-devs] [xwiki-notifications] r10099 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/stats/impl - xwiki-devs@xwiki.org

4 Jun 2008

On Jun 4, 2008, at 4:52 AM, sdumitriu (SVN) wrote:

...
  Author: sdumitriu
 Date: 2008-06-04 04:52:41 +0200 (Wed, 04 Jun 2008)
 New Revision: 10099

 Modified:
   xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ 
 stats/impl/StatsUtil.java
 Log:
 [misc] Don't use a local variable to hide the class member.

 Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ 
 xwiki/stats/impl/StatsUtil.java
 ===================================================================
 --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ 
 stats/impl/StatsUtil.java	2008-06-04 02:51:14 UTC (rev 10098)
 +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ 
 stats/impl/StatsUtil.java	2008-06-04 02:52:41 UTC (rev 10099)
 @@ -590,7 +590,7 @@
         cookie.setMaxAge(time);

         String cookieDomain = null;
 -        String[] cookieDomains = StatsUtil.getCookieDomains(context);
 +        getCookieDomains(context); 
btw this is a badly named method if it has some side effects other  
than getting cookie domains...

-Vincent

...

         if (cookieDomains != null) {
             String servername = context.getRequest().getServerName();
             for (int i = 0; i < cookieDomains.length; i++) { 