tmortagne (SVN) wrote: A quick review of the xwiki-script module: - DefaultScriptContextManager and ScriptExecutionContextInitializer should be in the internal package. - ScriptExecutionContextInitializer is not declared in components.xml, thus it is not used. - getScriptContext calls the initializers on each call. Is that correct? Shouldn't the context be initialized only once? - scriptContextInitializerList (which also contains a typo in its name) could be completely injected by Plexus, thus there's no need for Initializable and Composable on this class. Just declare a dependency on ScriptContextInitializer components. - The javadocs on the interfaces could be improved... They are rather short right now. -- Sergiu Dumitriu http://purl.org/net/sergiu/