Re: [xwiki-devs] [xwiki-notifications] r25026 - enterprise/trunk/wiki/src/main/resources/Main
12 Nov
2009
12 Nov
'09
2:51 p.m.
On Nov 12, 2009, at 2:49 PM, jvdrean (SVN) wrote:
Author: jvdrean
Date: 2009-11-12 14:49:46 +0100 (Thu, 12 Nov 2009)
New Revision: 25026
Modified:
enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
Log:
XE-551 : Main.RecentChanges - page recent comment display error
Modified: enterprise/trunk/wiki/src/main/resources/Main/
RecentChanges.xml
===================================================================
--- enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
2009-11-12 09:04:11 UTC (rev 25025)
+++ enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
2009-11-12 13:49:46 UTC (rev 25026)
@@ -568,7 +568,7 @@
#set($previousAuthor = "")
## Get this very doc, useful when it is included from another one.
#set($recentChangesDoc = $xwiki.getDocument("Main.RecentChanges"))
-{{html}}
+{{html clean="false"}}
JV, why do you use clean=false?
If it means we have invalid HTML I think it should be fixed instead,
wdyt?
Thanks
-Vincent
<table class="recentChanges"
summary="$msg.get('xe.recentchanges.summary')">
<tr class="recentChangesHeader"><th>
$msg.get("xe.recentchanges.column.authoranddate")</
th><th>$msg.get("xe.recentchanges.column.changes")</
th></tr>
#foreach ($rcDocName in $rcDocumentNames)
@@ -607,7 +607,9 @@
<div class="commentQuote
lQuo">&nbsp;</
div>
<div class="commentQuote
rQuo">&nbsp;</
div>
<div class="comment">
- $lastComment.get("comment")
+ {{/html}}
+ $lastComment.get("comment")
+ {{html clean="false"}}
</div>
## Display discussion link, this link point to the
comments anchor.
<div class="commentAdd"><img
src="$xwiki.getSkinFile("icons/silk/comment.gif")" alt="Reply
icon" /
> <a href="${rcDoc.getURL("view")}#Comments">
$msg.get("xe.recentchanges.entry.comment.seediscussion")</
a></div>
12 Nov
12 Nov
2:54 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r25026 - enterprise/trunk/wiki/src/main/resources/Main
On Thu, Nov 12, 2009 at 2:51 PM, Vincent Massol <vincent(a)massol.net> wrote:
On Nov 12, 2009, at 2:49 PM, jvdrean (SVN) wrote:
The HTML is valid but split between 2 {{html}} blocks, I've used
clean=false to prevent the cleaning from closing HTML elements.
JV.
Author: jvdrean
Date: 2009-11-12 14:49:46 +0100 (Thu, 12 Nov 2009)
New Revision: 25026
Modified:
enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
Log:
XE-551 : Main.RecentChanges - page recent comment display error
Modified: enterprise/trunk/wiki/src/main/resources/Main/
RecentChanges.xml
===================================================================
--- enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
2009-11-12 09:04:11 UTC (rev 25025)
+++ enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
2009-11-12 13:49:46 UTC (rev 25026)
@@ -568,7 +568,7 @@
#set($previousAuthor = "")
## Get this very doc, useful when it is included from another one.
#set($recentChangesDoc = $xwiki.getDocument("Main.RecentChanges"))
-{{html}}
+{{html clean="false"}}
JV, why do you use clean=false?
If it means we have invalid HTML I think it should be fixed instead,
wdyt?
2:55 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r25026 - enterprise/trunk/wiki/src/main/resources/Main
On Thu, Nov 12, 2009 at 2:51 PM, Vincent Massol <vincent(a)massol.net> wrote:
On Nov 12, 2009, at 2:49 PM, jvdrean (SVN) wrote:
The HTML is valid but split between 2 {{html}} blocks, I've used
clean=false to prevent the cleaning from closing HTML elements.
JV.
Author: jvdrean
Date: 2009-11-12 14:49:46 +0100 (Thu, 12 Nov 2009)
New Revision: 25026
Modified:
enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
Log:
XE-551 : Main.RecentChanges - page recent comment display error
Modified: enterprise/trunk/wiki/src/main/resources/Main/
RecentChanges.xml
===================================================================
--- enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
2009-11-12 09:04:11 UTC (rev 25025)
+++ enterprise/trunk/wiki/src/main/resources/Main/RecentChanges.xml
2009-11-12 13:49:46 UTC (rev 25026)
@@ -568,7 +568,7 @@
#set($previousAuthor = "")
## Get this very doc, useful when it is included from another one.
#set($recentChangesDoc = $xwiki.getDocument("Main.RecentChanges"))
-{{html}}
+{{html clean="false"}}
JV, why do you use clean=false?
If it means we have invalid HTML I think it should be fixed instead,
wdyt?
5425
days inactive
5425
days old
2 comments
2 participants
participants (2)
-
Jean-Vincent Drean -
Vincent Massol