28 Aug
2011
28 Aug
'11
12:29 p.m.
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in our
legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
Thanks
-Vincent
28 Aug
28 Aug
12:53 p.m.
New subject: [xwiki-devs] [VOTE] Remove unnecessary javadoc for overriding methods
+1
Caleb
On 08/28/2011 06:29 AM, Vincent Massol wrote:
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
12:59 p.m.
+1
On Sun, Aug 28, 2011 at 12:29 PM, Vincent Massol <vincent(a)massol.net> wrote:
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
9:25 p.m.
On Aug 28, 2011, at 12:29 PM, Vincent Massol wrote:
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
ok in case you're wondering if using @override is valid when implementing an
interface, here's a little detective work:
1) If you read Java 6 javadoc you'll find in
http://download.oracle.com/javase/6/docs/api/java/lang/Override.html:
"Indicates that a method declaration is intended to override a method declaration in
a superclass. If a method is annotated with this annotation type but does not override a
superclass method, compilers are required to generate an error message."
So this seems to indicate it's not valid. However…
2) If your read http://blogs.oracle.com/ahe/entry/override_snafu you'll find that the
javadoc for 1.6 isn't correct (read also
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5008260) and reading
http://stackoverflow.com/questions/212614/should-a-method-that-implements-a…
will show you that actually using @override is supported when implementing an interface in
Java 6 but not in Java 5… ;)
Some more reading about using @override:
http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-ann…
Thanks
-Vincent
29 Aug
29 Aug
8:09 a.m.
On Sun, Aug 28, 2011 at 9:25 PM, Vincent Massol <vincent(a)massol.net> wrote:
On Aug 28, 2011, at 12:29 PM, Vincent Massol wrote:
Apart from the documentation I would add two things that you can see
by yourself:
* Eclipse JDT automatically put the @override when implementing on
interface and using Java 6 (at least with Eclipse 3.7).
* javac fail to build when using @override when implementing on Java 5
and is OK on Java 6 so it's probably new
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
ok in case you're wondering if using @override is valid when implementing an
interface, here's a little detective work:
1) If you read Java 6 javadoc you'll find in
http://download.oracle.com/javase/6/docs/api/java/lang/Override.html:
"Indicates that a method declaration is intended to override a method declaration in
a superclass. If a method is annotated with this annotation type but does not override a
superclass method, compilers are required to generate an error message."
So this seems to indicate it's not valid. However…
2) If your read http://blogs.oracle.com/ahe/entry/override_snafu you'll find that the
javadoc for 1.6 isn't correct (read also
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5008260) and reading
http://stackoverflow.com/questions/212614/should-a-method-that-implements-a…
will show you that actually using @override is supported when implementing an interface in
Java 6 but not in Java 5… ;)
Some more reading about using @override:
http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-ann…
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
7:10 a.m.
+1
Thanks,
Marius
On Sun, Aug 28, 2011 at 1:29 PM, Vincent Massol <vincent(a)massol.net> wrote:
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
6:20 p.m.
New subject: [xwiki-devs] [VOTE] Remove unnecessary javadoc for overriding methods
On 08/28/2011 06:29 AM, Vincent Massol wrote:
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
+1, but:
Will checkstyle succeed?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
8:51 p.m.
On Aug 29, 2011, at 6:20 PM, Sergiu Dumitriu wrote:
On 08/28/2011 06:29 AM, Vincent Massol wrote:
Yes (see above my first line ;)).
Thanks
-Vincent
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
+1, but:
Will checkstyle succeed?
30 Aug
30 Aug
10:12 a.m.
New subject: [xwiki-devs] [VOTE] Remove unnecessary javadoc for overriding methods (SUMMARY)
Result: 5 +1, no 0, no -1
The vote is passed and I've updated
http://dev.xwiki.org/xwiki/bin/view/Community/JavaCodeStyle#HDonotduplicate…
Thanks
-Vincent
On Aug 28, 2011, at 12:29 PM, Vincent Massol wrote:
Hi devs,
I've just realized that using @override is enough to generate a proper javadoc copied
from the overriden method and that checkstyle doesn't complain either.
Basically instead of writing:
/**
* {@inheritDoc}
*
* @see org.xwiki.logging.LoggerManager#popLogListener()
*/
@Override
public EventListener popLogListener()
We can simply write:
@Override
public EventListener popLogListener()
Advantages:
1) Less text to type and smaller class files
2) Less duplicated text
I thus propose to use this from now and to progressively remove unnecessary javadoc in
our legacy code.
BTW this is also explained in the javadoc tool:
See section "Automatic Reuse of Method Comments" in
http://download.oracle.com/javase/1.3/docs/tooldocs/win32/javadoc.html
WDYT?
Here's my +1
Thanks
-Vincent
4819
days inactive
4821
days old
8 comments
5 participants
participants (5)
-
Caleb James DeLisle -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol