On Tue, Feb 2, 2010 at 16:25, Sergiu Dumitriu<sergiu(a)xwiki.com> wrote: Actually we don't need to list checked files, we list here because we don't want to check all files.

> >> + **/rendering/internal/renderer/DefaultLinkLabelGenerator.java, >> + **/rendering/internal/renderer/AttachURILabelGenerator.java, >> + **/rendering/internal/renderer/MailtoURILabelGenerator.java, >> **/rendering/listener/*.java, >> **/rendering/listener/chaining/AbstractChainingListener.java, >> **/rendering/listener/chaining/ChainingListener.java, > >> Added: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/MailtoURILabelGenerator.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/MailtoURILabelGenerator.java (rev 0) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/MailtoURILabelGenerator.java 2010-02-02 14:51:13 UTC (rev 26602) >> +@Component("mailto") >> +public class MailtoURILabelGenerator implements URILabelGenerator >> +{ >> + /** >> + * The MAILTO URI prefix (the scheme followed by ":"). >> + */ >> + private static final String MAILTO = "mailto:"; >> + >> + /** >> + * {@inheritDoc} >> + * @see org.xwiki.rendering.renderer.URILabelGenerator#generateLabel(org.xwiki.rendering.listener.Link) >> + */ >> + public String generateLabel(Link link) >> + { >> + String label = link.getReference().substring(MAILTO.length()); > > StringUtils.removeStart(label, MAILTO) is safer. > >> + // Also remove the query string part from the label (we only want the email address). > > return StringUtils.substringBefore("?") is shorter. > >> + int queryStringPosition = label.indexOf("?"); >> + if (queryStringPosition> -1) { >> + label = label.substring(0, queryStringPosition); >> + } >> + return label; >> + } >> +}