Re: [xwiki-devs] [xwiki-notifications] r27152 - platform/core/trunk/xwiki-rendering/xwiki-rendering-api
19 Feb
2010
19 Feb
'10
10:04 a.m.
On Feb 19, 2010, at 9:20 AM, tmortagne (SVN) wrote:
Author: tmortagne
Date: 2010-02-19 09:20:16 +0100 (Fri, 19 Feb 2010)
New Revision: 27152
Modified:
platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
Log:
XWIKI-4884: Hide the first and last new line when editing a standalone macro
Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
===================================================================
--- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:07:39
UTC (rev 27151)
+++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:20:16
UTC (rev 27152)
@@ -199,7 +199,7 @@
<configuration>
<!-- TODO: To be removed when we release XWiki 2.3 -->
<excludes>
-
<exclude>org/xwiki/rendering/internal/renderer/xwiki/XWikiSyntaxMacroRenderer</exclude>
+ <exclude>**/internal/**</exclude>
Is this not less good than what we had before?
Thanks
-Vincent
<exclude>org/xwiki/rendering/syntax/SyntaxFactory</exclude>
<exclude>org/xwiki/rendering/internal/parser/DefaultSyntaxFactory</exclude>
</excludes>
19 Feb
19 Feb
10:35 a.m.
New subject: [xwiki-devs] [xwiki-notifications] r27152 - platform/core/trunk/xwiki-rendering/xwiki-rendering-api
On Fri, Feb 19, 2010 at 10:04, Vincent Massol <vincent(a)massol.net> wrote:
On Feb 19, 2010, at 9:20 AM, tmortagne (SVN) wrote:
This is more consistent with our rule (i.e. everything in
**/internal/** is not public and so we don't really care about
modifications in it). Would be even better to not have to list this
one at all and that it's always by default but i don't think it's
possible to do that (I think i tried that already some time ago).
Author: tmortagne
Date: 2010-02-19 09:20:16 +0100 (Fri, 19 Feb 2010)
New Revision: 27152
Modified:
platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
Log:
XWIKI-4884: Hide the first and last new line when editing a standalone macro
Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
===================================================================
--- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:07:39
UTC (rev 27151)
+++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:20:16
UTC (rev 27152)
@@ -199,7 +199,7 @@
<configuration>
<!-- TODO: To be removed when we release XWiki 2.3 -->
<excludes>
-
<exclude>org/xwiki/rendering/internal/renderer/xwiki/XWikiSyntaxMacroRenderer</exclude>
+ <exclude>**/internal/**</exclude>
Is this not less good than what we had before?
Thanks
-Vincent
--
Thomas Mortagne
<exclude>org/xwiki/rendering/syntax/SyntaxFactory</exclude>
<exclude>org/xwiki/rendering/internal/parser/DefaultSyntaxFactory</exclude>
</excludes>
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
10:43 a.m.
New subject: [xwiki-devs] [xwiki-notifications] r27152 - platform/core/trunk/xwiki-rendering/xwiki-rendering-api
On Feb 19, 2010, at 10:35 AM, Thomas Mortagne wrote:
On Fri, Feb 19, 2010 at 10:04, Vincent Massol
<vincent(a)massol.net> wrote:
oh sorry I thought this was about checkstyle....
On Feb 19, 2010, at 9:20 AM, tmortagne (SVN) wrote:
This is more consistent with our rule (i.e. everything in
**/internal/** is not public and so we don't really care about
modifications in it). Author: tmortagne
Date: 2010-02-19 09:20:16 +0100 (Fri, 19 Feb 2010)
New Revision: 27152
Modified:
platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
Log:
XWIKI-4884: Hide the first and last new line when editing a standalone macro
Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
===================================================================
--- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:07:39
UTC (rev 27151)
+++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:20:16
UTC (rev 27152)
@@ -199,7 +199,7 @@
<configuration>
<!-- TODO: To be removed when we release XWiki 2.3 -->
<excludes>
-
<exclude>org/xwiki/rendering/internal/renderer/xwiki/XWikiSyntaxMacroRenderer</exclude>
+ <exclude>**/internal/**</exclude>
Is this not less good than what we had before? Would be even better to not have to list this
one at all and that it's always by default but i don't think it's
possible to do that (I think i tried that already some time ago).
It's done globally already :)
The only problem is that if you add a single item more then your config overrides the
default config.
Thanks
-Vincent
11:24 a.m.
New subject: [xwiki-devs] [xwiki-notifications] r27152 - platform/core/trunk/xwiki-rendering/xwiki-rendering-api
On Fri, Feb 19, 2010 at 10:43, Vincent Massol <vincent(a)massol.net> wrote:
On Feb 19, 2010, at 10:35 AM, Thomas Mortagne wrote:
Yes that's what i mean.
On Fri, Feb 19, 2010 at 10:04, Vincent Massol
<vincent(a)massol.net> wrote:
oh sorry I thought this was about checkstyle....
On Feb 19, 2010, at 9:20 AM, tmortagne (SVN) wrote:
This is more consistent with our rule (i.e. everything in
**/internal/** is not public and so we don't really care about
modifications in it). Author: tmortagne
Date: 2010-02-19 09:20:16 +0100 (Fri, 19 Feb 2010)
New Revision: 27152
Modified:
platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
Log:
XWIKI-4884: Hide the first and last new line when editing a standalone macro
Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml
===================================================================
--- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:07:39
UTC (rev 27151)
+++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/pom.xml 2010-02-19 08:20:16
UTC (rev 27152)
@@ -199,7 +199,7 @@
<configuration>
<!-- TODO: To be removed when we release XWiki 2.3 -->
<excludes>
-
<exclude>org/xwiki/rendering/internal/renderer/xwiki/XWikiSyntaxMacroRenderer</exclude>
+ <exclude>**/internal/**</exclude>
Is this not less good than what we had before? Would be even better to not have to list this
one at all and that it's always by default but i don't think it's
possible to do that (I think i tried that already some time ago).
It's done globally already :)
The only problem is that if you add a single item more then your config overrides the
default config.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
5376
days inactive
5376
days old
3 comments
2 participants
participants (2)
-
Thomas Mortagne -
Vincent Massol