What happens if someone is upgrading to 5.3 from an earlier version and thus has some UI pages from wiki manager or workspaces UI? I guess they'll be broken since the JARs won't be there anymore which isn't nice. So the minimum is to document this in the release notes to explain that they'll need to remove those pages/spaces (we need to make it easy for them by specifically listing what to delete). Another option is to improve those pages so that they check if the API is there and if not they display some nice message. We release this in 5.3. Then after some time we remove those apps as you suggetsed.

Any other idea? Thanks -Vincent On Wed, Nov 13, 2013 at 5:46 PM, Thomas Mortagne < thomas.mortagne(a)xwiki.com&gt; wrote:

What happens if someone is upgrading to 5.3 from an earlier version and thus has some UI pages from wiki manager or workspaces UI? I guess they'll be broken since the JARs won't be there anymore which isn't nice.

So the minimum is to document this in the release notes to explain that they'll need to remove those pages/spaces (we need to make it easy for them by specifically listing what to delete). Another option is to improve those pages so that they check if the API is there and if not they display some nice message. We release this in 5.3. Then after some time we remove those apps as you suggetsed. Any other idea? Thanks -Vincent On Wed, Nov 13, 2013 at 5:46 PM, Thomas Mortagne &lt;thomas.mortagne(a)xwiki.com&gt;wrote;wrote: _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

+0 Thanks, Marius On Wed, Nov 13, 2013 at 6:45 PM, Guillaume "Louis-Marie" Delhumeau &lt;gdelhumeau(a)xwiki.com&gt; wrote: > Hi devs. > > Thomas has merged my pull request for the new wiki API. I'm happy! > > Now, xwiki-platform-wiki-manager and xwiki-platform-workspaces are > obsoletes. We should delete them or move them to xwiki-contrib. > > Here is my +1 for the move! > > Thanks > Louis-Marie > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs

FWIW these are the locations, some of them look like they're non-extension. Thanks, Caleb user@ubnta8:~/wrk/xwiki-trunks$ find ./ -wholename '*/target/*' -prune -o -wholename '*/.git/*' -prune -o -type f -exec grep 'services.wikimanager' {} \; -print <content>#set($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-tools/xwiki-platform-tool-xmldoc-update-plugin/src/test/resources/SampleWikiXMLDocument.input <title>#set($wikiDescriptor = $services.wikimanager.getWikiDocument($xcontext.database))#{if}("$!wikiDescriptor.getValue('wikiprettyname')" != '')$wikiDescriptor.getValue('wikiprettyname')#{else}$wikiDescriptor.wikiName#{end}</title> ./xwiki-platform/xwiki-platform-core/xwiki-platform-workspace/xwiki-platform-workspace-template-features/src/main/resources/Main/WebHome.xml #set ($wiki = $services.wikimanager.getWikiFromDocumentName("$documentReference")) ./xwiki-platform/xwiki-platform-core/xwiki-platform-workspace/xwiki-platform-workspace-ui/src/main/resources/WorkspaceManager/WorkspacesSuggestSolrService.xml #set($itemWikiDocument = $services.wikimanager.getWikiFromDocumentName($itemfullname)) ./xwiki-platform/xwiki-platform-core/xwiki-platform-workspace/xwiki-platform-workspace-ui/src/main/resources/WorkspaceManager/WorkspacesSuggestLuceneService.xml #set ($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-workspace/xwiki-platform-workspace-ui/src/main/resources/WorkspaceManager/CreateNewWorkspace.xml #set ($itemWikiDocument = $services.wikimanager.getWikiFromDocumentName($itemDoc.fullName)) ./xwiki-platform/xwiki-platform-core/xwiki-platform-workspace/xwiki-platform-workspace-ui/src/main/resources/WorkspaceManager/BrowseWorkspacesLiveTableResultsMacros.xml #set ($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-workspace/xwiki-platform-workspace-ui/src/main/resources/WorkspaceManager/Install.xml #if (!$services.wikimanager.isWikiNameAvailable($request.wikiname)) #if ($services.wikimanager.getWikiFromName($request.wikiname).isNew()) ./xwiki-platform/xwiki-platform-core/xwiki-platform-workspace/xwiki-platform-workspace-ui/src/main/resources/WorkspaceManager/IsWikiOrDatabaseOrWorkspaceAvailableService.xml #set ($wikiPrettyName = $services.wikimanager.getWikiDocument($wikiName).wikiPrettyName) ./xwiki-platform/xwiki-platform-core/xwiki-platform-web/src/main/webapp/templates/extension.vm #set ($wikiName = $!{services.wikimanager.getWikiDocument($xcontext.getDatabase()).getWikiPrettyName()}) ./xwiki-platform/xwiki-platform-core/xwiki-platform-web/src/main/webapp/templates/menuview.vm #if($services.wikimanager) #set($wikiPrettyName = $services.wikimanager.getWikiDocument($wikiName).getWikiPrettyName()) ./xwiki-platform/xwiki-platform-core/xwiki-platform-watchlist/xwiki-platform-watchlist-ui/src/main/resources/XWiki/XWikiUserWatchListLiveTableResults.xml #set ($wikiPrettyName = $services.wikimanager.getWikiDocument($wikiName).wikiPrettyName) #set ($wikiPrettyName = $services.wikimanager.getWikiDocument($searchResult.wiki).wikiPrettyName) ./xwiki-platform/xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-ui/src/main/resources/Main/SolrSearch.xml #set ($wikiPrettyName = $services.wikimanager.getWikiDocument($wiki).wikiPrettyName) ./xwiki-platform/xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-ui/src/main/resources/XWiki/SolrSearchAdmin.xml #set($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiManager/WebHome.xml #set ($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiManager/CreateNewWiki.xml #set($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiCode/UserWikisIsUserWidget.xml #set($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiCode/UserWikisIsAdminWidget.xml #set($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiCode/LastCreatedWikisCode.xml #set($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiCode/UserWikisIsOwnerWidget.xml #if (!$services.wikimanager.isWikiNameAvailable($request.wikiname)) #if ($services.wikimanager.getWikiFromName($request.wikiname).isNew()) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiCode/IsWikiOrDatabaseAvailableService.xml #set($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/WikiCode/LastWikiModificationsCode.xml #set ($WikiManager = $services.wikimanager) ./xwiki-platform/xwiki-platform-core/xwiki-platform-wiki-manager/xwiki-platform-wiki-manager-ui/src/main/resources/XWiki/XWikiServerClassSheet.xml #if ($xwiki.isVirtualMode() && $services.wikimanager) #set ($wikiName = $services.wikimanager.getWikiDocument($xcontext.getDatabase()).getWikiPrettyName()) ./xwiki-manager/xwiki-manager-web/overlays/org.xwiki.enterprise.xwiki-enterprise-web-3.5.1/templates/menuview.vm #if ("$!{services.wikimanager.getWikiTemplateDocument('workspacetemplate')}" == '') ./xwiki-manager/xwiki-manager-ui/src/main/resources/Main/WebHome.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/WikiManager/Dashboard.es.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/WikiManager/Dashboard.lv.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/WikiManager/Dashboard.sv.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/WikiManager/Dashboard.fr.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/WikiManager/Dashboard.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/WikiManager/Dashboard.it.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/WikiManager/Dashboard.ca.xml <content>#set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/src/main/resources/XemManager/Install.xml <content>#set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/XemManager/Install.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/WikiManager/Dashboard.ca.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/WikiManager/Dashboard.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/WikiManager/Dashboard.it.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/WikiManager/Dashboard.es.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/WikiManager/Dashboard.lv.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/WikiManager/Dashboard.fr.xml #set($WikiManager = $services.wikimanager) ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/WikiManager/Dashboard.sv.xml #if ("$!{services.wikimanager.getWikiTemplateDocument('workspacetemplate')}" == '') ./xwiki-manager/xwiki-manager-ui/target-eclipse/classes/Main/WebHome.xml user@ubnta8:~/wrk/xwiki-trunks$ On 11/22/2013 11:40 AM, Marius Dumitru Florea wrote: _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On Fri, Nov 22, 2013 at 12:04 PM, Caleb James DeLisle &lt;cjd(a)hyperboria.ca&gt; wrote:

I created http://jira.xwiki.org/browse/XWIKI-9713, I'm sure Guillaume just forgot to check xwiki-platform-web.

xwiki-platform-wiki-manager is of course not relevant, xwiki-platform-workspace properly declare a dependency on wikimanager and others are suposed to declare that dependency and wrongly don't. -- Thomas Mortagne _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

Why doesn't anybody listen to me when I say that it's wrong to just move out APIs without a proper deprecation period? It's not OK to ever remove individual methods that are 100% unused, but it's OK to completely remove a whole plugin that is still being actively used without even a single release worth of notice... On 11/22/2013 05:40 AM, Marius Dumitru Florea wrote:

You are mixing very different things here, removing a single method from a class break everything that use that method, period. You can't do anything to use your old extension except rewrite it. So no it's really not the same thing... As for this specific use case, we are talking about a module that never been part of XE except in 5.2 and any extension properly written have it in dependency so the fact that it's in XE or not does not really change much for those. On Fri, Nov 22, 2013 at 5:11 PM, Sergiu Dumitriu &lt;sergiu(a)xwiki.com&gt; wrote: > Why doesn't anybody listen to me when I say that it's wrong to just move > out APIs without a proper deprecation period? It's not OK to ever remove > individual methods that are 100% unused, but it's OK to completely > remove a whole plugin that is still being actively used without even a > single release worth of notice... > > On 11/22/2013 05:40 AM, Marius Dumitru Florea wrote: >> Guys, I didn't pay enough attention to this topic (thus my +0) but >> what we did is very bad! I used myself $services.wikimanager in lots >> of places and I'm sure others have used it also (especially since we >> moved to virtual mode on by default) so we cannot simply remove an API >> like this. This is not different than removing a method or a class >> from a public API (which would be caught by CLIRR). We need to apply >> the same deprecation strategy: mark $services.wikimanager as >> deprecated, move to legacy, log warning messages when it is used, >> update all places in platform where it is currently used, etc. >> >> I just found out that the Wiki search facet isn't displayed as I >> advertised it in the release notes of 5.3M2 >> http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWiki53M2#HSea… >> because the Wiki Manager API has been removed >> https://github.com/xwiki/xwiki-enterprise/commit/b8fcbc7267ff587807698b4afd… >> after I closed my issue http://jira.xwiki.org/browse/XWIKI-9613 .. >> >> We need ensure that the public API of Wiki Manager (e.g. the script >> service) is still available. It can wrap the new API or it can do what >> it currently does but it has to remain available. >> >> Thanks, >> Marius >> >> On Thu, Nov 14, 2013 at 5:56 PM, Marius Dumitru Florea >> &lt;mariusdumitru.florea(a)xwiki.com&gt; wrote: >>> +0 >>> >>> Thanks, >>> Marius >>> >>> On Wed, Nov 13, 2013 at 6:45 PM, Guillaume "Louis-Marie" Delhumeau >>> &lt;gdelhumeau(a)xwiki.com&gt; wrote: >>>> Hi devs. >>>> >>>> Thomas has merged my pull request for the new wiki API. I'm happy! >>>> >>>> Now, xwiki-platform-wiki-manager and xwiki-platform-workspaces are >>>> obsoletes. We should delete them or move them to xwiki-contrib. >>>> >>>> Here is my +1 for the move!