Re: [xwiki-devs] [xwiki-notifications] r9958 - xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/app
28 May
2008
28 May
'08
12:55 p.m.
Hi Anca,
A possible improvement below.
On May 28, 2008, at 12:47 PM, lucaa (SVN) wrote:
Author: lucaa
Date: 2008-05-28 12:47:56 +0200 (Wed, 28 May 2008)
New Revision: 9958
Modified:
xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java
Log:
XWIKI-2408: Default XWikiService URL not created correctly in hosted
mode in XWikiGWTDefaultApp
* added a test for the ending character of the module base URL
returned by GWT
Modified: xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/
gwt/api/client/app/XWikiGWTDefaultApp.java
===================================================================
--- xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:40:44 UTC (rev 9957)
+++ xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:47:56 UTC (rev 9958)
@@ -181,10 +181,15 @@
if (serviceInstance == null) {
serviceInstance = (XWikiServiceAsync)
GWT.create(XWikiService.class);
String defaultXWikiService;
- if (GWT.isScript())
+ if (GWT.isScript()) {
defaultXWikiService =
XWikiGWTAppConstants.XWIKI_DEFAULT_BASE_URL +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
- else
- defaultXWikiService = GWT.getModuleBaseURL() +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
+ } else {
+ String moduleBaseURL = GWT.getModuleBaseURL();
+ if (moduleBaseURL.endsWith("/")) {
+ moduleBaseURL = moduleBaseURL.substring(0,
moduleBaseURL.length() - 1);
+ }
// Here, explain why we need to remove the last "/" if it's there and
why it's not deterministic
String moduleBaseURL = StringUtils.chomp(GWT.getModuleBaseURL(), "/");
+ defaultXWikiService = moduleBaseURL +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
+ }
((ServiceDefTarget)
serviceInstance).setServiceEntryPoint(getParam("xwikiservice" ,
defaultXWikiService));
}
return serviceInstance;
Thanks
-Vincent
28 May
28 May
1:32 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r9958 - xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/clien t/app
Hi Anca,
A possible improvement below.
On May 28, 2008, at 12:47 PM, lucaa (SVN) wrote:
org.apache.commons.lang.StringUtils?
How is GWT going to compile this?
Author: lucaa
Date: 2008-05-28 12:47:56 +0200 (Wed, 28 May 2008)
New Revision: 9958
Modified:
xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java
Log:
XWIKI-2408: Default XWikiService URL not created correctly in hosted
mode in XWikiGWTDefaultApp
* added a test for the ending character of the module base URL
returned by GWT
Modified: xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/
gwt/api/client/app/XWikiGWTDefaultApp.java
===================================================================
--- xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:40:44 UTC (rev 9957)
+++ xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:47:56 UTC (rev 9958)
@@ -181,10 +181,15 @@
if (serviceInstance == null) {
serviceInstance = (XWikiServiceAsync)
GWT.create(XWikiService.class);
String defaultXWikiService;
- if (GWT.isScript())
+ if (GWT.isScript()) {
defaultXWikiService =
XWikiGWTAppConstants.XWIKI_DEFAULT_BASE_URL +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
- else
- defaultXWikiService = GWT.getModuleBaseURL() +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
+ } else {
+ String moduleBaseURL = GWT.getModuleBaseURL();
+ if (moduleBaseURL.endsWith("/")) {
+ moduleBaseURL = moduleBaseURL.substring(0,
moduleBaseURL.length() - 1);
+ }
// Here, explain why we need to remove the last "/" if it's there and
why it's not deterministic
String moduleBaseURL = StringUtils.chomp(GWT.getModuleBaseURL(), "/");
+ defaultXWikiService = moduleBaseURL +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
+ }
((ServiceDefTarget)
serviceInstance).setServiceEntryPoint(getParam("xwikiservice" ,
defaultXWikiService));
}
return serviceInstance;
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
1:38 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r9958 - xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/clien t/app
On May 28, 2008, at 1:32 PM, Marius Dumitru Florea wrote:
I don't know much about GWT, I admit :) I thought it was java code.
Are you saying that we can't use any external Java library in GWT code?
Thanks
-Vincent
Hi Anca,
A possible improvement below.
On May 28, 2008, at 12:47 PM, lucaa (SVN) wrote:
org.apache.commons.lang.StringUtils?
How is GWT going to compile this? Author: lucaa
Date: 2008-05-28 12:47:56 +0200 (Wed, 28 May 2008)
New Revision: 9958
Modified:
xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java
Log:
XWIKI-2408: Default XWikiService URL not created correctly in hosted
mode in XWikiGWTDefaultApp
* added a test for the ending character of the module base URL
returned by GWT
Modified: xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/
gwt/api/client/app/XWikiGWTDefaultApp.java
===================================================================
--- xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/
api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:40:44 UTC (rev
9957)
+++ xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/
api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:47:56 UTC (rev
9958)
@@ -181,10 +181,15 @@
if (serviceInstance == null) {
serviceInstance = (XWikiServiceAsync)
GWT.create(XWikiService.class);
String defaultXWikiService;
- if (GWT.isScript())
+ if (GWT.isScript()) {
defaultXWikiService =
XWikiGWTAppConstants.XWIKI_DEFAULT_BASE_URL +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
- else
- defaultXWikiService = GWT.getModuleBaseURL() +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
+ } else {
+ String moduleBaseURL = GWT.getModuleBaseURL();
+ if (moduleBaseURL.endsWith("/")) {
+ moduleBaseURL = moduleBaseURL.substring(0,
moduleBaseURL.length() - 1);
+ }
// Here, explain why we need to remove the last "/" if it's there and
why it's not deterministic
String moduleBaseURL = StringUtils.chomp(GWT.getModuleBaseURL(),
"/");
2:01 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r9958 - xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/clien t/app
On May 28, 2008, at 1:32 PM, Marius Dumitru Florea wrote:
I don't know much about GWT, I admit :) I thought it was java code.
Are you saying that we can't use any external Java library in GWT code?
GWT compiles the Java client code into JavaScript. To be able to do this
it emulates a subset of the Java runtime library. See
http://tinyurl.com/n8vlw for the full list of supported classes. If an
external Java library uses only this classes then, theoretically, we could
use that library in GWT code, with some little adjustments. See
http://tinyurl.com/4aonrx on how to do that.
Hi Anca,
A possible improvement below.
On May 28, 2008, at 12:47 PM, lucaa (SVN) wrote:
org.apache.commons.lang.StringUtils?
How is GWT going to compile this? Author: lucaa
Date: 2008-05-28 12:47:56 +0200 (Wed, 28 May 2008)
New Revision: 9958
Modified:
xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/
client/app/XWikiGWTDefaultApp.java
Log:
XWIKI-2408: Default XWikiService URL not created correctly in hosted
mode in XWikiGWTDefaultApp
* added a test for the ending character of the module base URL
returned by GWT
Modified: xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/
gwt/api/client/app/XWikiGWTDefaultApp.java
===================================================================
--- xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/
api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:40:44 UTC (rev
9957)
+++ xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/
api/
client/app/XWikiGWTDefaultApp.java 2008-05-28 10:47:56 UTC (rev
9958)
@@ -181,10 +181,15 @@
if (serviceInstance == null) {
serviceInstance = (XWikiServiceAsync)
GWT.create(XWikiService.class);
String defaultXWikiService;
- if (GWT.isScript())
+ if (GWT.isScript()) {
defaultXWikiService =
XWikiGWTAppConstants.XWIKI_DEFAULT_BASE_URL +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
- else
- defaultXWikiService = GWT.getModuleBaseURL() +
XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE;
+ } else {
+ String moduleBaseURL = GWT.getModuleBaseURL();
+ if (moduleBaseURL.endsWith("/")) {
+ moduleBaseURL = moduleBaseURL.substring(0,
moduleBaseURL.length() - 1);
+ }
// Here, explain why we need to remove the last "/" if it's there and
why it's not deterministic
String moduleBaseURL = StringUtils.chomp(GWT.getModuleBaseURL(),
"/");
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
2:18 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r9958 - xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/clien t/app
On May 28, 2008, at 2:01 PM, Marius Dumitru Florea wrote:
[snip]
GWT compiles the Java client code into JavaScript. To be able to do
this
it emulates a subset of the Java runtime library. See
http://tinyurl.com/n8vlw for the full list of supported classes. If an
external Java library uses only this classes then, theoretically, we
could
use that library in GWT code, with some little adjustments. See
http://tinyurl.com/4aonrx on how to do that.
ok thanks for the explanation. So forget what I said, this is too
complex and not worth it :)
Thanks
-Vincent
org.apache.commons.lang.StringUtils?
How is GWT going to compile this?
I don't know much about GWT, I admit :) I thought it was java code.
Are you saying that we can't use any external Java library in GWT
code?
5955
days inactive
5955
days old
4 comments
2 participants
participants (2)
-
Marius Dumitru Florea -
Vincent Massol