19 Jun
2010
19 Jun
'10
8:15 p.m.
Hi,
I believe we need to implement skin inheritence for file system skins.
We do have skin inheritence for skins stored in Wiki pages but we don't
have it for FS skins.
So we cannot have
albatross <-> colibri <-> myskin <-> wiki page skin
To implement this we could just use a file called "parent" which would
contain the name of the parent skin.
WDYT ?
Ludovic
--
Ludovic Dubost
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
20 Jun
20 Jun
12:07 a.m.
On 06/19/2010 08:15 PM, Ludovic Dubost wrote:
Hi,
I believe we need to implement skin inheritence for file system skins.
We do have skin inheritence for skins stored in Wiki pages but we don't
have it for FS skins.
So we cannot have
albatross <-> colibri <-> myskin <-> wiki page skin
To implement this we could just use a file called "parent" which would
contain the name of the parent skin.
WDYT ?
Yep, we definitely need proper inheritance for skins. The current
algorithm only allows at most 3 skins on the path:
1. Current skin.
2. If the current skin is a document object, and it has a parent field,
use the parent skin.
3. Use the default base skin, the one defined in xwiki.cfg
So, even with wiki document skins, there's only room for one more skin
between 1 and 3. It would be great to have full inheritance support,
with as many items as needed on the hierarchy, including wiki and
filesystem skins.
As for the implementation, how about a "MANIFEST.MF" file instead of
"parent"?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
5300
days inactive
5300
days old
1 comments
2 participants
participants (2)
-
Ludovic Dubost -
Sergiu Dumitriu